From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: [PATCH v3 04/10] libxl: avoid leaking in libxl__initia_device_remove Date: Tue, 14 Jul 2015 17:41:07 +0100 Message-ID: <1436892073-14186-5-git-send-email-wei.liu2@citrix.com> References: <1436892073-14186-1-git-send-email-wei.liu2@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZF3Gi-0002Rm-0S for xen-devel@lists.xenproject.org; Tue, 14 Jul 2015 16:41:20 +0000 In-Reply-To: <1436892073-14186-1-git-send-email-wei.liu2@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Xen-devel Cc: Wei Liu , Ian Jackson , Ian Campbell List-Id: xen-devel@lists.xenproject.org Change "return" to "goto out_success" to correctly dispose of the structure. Signed-off-by: Wei Liu --- tools/libxl/libxl_device.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/libxl/libxl_device.c b/tools/libxl/libxl_device.c index 2493972..bee5ed5 100644 --- a/tools/libxl/libxl_device.c +++ b/tools/libxl/libxl_device.c @@ -816,7 +816,7 @@ void libxl__initiate_device_remove(libxl__egc *egc, be_path); goto out; } - return; + goto out_success; } } @@ -868,6 +868,7 @@ void libxl__initiate_device_remove(libxl__egc *egc, goto out; } +out_success: libxl_dominfo_dispose(&info); return; -- 1.9.1