From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v4 07/17] xen/arm: ITS: Add virtual ITS commands support Date: Wed, 15 Jul 2015 14:56:35 +0100 Message-ID: <1436968595.32371.78.camel@citrix.com> References: <1436514172-3263-1-git-send-email-vijay.kilari@gmail.com> <1436514172-3263-8-git-send-email-vijay.kilari@gmail.com> <1436538916.10074.58.camel@citrix.com> <55A65A03.50503@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <55A65A03.50503@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: vijay.kilari@gmail.com, stefano.stabellini@eu.citrix.com, Prasun.Kapoor@caviumnetworks.com, vijaya.kumar@caviumnetworks.com, tim@xen.org, xen-devel@lists.xen.org, stefano.stabellini@citrix.com, manish.jaggi@caviumnetworks.com List-Id: xen-devel@lists.xenproject.org On Wed, 2015-07-15 at 15:02 +0200, Julien Grall wrote: > Hi Ian, > > On 10/07/2015 16:35, Ian Campbell wrote: > >> diff --git a/xen/include/asm-arm/gic.h b/xen/include/asm-arm/gic.h > >> index 44c2317..fdd96c8 100644 > >> --- a/xen/include/asm-arm/gic.h > >> +++ b/xen/include/asm-arm/gic.h > >> @@ -24,6 +24,7 @@ > >> #define NR_GIC_LPI 4096 > >> #define MAX_LPI (FIRST_GIC_LPI + NR_GIC_LPI) > >> #define MAX_RDIST_COUNT 4 > >> +#define BIT_48_12_MASK 0xfffffffff000UL > > > > I think you should use ~PAGE_MASK instead of defining this. > > This used to get the physical address in the GITS_CBASER register. This > field is not based on the Xen page granularity neither 4KB granularity. > It's just a field containing the bits [47:12] of the address. Then it should be GITS_CBASER_PA_MASK or something along those lines. Ian. > > Therefore it would be very strange to use PAGE_MASK and an hypothetical > 4K_MASK. Though I would prefer the latter. >