From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH for-4.6] tools/hotplug: Add an initscript to start "xl devd" in a driver domain Date: Wed, 15 Jul 2015 16:37:40 +0100 Message-ID: <1436974660.32371.117.camel@citrix.com> References: <1436890874.11153.14.camel@citrix.com> <1436958450-14336-1-git-send-email-ian.campbell@citrix.com> <21926.31994.329837.650986@mariner.uk.xensource.com> <55A67DBD.3090006@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <55A67DBD.3090006@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: George Dunlap Cc: wei.liu2@citrix.com, Konrad Rzeszutek Wilk , Roger Pau =?ISO-8859-1?Q?Monn=E9?= , Ian Jackson , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Wed, 2015-07-15 at 16:35 +0100, George Dunlap wrote: > On 07/15/2015 04:32 PM, Ian Jackson wrote: > > Ian Campbell writes ("[PATCH for-4.6] tools/hotplug: Add an initscript to start "xl devd" in a driver domain"): > >> The removal of the udev rules highlighted that although it has been > >> replaced by "xl devd" there isn't an initscript to replace it. > > > > Despite > > > >> +# NOTE: This initscript is not needed on dom0. > > > > I didn't see anything which would stop it running on dom0. I don't > > think running it on dom0 is a good idea; it might fight with libxl. Good point. > I think Ian's idea was that the admin should know not to run it in dom0, > and only enable it in driver domains. > > Do you think we should do something to actively prevent it running in > dom0? Do we have a good way to determine whether we're in dom0 or not? > (Or more apropos, whether we're running in the toolstack domain?) Actually, when I cribbed from xencommons I removed the test for "am I in dom0". I think what I should have done was invert it... I don't know of an equivalent test for the *BSDs. Ian.