From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH v3 10/10] libxl: fix caller of libxl_cpupool
 functions
Date: Thu, 16 Jul 2015 14:49:44 +0200
Message-ID: <1437050984.28251.21.camel@citrix.com>
References: <1436892073-14186-1-git-send-email-wei.liu2@citrix.com>
	<1436892073-14186-11-git-send-email-wei.liu2@citrix.com>
	<21925.18402.35455.636018@mariner.uk.xensource.com>
	<20150715171643.GI12455@zion.uk.xensource.com>
	<1437037044.13522.219.camel@citrix.com> <55A77998.9090307@suse.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8835125977317202502=="
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=632400b94=dario.faggioli@citrix.com>)
	id 1ZFibz-0000xa-GX
	for xen-devel@lists.xenproject.org; Thu, 16 Jul 2015 12:50:03 +0000
In-Reply-To: <55A77998.9090307@suse.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Juergen Gross <jgross@suse.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wei.liu2@citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Ian Campbell <ian.campbell@citrix.com>
List-Id: xen-devel@lists.xenproject.org

--===============8835125977317202502==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-T4AuqoiiDObD6YjpbSDs"

--=-T4AuqoiiDObD6YjpbSDs
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, 2015-07-16 at 11:30 +0200, Juergen Gross wrote:
> On 07/16/2015 10:57 AM, Dario Faggioli wrote:
> > [Adding Juergen]
>=20
> Near miss. You took my old mail address. :-)
>=20
Sorry for this! That's what I have in the MUA... Apparently it's never
got updated as the most of the mail I sent to you go via `stg mail'! :-P

> > On Wed, 2015-07-15 at 18:16 +0100, Wei Liu wrote:

> >> I think I need to overhaul cpupool_info a bit if we want to make this
> >> API better.
> >>
> > Well, perhaps having cpupool_info() treating specially the situation
> > where the pool ID is not there may help... However, what would you do
> > once you have this additional piece of information available?
> >
> > Maybe, depending on the error, we can cleanup the whole array? Is it
> > this that we are after?
>=20
> I think the best would be:
>=20
> Modify cpupool_info() to return either success, internal error, or no
> cpupool found.
>=20
> In case of internal error libxl_list_cpupool() should clean up and
> return NULL.
>
Agreed.

> > Sorry, what you mean by 'interleave pool ids'?
>=20
> Not sure if this is an answer to interleaving of pool ids, but it is
> possible to specify the pool id when creating a new cpupool at the
> libxc interface. Even in case this is not used, pool ids can easily
> be sparse after having deleted a cpupool.
>=20
Exactly, but that should not be a problem.

Regards,
Dario
--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

--=-T4AuqoiiDObD6YjpbSDs
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEABECAAYFAlWnqHMACgkQk4XaBE3IOsQreACgoMPtz8G6id5oQwdVHwEr4ZgK
nfUAnj2E3FkY+jxPUiZtfj37mkFdJXrb
=aoAF
-----END PGP SIGNATURE-----

--=-T4AuqoiiDObD6YjpbSDs--


--===============8835125977317202502==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============8835125977317202502==--