From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH V3 1/1] libxl: set stub domain size based on
 VRAM size
Date: Thu, 16 Jul 2015 16:51:43 +0100
Message-ID: <1437061903.32371.232.camel@citrix.com>
References: <1436650242-1067-1-git-send-email-eshelton@pobox.com>
	<1436650242-1067-2-git-send-email-eshelton@pobox.com>
	<1436953503.11153.36.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=63240c440=Ian.Campbell@citrix.com>)
	id 1ZFlS9-0006qN-VY
	for xen-devel@lists.xenproject.org; Thu, 16 Jul 2015 15:52:06 +0000
In-Reply-To: <1436953503.11153.36.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Eric Shelton <eshelton@pobox.com>
Cc: xen-devel@lists.xenproject.org, stefano.stabellini@eu.citrix.com, wei.liu2@citrix.com, ian.jackson@eu.citrix.com, samuel.thibault@ens-lyon.org
List-Id: xen-devel@lists.xenproject.org

On Wed, 2015-07-15 at 10:45 +0100, Ian Campbell wrote:
> On Sat, 2015-07-11 at 17:30 -0400, Eric Shelton wrote:
> > Allocate additional memory to the stub domain for qemu-traditional if
> > more than 4 MB is assigned to the video adapter to avoid out of memory
> > condition for QEMU.
> 
> In reply to v2 (after you'd sent v3, I think) Ian J said:
> > Well, it does also reduce the stubdom memory when the video memory is
> > <4Mby.  That sounds plausible to me but at the very least the commit
> > message needs changing, and maybe we should wait a bit to see if one
> > of the qemu experts objects.
> 
> libxl__domain_build_info_setdefault ensures, for qemu-xen-traditional,
> that video_memkb is either precisely 4M (TYPE_CIRRUS) or >= 8M
> (TYPE_STD) but allows a free choice for TYPE_NONE, defaulting to 0 (I'd
> almost expect it to insist on 0, but there you are).
> 
> I suggest adding a second paragraph to the commit message:
> 
>         For LIBXL_VGA_INTERFACE_TYPE_STD + CIRRUS video_memkb is always
>         at least 4MB. However if LIBXL_VGA_INTERFACE_TYPE_STD is
>         selected the video_memkb defaults to 0, resulting in a stubdom
>         which is 4MB smaller than before. It seems unlikely that VGA
>         disable would require more memory then the other options, so
>         this should be ok.
> 
> I'm happy to add that while I commit and will Ack + do so tomorrow
> unless somebody objects during today.

Done.