xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: david.vrabel@citrix.com, konrad.wilk@oracle.com
Cc: elena.ufimtseva@oracle.com, ian.campbell@citrix.com,
	stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com,
	tim@xen.org, linux-kernel@vger.kernel.org, jbeulich@suse.com,
	xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com,
	ian.jackson@eu.citrix.com, roger.pau@citrix.com
Subject: [PATCH v2 4/6] xen/x86/pvh: Set up descriptors for 32-bit PVH guests
Date: Thu, 16 Jul 2015 17:43:39 -0400	[thread overview]
Message-ID: <1437083021-24488-5-git-send-email-boris.ostrovsky@oracle.com> (raw)
In-Reply-To: <1437083021-24488-1-git-send-email-boris.ostrovsky@oracle.com>

Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
---
Changes in v2:
* Set segment selectors using loadsegment() instead of assembly

 arch/x86/xen/enlighten.c | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c
index f8dc398..d665b1d 100644
--- a/arch/x86/xen/enlighten.c
+++ b/arch/x86/xen/enlighten.c
@@ -1362,12 +1362,12 @@ static void __init xen_boot_params_init_edd(void)
 static void __ref xen_setup_gdt(int cpu)
 {
 	if (xen_feature(XENFEAT_auto_translated_physmap)) {
-#ifdef CONFIG_X86_64
-		unsigned long dummy;
+		unsigned long __attribute__((unused)) dummy;
 
-		load_percpu_segment(cpu); /* We need to access per-cpu area */
+		setup_stack_canary_segment(cpu);
 		switch_to_new_gdt(cpu); /* GDT and GS set */
 
+#ifdef CONFIG_X86_64
 		/* We are switching of the Xen provided GDT to our HVM mode
 		 * GDT. The new GDT has  __KERNEL_CS with CS.L = 1
 		 * and we are jumping to reload it.
@@ -1392,8 +1392,13 @@ static void __ref xen_setup_gdt(int cpu)
 		loadsegment(ds, 0);
 		loadsegment(fs, 0);
 #else
-		/* PVH: TODO Implement. */
-		BUG();
+		asm volatile ("ljmp %0,$1f\n"
+			      "1:\n"
+			      :: "i" (__KERNEL_CS));
+
+		loadsegment(ss, __KERNEL_DS);
+		loadsegment(ds, __USER_DS);
+		loadsegment(es, __USER_DS);
 #endif
 		return; /* PVH does not need any PV GDT ops. */
 	}
-- 
1.8.1.4

  parent reply	other threads:[~2015-07-16 21:44 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-16 21:43 [PATCH v2 0/6] 32-bit PVH domU support Boris Ostrovsky
2015-07-16 21:43 ` [PATCH v2 1/6] xen/x86/pvh: Save %rbx in xen_pvh_early_cpu_init() Boris Ostrovsky
2015-07-16 21:43 ` [PATCH v2 2/6] xen/x86: Remove unnecessary memset() call Boris Ostrovsky
2015-07-16 21:43 ` [PATCH v2 3/6] xen/x86/pvh: Properly set page tables for 32-bit PVH guests Boris Ostrovsky
2015-07-16 21:43 ` Boris Ostrovsky [this message]
2015-07-17 15:21   ` [PATCH v2 4/6] xen/x86/pvh: Set up descriptors " Konrad Rzeszutek Wilk
     [not found]   ` <20150717152113.GB18085@l.oracle.com>
2015-07-17 15:36     ` Boris Ostrovsky
     [not found]     ` <55A920FD.6050101@oracle.com>
2015-07-17 16:43       ` Konrad Rzeszutek Wilk
     [not found]       ` <20150717164331.GA19827@l.oracle.com>
2015-07-17 17:52         ` Boris Ostrovsky
     [not found]         ` <55A940CC.6090509@oracle.com>
2015-07-21 15:32           ` Boris Ostrovsky
2015-07-16 21:43 ` [PATCH v2 5/6] xen/x86/pvh: Add 32-bit PVH initialization code Boris Ostrovsky
2015-07-16 21:43 ` [PATCH v2 6/6] xen/x86/pvh: Allow building 32-bit PVH guests Boris Ostrovsky
     [not found] ` <1437083021-24488-2-git-send-email-boris.ostrovsky@oracle.com>
2015-07-17 15:09   ` [PATCH v2 1/6] xen/x86/pvh: Save %rbx in xen_pvh_early_cpu_init() Konrad Rzeszutek Wilk
     [not found] ` <1437083021-24488-6-git-send-email-boris.ostrovsky@oracle.com>
2015-07-17 15:21   ` [PATCH v2 5/6] xen/x86/pvh: Add 32-bit PVH initialization code Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1437083021-24488-5-git-send-email-boris.ostrovsky@oracle.com \
    --to=boris.ostrovsky@oracle.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=david.vrabel@citrix.com \
    --cc=elena.ufimtseva@oracle.com \
    --cc=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=jbeulich@suse.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roger.pau@citrix.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).