From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Patch RFC 1/4] usb: support device specification
 via <bus>-<port>
Date: Fri, 17 Jul 2015 08:59:47 +0200
Message-ID: <1437116387.3689.8.camel@redhat.com>
References: <1437061658-11769-1-git-send-email-jgross@suse.com>
	<1437061658-11769-2-git-send-email-jgross@suse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1437061658-11769-2-git-send-email-jgross@suse.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xensource.com, stefano.stabellini@eu.citrix.com
List-Id: xen-devel@lists.xenproject.org

On Do, 2015-07-16 at 17:47 +0200, Juergen Gross wrote:
> Today a host usb device can be specified either via <vendor>:<product>
> or via <bus>.<device> syntax. Add the possibility to specify it via
> <bus>-<port> as this is needed for the support of xen pvusb backend.

-device usb-host,hostbus=<bus>,hostport=<port> should already do what
you want.

> diff --git a/hw/usb/host-legacy.c b/hw/usb/host-legacy.c
> index 3cc9c42..526108c 100644
> --- a/hw/usb/host-legacy.c
> +++ b/hw/usb/host-legacy.c

I don't think we should extend this.  This exists purely for backward
compatibility reasons.

> +out:
>      qdev_prop_set_uint32(&dev->qdev, "hostbus",   filter.bus_num);
>      qdev_prop_set_uint32(&dev->qdev, "hostaddr",  filter.addr);
> +    if (filter.port) {
> +        qdev_prop_set_string(&dev->qdev, "port",  filter.port);

Hmm?  This should have been "hostport", right?

cheers,
  Gerd