From: Dario Faggioli <dario.faggioli@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: xen-devel@lists.xenproject.org,
Ian Jackson <ian.jackson@eu.citrix.com>,
Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH] xl: fix vcpus to vnode assignement in config file
Date: Fri, 17 Jul 2015 19:15:56 +0200 [thread overview]
Message-ID: <1437153356.23656.38.camel@citrix.com> (raw)
In-Reply-To: <20150717160802.GQ12455@zion.uk.xensource.com>
[-- Attachment #1.1: Type: text/plain, Size: 2599 bytes --]
On Fri, 2015-07-17 at 17:08 +0100, Wei Liu wrote:
> On Fri, Jul 17, 2015 at 05:57:49PM +0200, Dario Faggioli wrote:
> > Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
> > ---
> > Cc: Wei Liu <wei.liu2@citrix.com>
> > Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> > Cc: Ian Campbell <ian.campbell@citrix.com>
>
> With two issues mentioned below fixed:
>
> Acked-by: Wei Liu <wei.liu2@citrix.com>
>
Thanks.
> > --- a/tools/libxl/xl_cmdimpl.c
> > +++ b/tools/libxl/xl_cmdimpl.c
> > @@ -1076,9 +1076,7 @@ static void parse_vnuma_config(const XLU_Config *config,
> > /* Temporary storage for parsed vcpus information to avoid
> > * parsing config twice. This array has num_vnuma elements.
> > */
>
> Delete this comment as well.
>
Can I ask why? I think it's still accurate, actually...
> > - struct vcpu_range_parsed {
> > - unsigned long start, end;
> > - } *vcpu_range_parsed;
> > + libxl_bitmap *vcpu_parsed;
> > @@ -1095,7 +1093,14 @@ static void parse_vnuma_config(const XLU_Config *config,
> >
> > b_info->num_vnuma_nodes = num_vnuma;
> > b_info->vnuma_nodes = xcalloc(num_vnuma, sizeof(libxl_vnode_info));
> > - vcpu_range_parsed = xcalloc(num_vnuma, sizeof(*vcpu_range_parsed));
> > + vcpu_parsed = xcalloc(num_vnuma, sizeof(libxl_bitmap));
> > + for (i = 0; i < num_vnuma; i++) {
> > + libxl_bitmap_init(&vcpu_parsed[i]);
> > + if (libxl_cpu_bitmap_alloc(ctx, &vcpu_parsed[i], b_info->max_vcpus)) {
> > + fprintf(stderr, "libxl_node_bitmap_alloc failed.\n");
> > + exit(1);
> > + }
> > + }
> >
> > for (i = 0; i < b_info->num_vnuma_nodes; i++) {
> > libxl_vnode_info *p = &b_info->vnuma_nodes[i];
> > @@ -1165,12 +1170,14 @@ static void parse_vnuma_config(const XLU_Config *config,
> > split_string_into_string_list(value, ",", &cpu_spec_list);
> > len = libxl_string_list_length(&cpu_spec_list);
> >
> > - for (j = 0; j < len; j++)
> > + for (j = 0; j < len; j++) {
> > parse_range(cpu_spec_list[j], &s, &e);
> > + for (; s <=e; s++) {
>
> Space before e.
>
Bha! Sure, sorry for this.
Regards,
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2015-07-17 17:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-17 15:57 [PATCH] xl: fix vcpus to vnode assignement in config file Dario Faggioli
2015-07-17 16:08 ` Wei Liu
2015-07-17 17:15 ` Dario Faggioli [this message]
2015-07-17 17:19 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437153356.23656.38.camel@citrix.com \
--to=dario.faggioli@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).