From: Ian Campbell <ian.campbell@citrix.com>
To: Yang Hongyang <yanghy@cn.fujitsu.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Wei Liu <wei.liu2@citrix.com>
Cc: Wen Congyang <wency@cn.fujitsu.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Jiang Yunhong <yunhong.jiang@intel.com>,
Dong Eddie <eddie.dong@intel.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
Gui Jianfeng <guijianfeng@cn.fujitsu.com>
Subject: Re: Request a freeze exception for COLO in v4.6
Date: Tue, 21 Jul 2015 14:42:23 +0100 [thread overview]
Message-ID: <1437486143.8383.27.camel@citrix.com> (raw)
In-Reply-To: <55ACA2D6.5020403@cn.fujitsu.com>
On Mon, 2015-07-20 at 15:27 +0800, Yang Hongyang wrote:
>
> On 07/17/2015 06:18 PM, Ian Jackson wrote:
> > Wei Liu writes ("Re: [Xen-devel] Request a freeze exception for
> > COLO in v4.6"):
> > > Ian and Ian, anything to add? What are your opinions?
> >
> > I think COLO is an exciting and important feature.
> >
> > Unfortunately I agree with Wei that at this stage taking both
> > series
> > as they currently stand into 4.6 is not tenable. (Perhaps if I had
> > been able to help earlier in the release cycle this would have been
> > different; so for that I'm sorry.)
> >
> >
> > I would like to see at least the early parts of `COLOPre' in
> > staging
> > as soon as possible. There is much preparatory work there which
> > would
> > be annoying to rebase around, and which has collateral benefits.
>
> Thanks, if you are going to merge some of the patches, there is the
> latest version of `COLOPre' patchset:
> https://github.com/macrosheep/xen/tree/colo-v9
> The latest 26 commits.
> I think all patches are ready to be merged except:
I would have taken this to mean "are acked", but in fact a reasonable
number of these aren't, although you have addressed the comments from
last time.
I acked these on the basis of what was in the branch:
libxl/remus: introduce libxl__remus_setup
tools/libxl: Update libxl_domain_unpause() to support qemu-xen
(this one was acked-by Wei with my suggestion, which you've
done so I added it)
but many of the rest have changes which are significant enough to
require reposting IMHO, because I don't feel comfortable acking them
while cherry-picking. (as it happens many wouldn't apply without 7
anyway
> 7 libxl/remus: init checkpoint_callback in Remus checkpoint callback
Unfortunately this had severe knock on effects, i.e. patch 8 onwards
didn't cleanly apply.
I did manage to pick up:
15 tools/libxl: check QEMU state before resume dm
I'm afraid that between the need to repost a bunch of this and the lack
of #7 I only managed to get these 8 to apply:
8db1a08 tools/libxl: Update libxl_domain_unpause() to support qemu-xen
4301269 tools/libxl: check QEMU state before resume dm
c3e886a libxl/remus: introduce libxl__remus_teardown
c230261 libxl/remus: introduce libxl__remus_setup
8dd129f tools/libxl: rename remus checkpoint callbacks
bc3e7ff tools/libxl: move domain resume code into libxl_dom_suspend.c
f1fe54e tools/libxl: move domain suspend code into libxl_dom_suspend.c
73db059 tools/libxl: rename libxl__domain_suspend to libxl__domain_save
Sorting out #7 and reposting would probably unblock a pretty big chunk
of the rest, I think.
Ian.
next prev parent reply other threads:[~2015-07-21 13:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-15 10:17 Request a freeze exception for COLO in v4.6 Yang Hongyang
2015-07-16 15:00 ` Wei Liu
2015-07-17 0:15 ` Dong, Eddie
2015-07-17 10:18 ` Ian Jackson
2015-07-17 10:52 ` Wei Liu
2015-07-20 7:27 ` Yang Hongyang
2015-07-21 13:42 ` Ian Campbell [this message]
2015-07-17 16:04 Eddie Dong
2015-07-20 14:02 ` Lars Kurth
2015-07-20 15:55 ` Lars Kurth
2015-07-17 16:29 Eddie Dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437486143.8383.27.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=eddie.dong@intel.com \
--cc=guijianfeng@cn.fujitsu.com \
--cc=wei.liu2@citrix.com \
--cc=wency@cn.fujitsu.com \
--cc=xen-devel@lists.xen.org \
--cc=yanghy@cn.fujitsu.com \
--cc=yunhong.jiang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).