From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH RFC] libxl: fix build with glibc < 2.9 Date: Tue, 21 Jul 2015 15:06:29 +0100 Message-ID: <1437487589.8383.34.camel@citrix.com> References: <55AD223C02000078000932DC@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZHYPm-0007FS-94 for xen-devel@lists.xenproject.org; Tue, 21 Jul 2015 14:21:02 +0000 In-Reply-To: <55AD223C02000078000932DC@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , xen-devel Cc: Andrew Cooper , Wei Liu , Ian Jackson , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On Mon, 2015-07-20 at 15:30 +0100, Jan Beulich wrote: > htobe*() and be*toh() don't exist there. While replacing the 32-bit > ones with hton() and ntoh() would be possible, there wouldn't be an > obvious replacement for the 64-bit ones. Hence just take what current > glibc (2.21) has (assuming __bswap_*() exists, which it does back to > at least 2.4 according to my checking). > > Signed-off-by: Jan Beulich > --- > Not sure whether I picked an appropriate header to place this in, or > an appropriate #ifdef to hook this onto. Hence the RFC. I think they will do. I was a bit confused by xl.c including libxl_osdeps.h, but I think that is an aberration and we don't install the header so it is not really "public". Acked-by: Ian Campbell