From: Ian Campbell <ian.campbell@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
Xen-devel <xen-devel@lists.xen.org>
Cc: Wei Liu <wei.liu2@citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [PATCH 6/6] tools/libx{l, c}: Fix trivial Coverity defects in migration v2 code
Date: Wed, 22 Jul 2015 11:31:24 +0100 [thread overview]
Message-ID: <1437561084.12884.12.camel@citrix.com> (raw)
In-Reply-To: <1437388679-16468-7-git-send-email-andrew.cooper3@citrix.com>
On Mon, 2015-07-20 at 11:37 +0100, Andrew Cooper wrote:
> All of these are UNUSED_VALUE defects where a default vaule is
"value".
> unconditionally overwritten. They are not particularly interesting,
> bug wise, but keeping these defects at bay helps prevent real bugs
> going unnoticed in the volume.
The flip side is that if the code uses the "init everything and goto
out on error" idiom then the init might need to be put back if the code
changes, hopefully even a regular compiler would spot this though.
> No functional change.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Ian Campbell <Ian.Campbell@citrix.com>
next prev parent reply other threads:[~2015-07-22 10:31 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 10:37 [PATCH for 4.6 0/6] Prune legacy migration and move migration v2 out of daft status Andrew Cooper
2015-07-20 10:37 ` [PATCH 1/6] tools/libxc: Remove legacy migration implementation Andrew Cooper
2015-07-22 10:25 ` Ian Campbell
2015-07-22 11:05 ` Andrew Cooper
2015-07-20 10:37 ` [PATCH 2/6] tools/libx{l, c}: Remove the toolstack_{save, restore} callbacks Andrew Cooper
2015-07-22 10:27 ` Ian Campbell
2015-07-22 11:07 ` Andrew Cooper
2015-07-22 11:14 ` Ian Campbell
2015-07-28 10:09 ` Ian Campbell
2015-07-20 10:37 ` [PATCH 3/6] tools/libx{l, c}: Remove XC_DEVICE_MODEL_RESTORE_FILE Andrew Cooper
2015-07-22 10:28 ` Ian Campbell
2015-07-20 10:37 ` [PATCH 4/6] tools/libx{l, c}: Drop '2' suffixes from xc_domain_{save, restore}2() functions Andrew Cooper
2015-07-22 10:29 ` Ian Campbell
2015-07-20 10:37 ` [PATCH 5/6] docs: Migration v2 is now no longer draft Andrew Cooper
2015-07-22 10:29 ` Ian Campbell
2015-07-20 10:37 ` [PATCH 6/6] tools/libx{l, c}: Fix trivial Coverity defects in migration v2 code Andrew Cooper
2015-07-22 10:31 ` Ian Campbell [this message]
2015-07-22 10:33 ` [PATCH for 4.6 0/6] Prune legacy migration and move migration v2 out of daft status Ian Campbell
2015-07-22 11:22 ` Wei Liu
2015-07-22 11:26 ` Andrew Cooper
2015-07-22 11:30 ` Wei Liu
2015-07-22 11:57 ` Andrew Cooper
2015-07-22 12:20 ` Wei Liu
2015-07-22 12:47 ` Yang Hongyang
2015-07-28 10:42 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437561084.12884.12.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).