xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>, xen-devel@lists.xenproject.org
Cc: Tim Deegan <tim@xen.org>, Ian Jackson <ian.jackson@eu.citrix.com>,
	Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH v2 for-4.6 3/3] xen: remove non-POSIX error codes
Date: Wed, 22 Jul 2015 15:16:12 +0100	[thread overview]
Message-ID: <1437574572.19412.5.camel@citrix.com> (raw)
In-Reply-To: <1437563272-14168-4-git-send-email-roger.pau@citrix.com>

On Wed, 2015-07-22 at 13:07 +0200, Roger Pau Monne wrote:
> Xen was using some non-POSIX error codes that are removed in this 
> patch. For
> future reference, the list of POSIX error codes has been obtained 
> from:
> 
> http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/errno.h.html
> 
> The error codes already present and defined as optional (XSR), have 
> been
> left in place.

I think it would be worth adding a comment to the header including a
link to this and noting that although some optional (XSR) values are
present (having been grandfathered in) no _new_ ones should be added.

But that could be done in a followup, since Jan already acked this.

Ian.

  reply	other threads:[~2015-07-22 14:25 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-22 11:07 [PATCH v2 for-4.6 0/3] Get rid of non-POSIX error codes Roger Pau Monne
2015-07-22 11:07 ` [PATCH v2 for-4.6 1/3] xen/x86/libxl: replace non-POSIX error codes used by PSR code Roger Pau Monne
2015-07-22 12:40   ` Wei Liu
2015-07-22 11:07 ` [PATCH v2 for-4.6 2/3] xen: replace non-POSIX error codes Roger Pau Monne
2015-07-22 11:12   ` George Dunlap
2015-07-22 12:00   ` Jan Beulich
2015-07-22 11:07 ` [PATCH v2 for-4.6 3/3] xen: remove " Roger Pau Monne
2015-07-22 14:16   ` Ian Campbell [this message]
2015-07-22 14:55     ` Jan Beulich
2015-07-22 12:02 ` [PATCH v2 for-4.6 0/3] Get rid of " Jan Beulich
2015-07-22 12:26   ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1437574572.19412.5.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=jbeulich@suse.com \
    --cc=roger.pau@citrix.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).