From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: [PATCH for-4.6 03/13] xl/libxl: remove a bunch of pointless assignments Date: Thu, 23 Jul 2015 08:59:04 +0100 Message-ID: <1437638354-14216-4-git-send-email-wei.liu2@citrix.com> References: <1437638354-14216-1-git-send-email-wei.liu2@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZIBPW-0004wi-1C for xen-devel@lists.xenproject.org; Thu, 23 Jul 2015 07:59:22 +0000 In-Reply-To: <1437638354-14216-1-git-send-email-wei.liu2@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Xen-devel Cc: Wei Liu , Ian Jackson , Ian Campbell List-Id: xen-devel@lists.xenproject.org Those values are overwritten before they can be of any use. Signed-off-by: Wei Liu --- tools/libxl/libxl_dom.c | 2 +- tools/libxl/libxl_remus_disk_drbd.c | 2 +- tools/libxl/xl_cmdimpl.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c index edd7f3f..93ab8fe 100644 --- a/tools/libxl/libxl_dom.c +++ b/tools/libxl/libxl_dom.c @@ -1686,7 +1686,7 @@ void libxl__domain_save(libxl__egc *egc, libxl__domain_suspend_state *dss) { STATE_AO_GC(dss->ao); int port; - int rc = ERROR_FAIL; + int rc; /* Convenience aliases */ const uint32_t domid = dss->domid; diff --git a/tools/libxl/libxl_remus_disk_drbd.c b/tools/libxl/libxl_remus_disk_drbd.c index fc76b89..1c3a88a 100644 --- a/tools/libxl/libxl_remus_disk_drbd.c +++ b/tools/libxl/libxl_remus_disk_drbd.c @@ -47,7 +47,7 @@ static void drbd_async_call(libxl__egc *egc, void func(libxl__remus_device *), libxl__ev_child_callback callback) { - int pid = -1, rc; + int pid, rc; libxl__ao_device *aodev = &dev->aodev; STATE_AO_GC(dev->rds->ao); diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c index 5c6d1b0..5c74a73 100644 --- a/tools/libxl/xl_cmdimpl.c +++ b/tools/libxl/xl_cmdimpl.c @@ -4037,7 +4037,7 @@ static pid_t create_migration_child(const char *rune, int *send_fd, int *recv_fd) { int sendpipe[2], recvpipe[2]; - pid_t child = -1; + pid_t child; if (!rune || !send_fd || !recv_fd) return -1; @@ -7788,7 +7788,7 @@ int main_getenforce(int argc, char **argv) int main_setenforce(int argc, char **argv) { - int ret, mode = -1; + int ret, mode; const char *p = NULL; if (optind >= argc) { -- 1.9.1