From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v2] oxenstored: link in the systemd system library Date: Thu, 23 Jul 2015 15:00:13 +0100 Message-ID: <1437660013.24746.0.camel@citrix.com> References: <1437640914.19412.33.camel@citrix.com> <1437658839-10478-1-git-send-email-jonathan.creekmore@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZIH2q-00016G-5X for xen-devel@lists.xenproject.org; Thu, 23 Jul 2015 14:00:20 +0000 In-Reply-To: <1437658839-10478-1-git-send-email-jonathan.creekmore@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jonathan Creekmore , xen-devel@lists.xenproject.org Cc: dave.scott@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On Thu, 2015-07-23 at 08:40 -0500, Jonathan Creekmore wrote: > If systemd is configured for use AND you are building oxenstored, the > C > systemd library must be linked in to the systemd.cxma library. > > Signed-off-by: Jonathan Creekmore Acked-by: Ian Campbell OOI what was the failure mode for you without this? Runtime rather than build time I suspect? > --- > Changed since v1: > * Link the systemd library in to the systemd.cxma instead of the > final > binary. > --- > tools/ocaml/xenstored/Makefile | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tools/ocaml/xenstored/Makefile > b/tools/ocaml/xenstored/Makefile > index d861f11..59875f7 100644 > --- a/tools/ocaml/xenstored/Makefile > +++ b/tools/ocaml/xenstored/Makefile > @@ -30,6 +30,8 @@ systemd_OBJS = systemd > systemd_C_OBJS = systemd_stubs > OCAML_LIBRARY += systemd > > +LIBS_systemd += $(LDFLAGS-y) > + > OBJS = define \ > stdext \ > trie \