From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v2 01/20] xen: Add Xen specific page definition Date: Fri, 24 Jul 2015 11:43:40 +0100 Message-ID: <1437734620.24746.62.camel__7897.06504806436$1437734696$gmane$org@citrix.com> References: <1436474552-31789-1-git-send-email-julien.grall@citrix.com> <1436474552-31789-2-git-send-email-julien.grall@citrix.com> <55B20540.3020000@citrix.com> <55B207C6.4020300@citrix.com> <55B209D9.1080602@citrix.com> <55B20ABE.7000609@citrix.com> <55B214C5.3020501@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZIaSD-0006QD-Qs for xen-devel@lists.xenproject.org; Fri, 24 Jul 2015 10:43:49 +0000 In-Reply-To: <55B214C5.3020501@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: David Vrabel , Julien Grall , xen-devel@lists.xenproject.org Cc: Boris Ostrovsky , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On Fri, 2015-07-24 at 11:34 +0100, David Vrabel wrote: > it would be better to think that: > > PFNs index guest-sized pages (which may be 64 KiB). > > GFNs index Xen-sized pages (which is always 4 KiB). This concept could be usefully added to the comment in xen/include/xen/mm.h IMHO. > > David