From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH OSSTEST] ts-debian-install: Stop nbd-server before creating the guest Date: Fri, 24 Jul 2015 14:47:52 +0100 Message-ID: <1437745672.24746.103.camel@citrix.com> References: <1437742549-25453-1-git-send-email-ian.campbell@citrix.com> <21938.16394.92398.819950@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <21938.16394.92398.819950@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Fri, 2015-07-24 at 14:39 +0100, Ian Jackson wrote: > Ian Campbell writes ("[PATCH OSSTEST] ts-debian-install: Stop nbd-server > before creating the guest"): > > Like the umount this is useful when running the test/job repeatedly in > > development, since it allows the LV to be destroyed. > > This will cause trouble if the host is shared. This is not a bug > right now because the nbd server only runs in a job which is already > pretty heavy-handed. > > But, also, it seems rather action-at-a-distance. ts-debian-install > has no other knowledge of nbd. Yes, I wasn't sure where else it could go though. TBH, this was annoying while I was writing the new migration testcase, but now I'm done I can live without this. Ian.