From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v2] xenconsole: Ensure exclusive access to
 console using locks
Date: Fri, 24 Jul 2015 16:12:58 +0100
Message-ID: <1437750778.24746.121.camel@citrix.com>
References: <20150724134222.GF25338@nodbug.lucina.net>
	<1437749222-29918-1-git-send-email-martin@lucina.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=6401e7af6=Ian.Campbell@citrix.com>)
	id 1ZIeel-0006PY-GH
	for xen-devel@lists.xenproject.org; Fri, 24 Jul 2015 15:13:03 +0000
In-Reply-To: <1437749222-29918-1-git-send-email-martin@lucina.net>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Martin Lucina <martin@lucina.net>, xen-devel@lists.xenproject.org
Cc: Wei Liu <wei.liu2@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Fri, 2015-07-24 at 16:47 +0200, Martin Lucina wrote:
> If more than one instance of xenconsole is run against the same DOMID
> then each instance will only get some data. This change ensures
> exclusive access to the console by obtaining an exclusive lock on
> <XEN_LOCK_DIR>/xenconsole.<DOMID>.
> 
> The locking strategy used is based on
> tools/libxl/libxl_internal.c:libxl__lock_domain_userdata().

I'll let Ian deal with reviewing the locking but, only one small comment
from me:
> 
> diff --git a/tools/console/Makefile b/tools/console/Makefile
> index 71f8088..1ce5590 100644
> --- a/tools/console/Makefile
> +++ b/tools/console/Makefile

I forgot to mention adding the paths file to the clean rule too, sorry.