From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v2 0/15+5+5] Begin to disentangle libxenctrl
 and provide some stable libraries
Date: Mon, 27 Jul 2015 09:57:22 +0100
Message-ID: <1437987442.28924.24.camel@citrix.com>
References: <1436975173.32371.121.camel@citrix.com>
	<55A681EC.2050508@citrix.com> <1437563556.12884.32.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1437563556.12884.32.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>, xen-devel <xen-devel@lists.xen.org>
Cc: minios-devel@lists.xenproject.org, Wei Liu <wei.liu2@citrix.com>, Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Roger Pau Monne <roger.pau@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Wed, 2015-07-22 at 12:12 +0100, Ian Campbell wrote:
> On Wed, 2015-07-15 at 16:53 +0100, Andrew Cooper wrote:
> > 
> > > I'm stilling mulling over putting everything into tools/libs/FOO
> > > instead of tools/libxenFOO
> > 
> > On balance, +1.  tools/ is already quite a mixed bag of stuff.
> 
> OK, I think I'm going to go ahead with this.
> 
> > > , I still haven't but I could if people think
> > > it is worthwhile. Eventually I'd like to split libxc into 
> > > libxenguest
> > > and libxenctrl to cut down on the amount of strange cross talk...
> > 
> > Very much +1.
> 
> OK (eventually ;-))
> 
> > FWIW, also splitting xl and libxl into different directories.
> 
> Yes, good idea (also "eventually ;-)").
> 
> While I'm accumulating TODO items in this thread, every library which
> gets split out needs a careful review before it should be declared
> A[PBI] stable. I'm thinking at least:
> 
>       * Consistent error handling (return -1 + setting errno=EFOO)
>       * Correct types
>       * Const correctness
>       * General interface sanity check

Explicit unmap operation to match the foreign map, rather than just
using munmap (to allow valgrind hooks etc).

Ian.