From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v3] xenconsole: Ensure exclusive access to console using locks Date: Mon, 27 Jul 2015 16:14:26 +0100 Message-ID: <1438010066.11600.18.camel@citrix.com> References: <21938.21666.285588.16673@mariner.uk.xensource.com> <1437751781-30700-1-git-send-email-martin@lucina.net> <21938.24923.585157.992822@mariner.uk.xensource.com> <20150727124457.GA644@nodbug.lucina.net> <20150727132936.GD9031@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZJk6p-0006ge-JE for xen-devel@lists.xenproject.org; Mon, 27 Jul 2015 15:14:31 +0000 In-Reply-To: <20150727132936.GD9031@zion.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu , Martin Lucina , Ian Jackson , xen-devel@lists.xenproject.org, Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On Mon, 2015-07-27 at 14:29 +0100, Wei Liu wrote: > On Mon, Jul 27, 2015 at 02:44:57PM +0200, Martin Lucina wrote: > > On Friday, 24.07.2015 at 17:01, Ian Jackson wrote: > > > Martin Lucina writes ("[PATCH v3] xenconsole: Ensure exclusive access > > > to console using locks"): > > > > If more than one instance of xenconsole is run against the same > > > > DOMID > > > > then each instance will only get some data. This change ensures > > > > exclusive access to the console by obtaining an exclusive lock on > > > > /xenconsole.. > > > > > > Acked-by: Ian Jackson > > > > Can this also make it into the 4.6 release on the grounds of being a > > bugfix > > for xenconsole, or is this change too invasive? > > > > I would say this is a bugfix. The locking pattern and implementation are > well understood. The risk is minimal. > > Release-acked-by: Wei Liu Applied, thanks.