From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Julien Grall <julien@xen.org>,
Norbert Manthey <nmanthey@amazon.de>,
<xen-devel@lists.xenproject.org>
Cc: Ian Jackson <iwj@xenproject.org>, Juergen Gross <jgross@suse.com>,
Wei Liu <wl@xen.org>, Julien Grall <jgrall@amazon.co.uk>,
Michael Kurth <mku@amazon.de>
Subject: Re: [for-4.15] Re: [PATCH XENSTORE v1 00/10] Code analysis fixes
Date: Mon, 1 Mar 2021 19:39:37 +0000 [thread overview]
Message-ID: <144f2b06-d563-a699-8481-48b6787d502a@citrix.com> (raw)
In-Reply-To: <759336de-727b-db67-b082-709d5ee735f8@xen.org>
On 01/03/2021 18:01, Julien Grall wrote:
> Hi,
>
> I have tagged the e-mail with 4.15 as I think we likely want some of
> the patches to be in the next release.
>
> As a minimum, we get the following:
> - patch #7: xenstore: handle do_mkdir and do_rm failure
> - patch #8: xenstore: add missing NULL check
> - patch #10: xs: add error handling
>
> The first two add missing NULL check in runtime code in XenStored. The
> 3rd one adds a missing NULL check in xs_is_domain_introduced() in
> libxenstore (can be used at runtime by xenpaging at least).
>
> In addition to that, I would like to consider patch #3: xenstore:
> check formats of trace. It is allowing the compiler to check the
> format printf for trace(). This should be low-risk.
>
> For the rest is a mix of silencing coverity and potential errors
> either at init or in a standalone binaries.
>
> The init ones would be useful (patch #1, #5, #9) for Xenstored
> LiveUpdate as they would be potential triggered when upgrading the
> binary. But I am not sure whether we consider LiveUpdate supported.
>
> Any thoughts?
Live Update is a headline feature, even if only tech preview.
I'd say that all bugfixes are fair game, and low risk. All these fixes
(other than the evtchn one which has an outstanding question) look to be
reasonable to take. They're all simple and obvious fixes pointed out by
static analysis.
~Andrew
next prev parent reply other threads:[~2021-03-01 19:40 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-26 14:41 [PATCH XENSTORE v1 00/10] Code analysis fixes Norbert Manthey
2021-02-26 14:41 ` [PATCH XENSTORE v1 01/10] xenstore: add missing NULL check Norbert Manthey
2021-03-02 5:07 ` Jürgen Groß
2021-03-03 16:07 ` Ian Jackson
2021-02-26 14:41 ` [PATCH XENSTORE v1 02/10] xenstore: fix print format string Norbert Manthey
2021-03-02 5:07 ` Jürgen Groß
2021-03-03 16:08 ` Ian Jackson
2021-02-26 14:41 ` [PATCH XENSTORE v1 03/10] xenstore: check formats of trace Norbert Manthey
2021-03-02 5:08 ` Jürgen Groß
2021-03-03 16:08 ` Ian Jackson
2021-02-26 14:41 ` [PATCH XENSTORE v1 04/10] xenstore_client: handle memory on error Norbert Manthey
2021-03-02 5:08 ` Jürgen Groß
2021-03-03 16:10 ` Ian Jackson
2021-02-26 14:41 ` [PATCH XENSTORE v1 05/10] xenstore: handle daemon creation errors Norbert Manthey
2021-03-02 5:08 ` Jürgen Groß
2021-03-03 16:10 ` Ian Jackson
2021-02-26 14:41 ` [PATCH XENSTORE v1 06/10] xenstored: handle port reads correctly Norbert Manthey
2021-02-26 15:36 ` Andrew Cooper
2021-03-02 5:15 ` Jürgen Groß
2021-03-02 7:48 ` Norbert Manthey
2021-03-02 8:12 ` Jürgen Groß
2021-02-26 14:41 ` [PATCH XENSTORE v1 07/10] xenstore: handle do_mkdir and do_rm failure Norbert Manthey
2021-03-02 5:09 ` Jürgen Groß
2021-03-03 16:11 ` Ian Jackson
2021-02-26 14:41 ` [PATCH XENSTORE v1 08/10] xenstore: add missing NULL check Norbert Manthey
2021-03-02 5:10 ` Jürgen Groß
2021-03-03 16:11 ` Ian Jackson
2021-02-26 14:41 ` [PATCH XENSTORE v1 09/10] xs: handle daemon socket error Norbert Manthey
2021-03-02 5:10 ` Jürgen Groß
2021-03-03 16:13 ` Ian Jackson
2021-03-04 14:58 ` Norbert Manthey
2021-03-04 15:04 ` Ian Jackson
2021-02-26 14:41 ` [PATCH XENSTORE v1 10/10] xs: add error handling Norbert Manthey
2021-02-26 14:53 ` Julien Grall
2021-02-26 15:26 ` Norbert Manthey
2021-03-02 5:11 ` Jürgen Groß
2021-03-03 16:13 ` Ian Jackson
2021-03-01 18:01 ` [for-4.15] Re: [PATCH XENSTORE v1 00/10] Code analysis fixes Julien Grall
2021-03-01 19:39 ` Andrew Cooper [this message]
2021-03-02 10:04 ` Julien Grall
2021-03-03 18:45 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=144f2b06-d563-a699-8481-48b6787d502a@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=iwj@xenproject.org \
--cc=jgrall@amazon.co.uk \
--cc=jgross@suse.com \
--cc=julien@xen.org \
--cc=mku@amazon.de \
--cc=nmanthey@amazon.de \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).