From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH v4 5/5] xl: Return error codes for pci*
 commands
Date: Mon, 21 Dec 2015 11:51:37 +0100
Message-ID: <1450695097.19320.147.camel@citrix.com>
References: <1450441425-10755-1-git-send-email-george.dunlap@eu.citrix.com>
	<1450441425-10755-6-git-send-email-george.dunlap@eu.citrix.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6404645357967629345=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1450441425-10755-6-git-send-email-george.dunlap@eu.citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: George Dunlap <george.dunlap@eu.citrix.com>, xen-devel@lists.xen.org
Cc: Ian Jackson <ian.jackson@citrix.com>, Wei Liu <wei.liu2@citrix.com>, Ian Campbell <ian.campbell@citrix.com>
List-Id: xen-devel@lists.xenproject.org

--===============6404645357967629345==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-3nAfQ9tKiQrXCF3qJ3z5"

--=-3nAfQ9tKiQrXCF3qJ3z5
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, 2015-12-18 at 12:23 +0000, George Dunlap wrote:
> Add return codes for pci-detach, pci-attach, pci-asssignable-add, and
> pci-assignable-remove.
>=20
> Returning error codes makes it easier for shell scripts to tell if a
> command has failed or succeeded.
>=20
> NB this violates the CODING_STYLE preference for not initializing the
> return-value variable at declaration; but in these cases, having a
> "goto out" that jumped over nothing but an "rc =3D EXIT_SUCCESS" seemed
> a bit pointless.
>
You mean 'nothing but an "r =3D EXIT_SUCCESS"'... Or this changelog
violates the CODING_STYLE itself! =C2=A0;-P ;-P

> Signed-off-by: George Dunlap <george.dunlap@eu.citrix.com>
>
Reviewed-by: Dario Faggioli <dario.faggioli@citrix.com>

Dario
--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-3nAfQ9tKiQrXCF3qJ3z5
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEABECAAYFAlZ32bkACgkQk4XaBE3IOsTrwwCfRj9GeZuxkjOUk3OzgRCW2Qn1
6SAAoI9NEC2BR/nMCw3WaAlTjQLcRUGP
=0KS7
-----END PGP SIGNATURE-----

--=-3nAfQ9tKiQrXCF3qJ3z5--


--===============6404645357967629345==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============6404645357967629345==--