From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH v4 4/5] xl: Return an error on failed
 cd-insert
Date: Mon, 21 Dec 2015 11:52:10 +0100
Message-ID: <1450695130.19320.148.camel@citrix.com>
References: <1450441425-10755-1-git-send-email-george.dunlap@eu.citrix.com>
	<1450441425-10755-5-git-send-email-george.dunlap@eu.citrix.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4701775914904985253=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1450441425-10755-5-git-send-email-george.dunlap@eu.citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: George Dunlap <george.dunlap@eu.citrix.com>, xen-devel@lists.xen.org
Cc: Ian Jackson <ian.jackson@citrix.com>, Wei Liu <wei.liu2@citrix.com>, Ian Campbell <ian.campbell@citrix.com>
List-Id: xen-devel@lists.xenproject.org

--===============4701775914904985253==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-Jw7i7K7HQQbXJ3VzteeQ"

--=-Jw7i7K7HQQbXJ3VzteeQ
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, 2015-12-18 at 12:23 +0000, George Dunlap wrote:
> This makes xl more useful in scripts.
>=20
> The strange thing about this is that the internal cd_insert function
> *already* returned something appropriate, and cd-eject was using it,
> but cd-insert wasn't.
>=20
> Also:
>=20
> * Rework cd_insert to return EXIT_FAILURE and EXIT_SUCCESS rather
> than
> magic constants
>=20
> * Use 'r' for non-libxl return code, as specified in CODING_STYLE
>=20
> Signed-off-by: George Dunlap <george.dunlap@eu.citrix.com>
>
Reviewed-by: Dario Faggioli <dario.faggioli@citrix.com>

Dario
--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-Jw7i7K7HQQbXJ3VzteeQ
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEABECAAYFAlZ32doACgkQk4XaBE3IOsQ+GwCaAkPyUWnNF+VeXEU8+huAhq9q
d5sAnRJhIMKFUIA8z1U6GL4mvKY/6Asu
=oLAw
-----END PGP SIGNATURE-----

--=-Jw7i7K7HQQbXJ3VzteeQ--


--===============4701775914904985253==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============4701775914904985253==--