From: Shuai Ruan <shuai.ruan@linux.intel.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: andrew.cooper3@citrix.com, keir@xen.org, xen-devel@lists.xen.org
Subject: Re: [V5] x86/xsaves: fix overwriting between non-lazy/lazy xsaves
Date: Wed, 23 Mar 2016 19:01:15 +0800 [thread overview]
Message-ID: <14513.9344073415$1458731112@news.gmane.org> (raw)
In-Reply-To: <56F27C3C02000078000DF90A@prv-mh.provo.novell.com>
On Wed, Mar 23, 2016 at 04:21:32AM -0600, Jan Beulich wrote:
> >>> On 23.03.16 at 07:14, <shuai.ruan@linux.intel.com> wrote:
> > But for hvm_vcpu_reset_state(), I think we should deleting the code
> > initializing the xcomp_bv as said below.
> >> For hvm_vcpu_reset_state(), we should depend on whether xsaves is used
> >> to decide whether to init xcomp_bv or not. And currently we use
> >> xcr0_accum to indicate the use of xsaves, when hvm_vcpu_reset_state()
> >> is called , can vcpu->xcr0_accum indicate using of xsaves ?
> >> I think in hvm_vcpu_reset_state(), we should leave xcomp_bv zero.
>
> Leaving it to be zero would be fine, but is it guaranteed to be
> zero?
Oh, yeah, I will add v->arch.xsave_area->xsave_hdr.xcomp_bv = 0 in
hvm_vcpu_reset_state() to guarante that.
> > A now wapper is intruduced as "_XRSTOR"( maybe the macro name is not
> > good ).
>
> Indeed an underscore followed by an uppercase letter is starting
> a reserved identifier. Maybe DO_XRSTOR() or _xrstor()?
>
Really thanks for your suggestion. I will use _xrstor().
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-03-23 11:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-18 3:01 [V5] x86/xsaves: fix overwriting between non-lazy/lazy xsaves Shuai Ruan
2016-03-22 14:34 ` Jan Beulich
2016-03-23 2:02 ` Shuai Ruan
[not found] ` <20160323020224.GB4131@shuai.ruan@linux.intel.com>
2016-03-23 6:14 ` Shuai Ruan
[not found] ` <20160323061455.GA12388@shuai.ruan@linux.intel.com>
2016-03-23 10:21 ` Jan Beulich
2016-03-23 11:01 ` Shuai Ruan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='14513.9344073415$1458731112@news.gmane.org' \
--to=shuai.ruan@linux.intel.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).