From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: ian.campbell@citrix.com, ian.jackson@eu.citrix.com,
jbeulich@suse.com, xen-devel@lists.xenproject.org
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: [PATCH v3 5/5] mkelf32: Close those file descriptors in the error paths.
Date: Thu, 11 Feb 2016 22:08:27 -0500 [thread overview]
Message-ID: <1455246507-5589-6-git-send-email-konrad.wilk@oracle.com> (raw)
In-Reply-To: <1455246507-5589-1-git-send-email-konrad.wilk@oracle.com>
While we are operating here we may as well fix some of the
file descriptor leaks.
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
xen/arch/x86/boot/mkelf32.c | 28 ++++++++++++++++------------
1 file changed, 16 insertions(+), 12 deletions(-)
diff --git a/xen/arch/x86/boot/mkelf32.c b/xen/arch/x86/boot/mkelf32.c
index 993a7ee..890ae6d 100644
--- a/xen/arch/x86/boot/mkelf32.c
+++ b/xen/arch/x86/boot/mkelf32.c
@@ -230,9 +230,9 @@ int main(int argc, char **argv)
u64 final_exec_addr;
u32 loadbase, dat_siz, mem_siz;
char *inimage, *outimage;
- int infd, outfd;
+ int infd, outfd = -1;
char buffer[1024];
- int bytes, todo, i;
+ int bytes, todo, i, rc = 1;
Elf32_Ehdr in32_ehdr;
@@ -256,7 +256,7 @@ int main(int argc, char **argv)
{
fprintf(stderr, "Failed to open input image '%s': %d (%s).\n",
inimage, errno, strerror(errno));
- return 1;
+ goto out;
}
do_read(infd, &in32_ehdr, sizeof(in32_ehdr));
@@ -264,7 +264,7 @@ int main(int argc, char **argv)
(in32_ehdr.e_ident[EI_DATA] != ELFDATA2LSB) )
{
fprintf(stderr, "Input image must be a little-endian Elf image.\n");
- return 1;
+ goto out;
}
big_endian = (*(u16 *)in32_ehdr.e_ident == ((ELFMAG0 << 8) | ELFMAG1));
@@ -273,7 +273,7 @@ int main(int argc, char **argv)
if ( in32_ehdr.e_ident[EI_CLASS] != ELFCLASS64 )
{
fprintf(stderr, "Bad program header class - we only do 64-bit!.\n");
- return 1;
+ goto out;
}
(void)lseek(infd, 0, SEEK_SET);
do_read(infd, &in64_ehdr, sizeof(in64_ehdr));
@@ -283,14 +283,14 @@ int main(int argc, char **argv)
{
fprintf(stderr, "Bad program header size (%d != %d).\n",
(int)in64_ehdr.e_phentsize, (int)sizeof(in64_phdr));
- return 1;
+ goto out;
}
if ( in64_ehdr.e_phnum != 1 )
{
fprintf(stderr, "Expect precisly 1 program header; found %d.\n",
(int)in64_ehdr.e_phnum);
- return 1;
+ goto out;
}
(void)lseek(infd, in64_ehdr.e_phoff, SEEK_SET);
@@ -327,7 +327,7 @@ int main(int argc, char **argv)
{
fprintf(stderr, "Failed to open output image '%s': %d (%s).\n",
outimage, errno, strerror(errno));
- return 1;
+ goto out;
}
endianadjust_ehdr32(&out_ehdr);
@@ -339,7 +339,7 @@ int main(int argc, char **argv)
if ( (bytes = RAW_OFFSET - sizeof(out_ehdr) - sizeof(out_phdr)) < 0 )
{
fprintf(stderr, "Header overflow.\n");
- return 1;
+ goto out;
}
do_write(outfd, buffer, bytes);
@@ -358,10 +358,14 @@ int main(int argc, char **argv)
do_write(outfd, out_shstrtab, sizeof(out_shstrtab));
do_write(outfd, buffer, 4-((sizeof(out_shstrtab)+dat_siz)&3));
- close(infd);
- close(outfd);
+ rc = 0;
+out:
+ if ( infd != -1 )
+ close(infd);
+ if ( outfd != -1 )
+ close(outfd);
- return 0;
+ return rc;
}
/*
--
2.4.3
next prev parent reply other threads:[~2016-02-12 3:08 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-12 3:08 [PATCH v3] Requisite paches for xSplice v3 (not yet posted) Konrad Rzeszutek Wilk
2016-02-12 3:08 ` [PATCH v3 1/5] hypervisor/arm/keyhandler: Declare struct cpu_user_regs; Konrad Rzeszutek Wilk
2016-02-12 8:51 ` Jan Beulich
2016-02-12 14:06 ` Konrad Rzeszutek Wilk
2016-02-12 14:54 ` Jan Beulich
2016-02-12 11:37 ` Stefano Stabellini
2016-02-12 12:20 ` Jan Beulich
2016-02-12 12:46 ` Stefano Stabellini
2016-02-12 14:53 ` Jan Beulich
2016-02-12 3:08 ` [PATCH v3 2/5] arm/config: Declare ELFSIZE_[32|64] respectively Konrad Rzeszutek Wilk
2016-02-12 11:26 ` Stefano Stabellini
2016-02-12 14:17 ` Konrad Rzeszutek Wilk
2016-02-12 15:04 ` Jan Beulich
2016-02-12 15:26 ` Stefano Stabellini
2016-02-12 15:56 ` Konrad Rzeszutek Wilk
2016-02-12 15:57 ` Stefano Stabellini
2016-02-12 17:50 ` Konrad Rzeszutek Wilk
2016-03-16 17:32 ` Julien Grall
2016-03-16 17:52 ` Konrad Rzeszutek Wilk
2016-03-16 18:08 ` Julien Grall
2016-03-16 19:21 ` Konrad Rzeszutek Wilk
2016-03-17 1:16 ` Konrad Rzeszutek Wilk
2016-03-17 11:04 ` Julien Grall
2016-03-17 18:52 ` Konrad Rzeszutek Wilk
2016-02-12 3:08 ` [PATCH v3 3/5] build: remove .config from /boot when uninstalling Konrad Rzeszutek Wilk
2016-02-12 14:11 ` Doug Goldstein
2016-02-12 3:08 ` [PATCH v3 4/5] mkelf32: Remove the 32-bit hypervisor support Konrad Rzeszutek Wilk
2016-02-12 3:08 ` Konrad Rzeszutek Wilk [this message]
2016-02-18 16:29 ` [PATCH v3 5/5] mkelf32: Close those file descriptors in the error paths Jan Beulich
2016-02-18 16:39 ` Ian Jackson
2016-02-18 16:45 ` Jan Beulich
2016-02-18 21:12 ` Konrad Rzeszutek Wilk
2016-02-19 11:39 ` Jan Beulich
2016-02-19 11:42 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455246507-5589-6-git-send-email-konrad.wilk@oracle.com \
--to=konrad.wilk@oracle.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).