From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: New Defects reported by Coverity Scan for XenProject Date: Thu, 25 Feb 2016 10:00:31 +0000 Message-ID: <1456394431.6225.182.camel@citrix.com> References: <56ce8ad13abd2_bd9abd33094410@ss1435.mail> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <56ce8ad13abd2_bd9abd33094410@ss1435.mail> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: George Dunlap , Harmandeep Kaur Cc: Ian Jackson , Andrew Cooper , Wei Liu , xen-devel List-Id: xen-devel@lists.xenproject.org Ck9uIFdlZCwgMjAxNi0wMi0yNCBhdCAyMTowMiAtMDgwMCwgc2Nhbi1hZG1pbkBjb3Zlcml0eS5j b20gd3JvdGU6Cj4gSGksCj4gCj4gUGxlYXNlIGZpbmQgdGhlIGxhdGVzdCByZXBvcnQgb24gbmV3 IGRlZmVjdChzKSBpbnRyb2R1Y2VkIHRvIFhlblByb2plY3QgZm91bmQgd2l0aCBDb3Zlcml0eSBT Y2FuLgo+IAo+IDIgbmV3IGRlZmVjdChzKSBpbnRyb2R1Y2VkIHRvIFhlblByb2plY3QgZm91bmQg d2l0aCBDb3Zlcml0eSBTY2FuLgo+IDEyIGRlZmVjdChzKSwgcmVwb3J0ZWQgYnkgQ292ZXJpdHkg U2NhbiBlYXJsaWVyLCB3ZXJlIG1hcmtlZCBmaXhlZCBpbiB0aGUgcmVjZW50IGJ1aWxkIGFuYWx5 emVkIGJ5IENvdmVyaXR5IFNjYW4uCj4gCj4gTmV3IGRlZmVjdChzKSBSZXBvcnRlZC1ieTogQ292 ZXJpdHkgU2Nhbgo+IFNob3dpbmcgMiBvZiAyIGRlZmVjdChzKQo+IAo+IAo+ICoqIENJRCAxMzU0 MjQ0OsKgwqBOdWxsIHBvaW50ZXIgZGVyZWZlcmVuY2VzwqDCoChGT1JXQVJEX05VTEwpCj4gL3Rv b2xzL2xpYnhjL3hjX3RidWYuYzogNzIgaW4geGNfdGJ1Zl9nZXRfc2l6ZSgpCj4gCj4gCj4gX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiAqKiogQ0lEIDEz NTQyNDQ6wqDCoE51bGwgcG9pbnRlciBkZXJlZmVyZW5jZXPCoMKgKEZPUldBUkRfTlVMTCkKPiAv dG9vbHMvbGlieGMveGNfdGJ1Zi5jOiA3MiBpbiB4Y190YnVmX2dldF9zaXplKCkKPiA2NsKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgcmV0dXJuIHJjOwo+IDY3wqDCoMKgwqDCoAo+IDY4wqDCoMKg wqDCoMKgwqDCoMKgdF9pbmZvID0geGNfbWFwX2ZvcmVpZ25fcmFuZ2UoeGNoLCBET01JRF9YRU4s Cj4gNjnCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoHN5 c2N0bC51LnRidWZfb3Auc2l6ZSwgUFJPVF9SRUFEIHwgUFJPVF9XUklURSwKPiA3MMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgc3lzY3RsLnUudGJ1Zl9v cC5idWZmZXJfbWZuKTsKPiA3McKgwqDCoMKgwqAKPiA+ID4gPiDCoMKgwqDCoENJRCAxMzU0MjQ0 OsKgwqBOdWxsIHBvaW50ZXIgZGVyZWZlcmVuY2VzwqDCoChGT1JXQVJEX05VTEwpCj4gPiA+ID4g wqDCoMKgwqBDb21wYXJpbmcgInRfaW5mbyIgdG8gbnVsbCBpbXBsaWVzIHRoYXQgInRfaW5mbyIg bWlnaHQgYmUgbnVsbC4KPiA3MsKgwqDCoMKgwqDCoMKgwqDCoGlmICggdF9pbmZvID09IE5VTEwg fHwgdF9pbmZvLT50YnVmX3NpemUgPT0gMCApCj4gNzPCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oHJjID0gLTE7Cj4gNzTCoMKgwqDCoMKgwqDCoMKgwqBlbHNlCj4gNzXCoMKgwqDCoMKgCSpzaXpl ID0gdF9pbmZvLT50YnVmX3NpemU7Cj4gNzbCoMKgwqDCoMKgCj4gNzfCoMKgwqDCoMKgwqDCoMKg wqB4ZW5mb3JlaWdubWVtb3J5X3VubWFwKHhjaC0+Zm1lbSwgdF9pbmZvLCBzeXNjdGwudS50YnVm X29wLnNpemUpOwoKVGhpcyBpcyBjb21wbGFpbmluZyBhYm91dCB0aGUgZXZlbnR1YWwgbXVubWFw KHRfaW5mbykgPT4gbXVubWFwKE5VTEwpIHdoaWNoCmlzIGJlaGluZCB4ZW5mb3JlaWdubWVtb3J5 X3VubWFwKCkuCgpMb29rcyBsaWtlIGl0IHdhcyBuZXdseSBhZGRlZCBieSB0aGUgZml4IHRvIENJ RCAxMzUxMjI4IGluIDdjNDc5ODgzYjA0YQooImxpYnhjOiBmaXggbGVhayBvZiB0X2luZm8gaW4g eGNfdGJ1Zl9nZXRfc2l6ZSgpIikuCnhlbmZvcmVpZ25tZW1vcnlfdW5tYXAoKSBzaG91bGQgYmVo YXZlIGxpa2UgbXVubWFwIFdSVCB0b2xsZXJhbmNlIG9mIE5VTEwsCkknbSBub3QgMTAwJSBzdXJl IHdoYXQgdGhhdCBiZWhhdmlvdXIgaXMgc2luY2UgMCBpcyBhIHZhbGlkIGFkZHJlc3MuCnhlbmZv cmVpZ25tZW1vcnkuaCBubyBkb3VidCB3YW50cyB1cGRhdGluZyB3aXRoIHRoZSBkZXNpcmVkIHNl bWFudGljcyBhbmQKZWl0aGVyIHRoaXMgY29kZSBvZiB0aGUgaW1wbGVtZW50YXRpb24gYWRqdXN0 aW5nIHRvIG1hdGNoLgoKV2hpbGUgaGVyZSBJIG5vdGljZSB0aGF0IHVzaW5nIHhjX21hcF8qKCkg dG8gY3JlYXRlIHRoZSBtYXBwaW5nIGFuZAp4ZW5mb3JlaWdubWVtb3J5X3VubWFwKCkgdG8gZGVz dHJveSBpdCBpcyBhIGJpdCBvZGQgc2luY2UgdGhleSBhcmUgc3RyaWN0bHkKdHdvIHNlcGFyYXRl IEFQSXMsIGV2ZW4gaWYgb25lIGhhcHBlbnMgdG8gYmUgaW1wbGVtZW50ZWQgaW4gdGVybXMgb2Yg dGhlCm90aGVyLiBCZWluZyBsaWJ4YyBpbnRlcm5hbCB0aGlzIGNvZGUgaXMgYXQgbGliZXJ0eSB0 byB1c2UgeGNfbWFwXyogYnV0CnNob3VsZCB0aGVuIHVzZSBwbGFpbiBtdW5tYXAgdG8gdW5kbyBp dCwgb3IgaXQgd291bGQgYWxzbyBiZSByZWFzb25hYmxlIHRvCnBvcnQgdGhpcyBjb2RlIGZ1bGx5 IHRvIHRoZSB4ZW5mb3JlaWdubWVtb3J5IGludGVyZmFjZS4KCj4gCj4gKiogQ0lEIDEzNTQyNDM6 wqDCoENvbnRyb2wgZmxvdyBpc3N1ZXPCoMKgKERFQURDT0RFKQo+IC90b29scy94ZW50cmFjZS94 ZW5hbHl6ZS5jOiA0MTQ4IGluIGNyM19kdW1wX2xpc3QoKQo+IAo+IAo+IF9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gKioqIENJRCAxMzU0MjQzOsKgwqBD b250cm9sIGZsb3cgaXNzdWVzwqDCoChERUFEQ09ERSkKPiAvdG9vbHMveGVudHJhY2UveGVuYWx5 emUuYzogNDE0OCBpbiBjcjNfZHVtcF9saXN0KCkKPiA0MTQywqDCoMKgwqDCoAo+IDQxNDPCoMKg wqDCoMKgwqDCoMKgwqAvKiBDb3VudCB0aGUgbnVtYmVyIG9mIGVsZW1lbnRzICovCj4gNDE0NMKg wqDCoMKgwqDCoMKgwqDCoGZvcihwPWhlYWQ7IHA7IHA9cC0+bmV4dCkKPiA0MTQ1wqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqBOKys7Cj4gNDE0NsKgwqDCoMKgwqAKPiA0MTQ3wqDCoMKgwqDCoMKg wqDCoMKgaWYoIU4pCj4gPiA+ID4gwqDCoMKgwqBDSUQgMTM1NDI0MzrCoMKgQ29udHJvbCBmbG93 IGlzc3Vlc8KgwqAoREVBRENPREUpCj4gPiA+ID4gwqDCoMKgwqBFeGVjdXRpb24gY2Fubm90IHJl YWNoIHRoaXMgc3RhdGVtZW50OiAicmV0dXJuOyIuCgpIZXJlIGl0IGhhcyBvYnNlcnZlZCB0aGF0 IGR1ZSB0byB0aGUgKGFib3ZlLCBqdXN0IG91dCBvZiB0aGUgY29udGV4dCBnaXZlbgpoZXJlKSAi aWYgKCFoZWFkKSByZXR1cm4iIHRoYXQgdGhlIGZvciBsb29wIG11c3QgcnVuIGF0IGxlYXN0IG9u Y2UsIHNvIE4KY2Fubm90IGJlIDAuCgpNeSBndWVzcyBpcyB0aGF0IHRoaXMgaXMgYSBwcmV4aXN0 aW5nIGlzc3VlIHdoaWNoIHdhcyBleHBvc2VkIHRvIGNvdmVyaXRpZXMKYmVhZHkgZXllIHNvbWVo b3cgYnkgMjhhYjlmM2QwZTdjICgidG9vbHMveGVuYWx5emU6IEZpeCBidWlsZCB3aXRoIGNsYW5n IikuCk9yIG1heWJlIHRoaXMgd2FzIHByZXZpb3VzIG1hcmtlZCBkZWxpYmVyYXRlIGJ1dCB0aGUg Y2hhbmdlIGhhcyBjYXVzZWQKY292ZXJpdHkgdG8gdGhpbmsgdGhpcyBpcyBhIGRpZmZlcmVudCBp bnN0YW5jZSBvZiB0aGUgc2FtZSB0aGluZywgZWl0aGVyd2F5CkkgZG9uJ3QgdGhpbmsgdGhlIGlz c3VlIGl0c2VsZiBpcyBuZXcuCgpGV0lXIGhhdmluZyBib3RoIGlmICghaGVhZCkgcmV0dXJuIGFu ZCBpZiAoIU4pIHJldHVybiBsb29rcyByZWR1bmRhbnQgdG8KbWUsIHRoZSBvdGhlciB0d28gc2lt aWxhciBsb29raW5nIGluc3RhbmNlcyAoZnJvbSBncmVwcGluZyBmb3IgTisrKSBoYXZlCm9ubHkg dGhlIGxhdHRlciBjaGVjay4KCklhbi4KCj4gNDE0OMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg cmV0dXJuOwo+IDQxNDnCoMKgwqDCoMKgCj4gNDE1MMKgwqDCoMKgwqDCoMKgwqDCoC8qIEFsbG9j IGEgc3RydWN0IG9mIHRoZSByaWdodCBzaXplICovCj4gNDE1McKgwqDCoMKgwqDCoMKgwqDCoHFz b3J0X2FycmF5ID0gbWFsbG9jKE4gKiBzaXplb2Yoc3RydWN0IGVpcF9saXN0X3N0cnVjdCAqKSk7 Cj4gNDE1MsKgwqDCoMKgwqAKPiA0MTUzwqDCoMKgwqDCoMKgwqDCoMKgLyogUG9pbnQgdGhlIGFy cmF5IGludG8gaXQgKi8KPiAKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwo+IFRvIHZpZXcgdGhlIGRlZmVjdHMgaW4gQ292ZXJpdHkgU2NhbiB2aXNp dCwgaHR0cHM6Ly9zY2FuLmNvdmVyaXR5LmNvbS9wcm9qZWN0cy94ZW5wcm9qZWN0P3RhYj1vdmVy dmlldwo+IAo+IFRvIG1hbmFnZSBDb3Zlcml0eSBTY2FuIGVtYWlsIG5vdGlmaWNhdGlvbnMgZm9y ICJpYW4uY2FtcGJlbGxAY2l0cml4LmNvbSIsIGNsaWNrIGh0dHBzOi8vc2Nhbi5jb3Zlcml0eS5j b20vc3Vic2NyaXB0aW9ucy9lZGl0P2VtYWlsPWlhbi5jYW1wYmVsbCU0MGNpdHJpeC5jb20mdG9r ZW49ODZlZWNmOWE3MGEzMmQ4ZWY2YWM0MWU0YzdjZGFmNTgKPiAKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVu LWRldmVsQGxpc3RzLnhlbi5vcmcKaHR0cDovL2xpc3RzLnhlbi5vcmcveGVuLWRldmVsCg==