From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v2 3/3] xl: new "loglvl" command Date: Sat, 5 Mar 2016 16:36:58 +0100 Message-ID: <1457192218.2959.598.camel@citrix.com> References: <56D9C80702000078000D9910@prv-mh.provo.novell.com> <56D9CA6002000078000D9935@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1635608172110921564==" Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.84) (envelope-from ) id 1acEGV-0002jE-JW for xen-devel@lists.xenproject.org; Sat, 05 Mar 2016 15:37:11 +0000 In-Reply-To: <56D9CA6002000078000D9935@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Jan Beulich , xen-devel Cc: Wei Liu , Ian Jackson , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org --===============1635608172110921564== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-JRYi0utrN4hpVk2nPiMF" --=-JRYi0utrN4hpVk2nPiMF Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2016-03-04 at 09:48 -0700, Jan Beulich wrote: > This is pretty simplistic for now, but I'd rather have someone better > friends with the tools improve it (if desired). >=20 > Signed-off-by: Jan Beulich >=20 > --- a/tools/libxl/libxl.c > +++ b/tools/libxl/libxl.c > @@ -5958,6 +5958,26 @@ int libxl_send_debug_keys(libxl_ctx *ctx > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0return 0; > =C2=A0} > =C2=A0 > +int libxl_log_level(libxl_ctx *ctx, bool set, bool guest, > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0int *lower_thresh, int *upp= er_thresh) > Another thing I feel like saying is that having two actual functions, one for _get and one for _set (perhaps implemented just as wrappers around this one, which then would become an internal function) is, from my point of view, a better interface, e.g., it is more in line with how things are in libxl. But this, I know, is mostly personal taste, and it's the taste of the tools maintainers that counts. :-) Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-JRYi0utrN4hpVk2nPiMF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlba/RsACgkQk4XaBE3IOsRusgCgqtpWwiWeLdgx7+t5uYgWzqe/ 98oAn0sW0yqXTzVbMyco9V1/DBCQWU8T =A/xu -----END PGP SIGNATURE----- --=-JRYi0utrN4hpVk2nPiMF-- --===============1635608172110921564== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y Zy94ZW4tZGV2ZWwK --===============1635608172110921564==--