From: Doug Goldstein <cardoe@cardoe.com>
To: xen-devel@lists.xen.org
Cc: Ian Jackson <ian.jackson@eu.citrix.com>,
Doug Goldstein <cardoe@cardoe.com>, Wei Liu <wei.liu2@citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: [PATCH 1/2] libxl: ensure var is inited in libxl__domain_firmware
Date: Mon, 7 Mar 2016 20:23:39 -0600 [thread overview]
Message-ID: <1457403820-2949-1-git-send-email-cardoe@cardoe.com> (raw)
Some versions of GCC complain that the 'firmware' variable can be used
uninitialized. It looks like the switch inside of the else case is just
confusing GCC.
Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
---
CC: Ian Jackson <ian.jackson@eu.citrix.com>
CC: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
CC: Wei Liu <wei.liu2@citrix.com>
---
tools/libxl/libxl_dom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c
index 664adad..b825b98 100644
--- a/tools/libxl/libxl_dom.c
+++ b/tools/libxl/libxl_dom.c
@@ -867,7 +867,7 @@ static int libxl__domain_firmware(libxl__gc *gc,
struct xc_dom_image *dom)
{
libxl_ctx *ctx = libxl__gc_owner(gc);
- const char *firmware;
+ const char *firmware = NULL;
int e, rc;
int datalen = 0;
void *data;
--
2.4.10
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next reply other threads:[~2016-03-08 2:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-08 2:23 Doug Goldstein [this message]
2016-03-08 2:23 ` [PATCH 2/2] tools: detect appropriate debug optimization level Doug Goldstein
2016-03-08 15:38 ` Wei Liu
2016-03-08 16:34 ` Doug Goldstein
2016-03-08 16:50 ` Wei Liu
2016-03-16 19:14 ` Doug Goldstein
2016-03-28 15:01 ` Doug Goldstein
2016-03-29 11:44 ` George Dunlap
2016-03-29 17:21 ` Doug Goldstein
2016-03-30 9:52 ` George Dunlap
2016-03-30 16:00 ` Ian Jackson
2016-03-30 16:11 ` Ian Jackson
2016-03-30 16:20 ` Doug Goldstein
2016-03-31 8:24 ` George Dunlap
2016-04-06 14:07 ` Ian Jackson
2016-04-06 14:34 ` George Dunlap
2016-04-06 14:57 ` Ian Jackson
2016-03-08 15:38 ` [PATCH 1/2] libxl: ensure var is inited in libxl__domain_firmware Wei Liu
2016-03-10 15:13 ` Doug Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457403820-2949-1-git-send-email-cardoe@cardoe.com \
--to=cardoe@cardoe.com \
--cc=ian.jackson@eu.citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).