From mboxrd@z Thu Jan 1 00:00:00 1970 From: Harmandeep Kaur Subject: [PATCH 1/9 v2] xl: Improve return and exit codes of memory related functions. Date: Wed, 9 Mar 2016 00:32:02 +0530 Message-ID: <1457463730-4712-2-git-send-email-write.harmandeep@gmail.com> References: <1457463730-4712-1-git-send-email-write.harmandeep@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.84) (envelope-from ) id 1adMtw-0000mS-QW for xen-devel@lists.xenproject.org; Tue, 08 Mar 2016 19:02:36 +0000 Received: by mail-wm0-f67.google.com with SMTP id 1so5907092wmg.2 for ; Tue, 08 Mar 2016 11:02:35 -0800 (PST) In-Reply-To: <1457463730-4712-1-git-send-email-write.harmandeep@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: xen-devel@lists.xenproject.org Cc: wei.liu2@citrix.com, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, dario.faggioli@citrix.com, ian.jackson@eu.citrix.com, Harmandeep Kaur List-Id: xen-devel@lists.xenproject.org UmV0dXJuIGFuZCBleGl0IGNvZGVzIG9mIGZyZWVtZW0oKSwgc2V0X21lbW9yeV9tYXgoKSwgbWFp bl9tZW1tYXgoKSwKc2V0X21lbW9yeV90YXJnZXQoKSwgbWFpbl9tZW1zZXQoKSBhbmQgbWFpbl9z aGFyaW5nKCkgaW4gdGhlIGZpbGUKeGxfY21kaW1wbCBhcmUgZml4ZWQuCgpBZGQgY29tbWVudCB0 byBleHBsYWluIHJldHVybiB2YXVsZSBvZiBwYXJzZV9tZW1fc2l6ZV9rYigpLgoKU2lnbmVkLW9m Zi1ieTogSGFybWFuZGVlcCBLYXVyIDx3cml0ZS5oYXJtYW5kZWVwQGdtYWlsLmNvbT4KLS0tCnYy OiBBZGQgY29tbWVudCB0byBleHBsYWluIHJldHVybiB2YXVsZSBvZiBwYXJzZV9tZW1fc2l6ZV9r YigpLgogICAgQWRkIGZyZWVtZW0oKSBhbmQgbWFpbl9zaGFyaW5nKCkuCiAgICBSZW1vdmUgZmlu ZF9kb21haW4oKS4KLS0tCiB0b29scy9saWJ4bC94bF9jbWRpbXBsLmMgfCA0MCArKysrKysrKysr KysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMjIgaW5zZXJ0 aW9ucygrKSwgMTggZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvdG9vbHMvbGlieGwveGxfY21k aW1wbC5jIGIvdG9vbHMvbGlieGwveGxfY21kaW1wbC5jCmluZGV4IDk5MGQzYzkuLjA4ODk3MWUg MTAwNjQ0Ci0tLSBhL3Rvb2xzL2xpYnhsL3hsX2NtZGltcGwuYworKysgYi90b29scy9saWJ4bC94 bF9jbWRpbXBsLmMKQEAgLTI1ODEsMzAgKzI1ODEsMzAgQEAgc3RhdGljIGludCBmcmVlbWVtKHVp bnQzMl90IGRvbWlkLCBsaWJ4bF9kb21haW5fYnVpbGRfaW5mbyAqYl9pbmZvKQogCiAgICAgcmMg PSBsaWJ4bF9kb21haW5fbmVlZF9tZW1vcnkoY3R4LCBiX2luZm8sICZuZWVkX21lbWtiKTsKICAg ICBpZiAocmMgPCAwKQotICAgICAgICByZXR1cm4gcmM7CisgICAgICAgIHJldHVybiAtMTsKIAog ICAgIGRvIHsKICAgICAgICAgcmMgPSBsaWJ4bF9nZXRfZnJlZV9tZW1vcnkoY3R4LCAmZnJlZV9t ZW1rYik7CiAgICAgICAgIGlmIChyYyA8IDApCi0gICAgICAgICAgICByZXR1cm4gcmM7CisgICAg ICAgICAgICByZXR1cm4gLTE7CiAKICAgICAgICAgaWYgKGZyZWVfbWVta2IgPj0gbmVlZF9tZW1r YikKICAgICAgICAgICAgIHJldHVybiAwOwogCiAgICAgICAgIHJjID0gbGlieGxfc2V0X21lbW9y eV90YXJnZXQoY3R4LCAwLCBmcmVlX21lbWtiIC0gbmVlZF9tZW1rYiwgMSwgMCk7CiAgICAgICAg IGlmIChyYyA8IDApCi0gICAgICAgICAgICByZXR1cm4gcmM7CisgICAgICAgICAgICByZXR1cm4g LTE7CiAKICAgICAgICAgLyogd2FpdCB1bnRpbCBkb20wIHJlYWNoZXMgaXRzIHRhcmdldCwgYXMg bG9uZyBhcyB3ZSBhcmUgbWFraW5nCiAgICAgICAgICAqIHByb2dyZXNzICovCiAgICAgICAgIHJj ID0gbGlieGxfd2FpdF9mb3JfbWVtb3J5X3RhcmdldChjdHgsIDAsIDEwKTsKICAgICAgICAgaWYg KHJjIDwgMCkKLSAgICAgICAgICAgIHJldHVybiByYzsKKyAgICAgICAgICAgIHJldHVybiAtMTsK IAogICAgICAgICByZXRyaWVzLS07CiAgICAgfSB3aGlsZSAocmV0cmllcyA+IDApOwogCi0gICAg cmV0dXJuIEVSUk9SX05PTUVNOworICAgIHJldHVybiAtMTsKIH0KIAogc3RhdGljIHZvaWQgYXV0 b2Nvbm5lY3RfY29uc29sZShsaWJ4bF9jdHggKmN0eF9pZ25vcmVkLApAQCAtMzEzMyw2ICszMTMz LDEwIEBAIHZvaWQgaGVscChjb25zdCBjaGFyICpjb21tYW5kKQogICAgIH0KIH0KIAorLyoKKyAq IHBhcnNlX21lbV9zaXplX2tiKCkgcmV0dXJucyAtMSBvbiBmYWlsdXJlLCBvciB0aGUgYW1vdW50 IG9mIG1lbW9yeSwKKyAqIG9uIHN1Y2Nlc3MuCisgKi8KIHN0YXRpYyBpbnQ2NF90IHBhcnNlX21l bV9zaXplX2tiKGNvbnN0IGNoYXIgKm1lbSkKIHsKICAgICBjaGFyICplbmRwdHI7CkBAIC0zMjc1 LDE3ICszMjc5LDE3IEBAIHN0YXRpYyBpbnQgZGVmX2dldG9wdChpbnQgYXJnYywgY2hhciAqIGNv bnN0IGFyZ3ZbXSwKIHN0YXRpYyBpbnQgc2V0X21lbW9yeV9tYXgodWludDMyX3QgZG9taWQsIGNv bnN0IGNoYXIgKm1lbSkKIHsKICAgICBpbnQ2NF90IG1lbW9yeWtiOwotICAgIGludCByYzsKIAog ICAgIG1lbW9yeWtiID0gcGFyc2VfbWVtX3NpemVfa2IobWVtKTsKICAgICBpZiAobWVtb3J5a2Ig PT0gLTEpIHsKICAgICAgICAgZnByaW50ZihzdGRlcnIsICJpbnZhbGlkIG1lbW9yeSBzaXplOiAl c1xuIiwgbWVtKTsKLSAgICAgICAgZXhpdCgzKTsKKyAgICAgICAgZXhpdChFWElUX0ZBSUxVUkUp OwogICAgIH0KIAotICAgIHJjID0gbGlieGxfZG9tYWluX3NldG1heG1lbShjdHgsIGRvbWlkLCBt ZW1vcnlrYik7CisgICAgaWYgKGxpYnhsX2RvbWFpbl9zZXRtYXhtZW0oY3R4LCBkb21pZCwgbWVt b3J5a2IpKQorCXJldHVybiAxOwogCi0gICAgcmV0dXJuIHJjOworICAgIHJldHVybiAwOwogfQog CiBpbnQgbWFpbl9tZW1tYXgoaW50IGFyZ2MsIGNoYXIgKiphcmd2KQpAQCAtMzMwNSwxMCArMzMw OSwxMCBAQCBpbnQgbWFpbl9tZW1tYXgoaW50IGFyZ2MsIGNoYXIgKiphcmd2KQogICAgIHJjID0g c2V0X21lbW9yeV9tYXgoZG9taWQsIG1lbSk7CiAgICAgaWYgKHJjKSB7CiAgICAgICAgIGZwcmlu dGYoc3RkZXJyLCAiY2Fubm90IHNldCBkb21pZCAlZCBzdGF0aWMgbWF4IG1lbW9yeSB0byA6ICVz XG4iLCBkb21pZCwgbWVtKTsKLSAgICAgICAgcmV0dXJuIDE7CisgICAgICAgIHJldHVybiBFWElU X0ZBSUxVUkU7CiAgICAgfQogCi0gICAgcmV0dXJuIDA7CisgICAgcmV0dXJuIEVYSVRfU1VDQ0VT UzsKIH0KIAogc3RhdGljIHZvaWQgc2V0X21lbW9yeV90YXJnZXQodWludDMyX3QgZG9taWQsIGNv bnN0IGNoYXIgKm1lbSkKQEAgLTMzMTgsNyArMzMyMiw3IEBAIHN0YXRpYyB2b2lkIHNldF9tZW1v cnlfdGFyZ2V0KHVpbnQzMl90IGRvbWlkLCBjb25zdCBjaGFyICptZW0pCiAgICAgbWVtb3J5a2Ig PSBwYXJzZV9tZW1fc2l6ZV9rYihtZW0pOwogICAgIGlmIChtZW1vcnlrYiA9PSAtMSkgIHsKICAg ICAgICAgZnByaW50ZihzdGRlcnIsICJpbnZhbGlkIG1lbW9yeSBzaXplOiAlc1xuIiwgbWVtKTsK LSAgICAgICAgZXhpdCgzKTsKKyAgICAgICAgZXhpdChFWElUX0ZBSUxVUkUpOwogICAgIH0KIAog ICAgIGxpYnhsX3NldF9tZW1vcnlfdGFyZ2V0KGN0eCwgZG9taWQsIG1lbW9yeWtiLCAwLCAvKiBl bmZvcmNlICovIDEpOwpAQCAtMzMzOCw3ICszMzQyLDcgQEAgaW50IG1haW5fbWVtc2V0KGludCBh cmdjLCBjaGFyICoqYXJndikKICAgICBtZW0gPSBhcmd2W29wdGluZCArIDFdOwogCiAgICAgc2V0 X21lbW9yeV90YXJnZXQoZG9taWQsIG1lbSk7Ci0gICAgcmV0dXJuIDA7CisgICAgcmV0dXJuIEVY SVRfU1VDQ0VTUzsKIH0KIAogc3RhdGljIGludCBjZF9pbnNlcnQodWludDMyX3QgZG9taWQsIGNv bnN0IGNoYXIgKnZpcnRkZXYsIGNoYXIgKnBoeXMpCkBAIC01NzgzLDcgKzU3ODcsNyBAQCBpbnQg bWFpbl9zaGFyaW5nKGludCBhcmdjLCBjaGFyICoqYXJndikKICAgICAgICAgaW5mbyA9IGxpYnhs X2xpc3RfZG9tYWluKGN0eCwgJm5iX2RvbWFpbik7CiAgICAgICAgIGlmICghaW5mbykgewogICAg ICAgICAgICAgZnByaW50ZihzdGRlcnIsICJsaWJ4bF9saXN0X2RvbWFpbiBmYWlsZWQuXG4iKTsK LSAgICAgICAgICAgIHJldHVybiAxOworICAgICAgICAgICAgcmV0dXJuIEVYSVRfRkFJTFVSRTsK ICAgICAgICAgfQogICAgICAgICBpbmZvX2ZyZWUgPSBpbmZvOwogICAgIH0gZWxzZSBpZiAob3B0 aW5kID09IGFyZ2MtMSkgewpAQCAtNTc5MiwxNyArNTc5NiwxNyBAQCBpbnQgbWFpbl9zaGFyaW5n KGludCBhcmdjLCBjaGFyICoqYXJndikKICAgICAgICAgaWYgKHJjID09IEVSUk9SX0RPTUFJTl9O T1RGT1VORCkgewogICAgICAgICAgICAgZnByaW50ZihzdGRlcnIsICJFcnJvcjogRG9tYWluIFwn JXNcJyBkb2VzIG5vdCBleGlzdC5cbiIsCiAgICAgICAgICAgICAgICAgYXJndltvcHRpbmRdKTsK LSAgICAgICAgICAgIHJldHVybiAtcmM7CisgICAgICAgICAgICByZXR1cm4gRVhJVF9GQUlMVVJF OwogICAgICAgICB9CiAgICAgICAgIGlmIChyYykgewogICAgICAgICAgICAgZnByaW50ZihzdGRl cnIsICJsaWJ4bF9kb21haW5faW5mbyBmYWlsZWQgKGNvZGUgJWQpLlxuIiwgcmMpOwotICAgICAg ICAgICAgcmV0dXJuIC1yYzsKKyAgICAgICAgICAgIHJldHVybiBFWElUX0ZBSUxVUkU7CiAgICAg ICAgIH0KICAgICAgICAgaW5mbyA9ICZpbmZvX2J1ZjsKICAgICAgICAgbmJfZG9tYWluID0gMTsK ICAgICB9IGVsc2UgewogICAgICAgICBoZWxwKCJzaGFyaW5nIik7Ci0gICAgICAgIHJldHVybiAy OworICAgICAgICByZXR1cm4gRVhJVF9GQUlMVVJFOwogICAgIH0KIAogICAgIHNoYXJpbmcoaW5m bywgbmJfZG9tYWluKTsKQEAgLTU4MTIsNyArNTgxNiw3IEBAIGludCBtYWluX3NoYXJpbmcoaW50 IGFyZ2MsIGNoYXIgKiphcmd2KQogICAgIGVsc2UKICAgICAgICAgbGlieGxfZG9taW5mb19kaXNw b3NlKGluZm8pOwogCi0gICAgcmV0dXJuIDA7CisgICAgcmV0dXJuIEVYSVRfU1VDQ0VTUzsKIH0K IAogc3RhdGljIGludCBzY2hlZF9kb21haW5fZ2V0KGxpYnhsX3NjaGVkdWxlciBzY2hlZCwgaW50 IGRvbWlkLAotLSAKMi41LjAKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW4ub3Jn Cmh0dHA6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=