From mboxrd@z Thu Jan 1 00:00:00 1970 From: Harmandeep Kaur Subject: [PATCH 5/9 v2] xl: Improve return and exit codes of pause, destroy and shutdown related functions. Date: Wed, 9 Mar 2016 00:32:06 +0530 Message-ID: <1457463730-4712-6-git-send-email-write.harmandeep@gmail.com> References: <1457463730-4712-1-git-send-email-write.harmandeep@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.84) (envelope-from ) id 1adMuH-0000tp-Dl for xen-devel@lists.xenproject.org; Tue, 08 Mar 2016 19:02:57 +0000 Received: by mail-wm0-f67.google.com with SMTP id l68so5892764wml.3 for ; Tue, 08 Mar 2016 11:02:56 -0800 (PST) In-Reply-To: <1457463730-4712-1-git-send-email-write.harmandeep@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: xen-devel@lists.xenproject.org Cc: wei.liu2@citrix.com, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, dario.faggioli@citrix.com, ian.jackson@eu.citrix.com, Harmandeep Kaur List-Id: xen-devel@lists.xenproject.org ZGVzdHJveV9kb21haW4oKSwgd2FpdF9mb3JfZG9tYWluX2RlYXRocygpLCBzaHV0ZG93bl9kb21h aW4oKSwKcmVib290X2RvbWFpbigpLCBtYWluX3BhdXNlKCksIG1haW5fdW5wYXVzZSgpLCBtYWlu X2Rlc3Ryb3koKQphbmQgbWFpbl9zaHV0ZG93bl9vcl9yZWJvb3QoKSBhcmUgZml4ZWQuCgpTaWdu ZWQtb2ZmLWJ5OiBIYXJtYW5kZWVwIEthdXIgPHdyaXRlLmhhcm1hbmRlZXBAZ21haWwuY29tPgot LS0KdjI6IE5vIGNoYW5nZXMuCi0tLQogdG9vbHMvbGlieGwveGxfY21kaW1wbC5jIHwgMjYgKysr KysrKysrKysrKy0tLS0tLS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAxMyBpbnNlcnRpb25zKCsp LCAxMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS90b29scy9saWJ4bC94bF9jbWRpbXBsLmMg Yi90b29scy9saWJ4bC94bF9jbWRpbXBsLmMKaW5kZXggNWNlZGZlOC4uMDJhZWMzNCAxMDA2NDQK LS0tIGEvdG9vbHMvbGlieGwveGxfY21kaW1wbC5jCisrKyBiL3Rvb2xzL2xpYnhsL3hsX2NtZGlt cGwuYwpAQCAtMzcwNSwxMCArMzcwNSwxMCBAQCBzdGF0aWMgdm9pZCBkZXN0cm95X2RvbWFpbih1 aW50MzJfdCBkb21pZCwgaW50IGZvcmNlKQogICAgICAgICBmcHJpbnRmKHN0ZGVyciwgIk5vdCBk ZXN0cm95aW5nIGRvbWFpbiAwOyB1c2UgLWYgdG8gZm9yY2UuXG4iCiAgICAgICAgICAgICAgICAg ICAgICAgICAiVGhpcyBjYW4gb25seSBiZSBkb25lIHdoZW4gdXNpbmcgYSBkaXNhZ2dyZWdhdGVk ICIKICAgICAgICAgICAgICAgICAgICAgICAgICJoYXJkd2FyZSBkb21haW4gYW5kIHRvb2xzdGFj ay5cblxuIik7Ci0gICAgICAgIGV4aXQoLTEpOworICAgICAgICBleGl0KEVYSVRfRkFJTFVSRSk7 CiAgICAgfQogICAgIHJjID0gbGlieGxfZG9tYWluX2Rlc3Ryb3koY3R4LCBkb21pZCwgMCk7Ci0g ICAgaWYgKHJjKSB7IGZwcmludGYoc3RkZXJyLCJkZXN0cm95IGZhaWxlZCAocmM9JWQpXG4iLHJj KTsgZXhpdCgtMSk7IH0KKyAgICBpZiAocmMpIHsgZnByaW50ZihzdGRlcnIsImRlc3Ryb3kgZmFp bGVkIChyYz0lZClcbiIscmMpOyBleGl0KEVYSVRfRkFJTFVSRSk7IH0KIH0KIAogc3RhdGljIHZv aWQgd2FpdF9mb3JfZG9tYWluX2RlYXRocyhsaWJ4bF9ldmdlbl9kb21haW5fZGVhdGggKipkZWF0 aHdzLCBpbnQgbnIpCkBAIC0zNzIwLDcgKzM3MjAsNyBAQCBzdGF0aWMgdm9pZCB3YWl0X2Zvcl9k b21haW5fZGVhdGhzKGxpYnhsX2V2Z2VuX2RvbWFpbl9kZWF0aCAqKmRlYXRod3MsIGludCBucikK ICAgICAgICAgcmMgPSBsaWJ4bF9ldmVudF93YWl0KGN0eCwgJmV2ZW50LCBMSUJYTF9FVkVOVE1B U0tfQUxMLCAwLDApOwogICAgICAgICBpZiAocmMpIHsKICAgICAgICAgICAgIExPRygiRmFpbGVk IHRvIGdldCBldmVudCwgcXVpdHRpbmcgKHJjPSVkKSIsIHJjKTsKLSAgICAgICAgICAgIGV4aXQo LTEpOworICAgICAgICAgICAgZXhpdChFWElUX0ZBSUxVUkUpOwogICAgICAgICB9CiAKICAgICAg ICAgc3dpdGNoIChldmVudC0+dHlwZSkgewpAQCAtMzc2NSwxNCArMzc2NSwxNCBAQCBzdGF0aWMg dm9pZCBzaHV0ZG93bl9kb21haW4odWludDMyX3QgZG9taWQsCiAgICAgfQogCiAgICAgaWYgKHJj KSB7Ci0gICAgICAgIGZwcmludGYoc3RkZXJyLCJzaHV0ZG93biBmYWlsZWQgKHJjPSVkKVxuIixy Yyk7ZXhpdCgtMSk7CisgICAgICAgIGZwcmludGYoc3RkZXJyLCJzaHV0ZG93biBmYWlsZWQgKHJj PSVkKVxuIixyYyk7ZXhpdChFWElUX0ZBSUxVUkUpOwogICAgIH0KIAogICAgIGlmIChkZWF0aHcp IHsKICAgICAgICAgcmMgPSBsaWJ4bF9ldmVuYWJsZV9kb21haW5fZGVhdGgoY3R4LCBkb21pZCwg Zm9yX3VzZXIsIGRlYXRodyk7CiAgICAgICAgIGlmIChyYykgewogICAgICAgICAgICAgZnByaW50 ZihzdGRlcnIsIndhaXQgZm9yIGRlYXRoIGZhaWxlZCAoZXZnZW4sIHJjPSVkKVxuIixyYyk7Ci0g ICAgICAgICAgICBleGl0KC0xKTsKKyAgICAgICAgICAgIGV4aXQoRVhJVF9GQUlMVVJFKTsKICAg ICAgICAgfQogICAgIH0KIH0KQEAgLTM3OTYsMTQgKzM3OTYsMTQgQEAgc3RhdGljIHZvaWQgcmVi b290X2RvbWFpbih1aW50MzJfdCBkb21pZCwgbGlieGxfZXZnZW5fZG9tYWluX2RlYXRoICoqZGVh dGh3LAogICAgICAgICB9CiAgICAgfQogICAgIGlmIChyYykgewotICAgICAgICBmcHJpbnRmKHN0 ZGVyciwicmVib290IGZhaWxlZCAocmM9JWQpXG4iLHJjKTtleGl0KC0xKTsKKyAgICAgICAgZnBy aW50ZihzdGRlcnIsInJlYm9vdCBmYWlsZWQgKHJjPSVkKVxuIixyYyk7ZXhpdChFWElUX0ZBSUxV UkUpOwogICAgIH0KIAogICAgIGlmIChkZWF0aHcpIHsKICAgICAgICAgcmMgPSBsaWJ4bF9ldmVu YWJsZV9kb21haW5fZGVhdGgoY3R4LCBkb21pZCwgZm9yX3VzZXIsIGRlYXRodyk7CiAgICAgICAg IGlmIChyYykgewogICAgICAgICAgICAgZnByaW50ZihzdGRlcnIsIndhaXQgZm9yIGRlYXRoIGZh aWxlZCAoZXZnZW4sIHJjPSVkKVxuIixyYyk7Ci0gICAgICAgICAgICBleGl0KC0xKTsKKyAgICAg ICAgICAgIGV4aXQoRVhJVF9GQUlMVVJFKTsKICAgICAgICAgfQogICAgIH0KIH0KQEAgLTQ4MDIs NyArNDgwMiw3IEBAIGludCBtYWluX3BhdXNlKGludCBhcmdjLCBjaGFyICoqYXJndikKIAogICAg IHBhdXNlX2RvbWFpbihmaW5kX2RvbWFpbihhcmd2W29wdGluZF0pKTsKIAotICAgIHJldHVybiAw OworICAgIHJldHVybiBFWElUX1NVQ0NFU1M7CiB9CiAKIGludCBtYWluX3VucGF1c2UoaW50IGFy Z2MsIGNoYXIgKiphcmd2KQpAQCAtNDgxNSw3ICs0ODE1LDcgQEAgaW50IG1haW5fdW5wYXVzZShp bnQgYXJnYywgY2hhciAqKmFyZ3YpCiAKICAgICB1bnBhdXNlX2RvbWFpbihmaW5kX2RvbWFpbihh cmd2W29wdGluZF0pKTsKIAotICAgIHJldHVybiAwOworICAgIHJldHVybiBFWElUX1NVQ0NFU1M7 CiB9CiAKIGludCBtYWluX2Rlc3Ryb3koaW50IGFyZ2MsIGNoYXIgKiphcmd2KQpAQCAtNDgzMCw3 ICs0ODMwLDcgQEAgaW50IG1haW5fZGVzdHJveShpbnQgYXJnYywgY2hhciAqKmFyZ3YpCiAgICAg fQogCiAgICAgZGVzdHJveV9kb21haW4oZmluZF9kb21haW4oYXJndltvcHRpbmRdKSwgZm9yY2Up OwotICAgIHJldHVybiAwOworICAgIHJldHVybiBFWElUX1NVQ0NFU1M7CiB9CiAKIHN0YXRpYyBp bnQgbWFpbl9zaHV0ZG93bl9vcl9yZWJvb3QoaW50IGRvX3JlYm9vdCwgaW50IGFyZ2MsIGNoYXIg Kiphcmd2KQpAQCAtNDg2Miw3ICs0ODYyLDcgQEAgc3RhdGljIGludCBtYWluX3NodXRkb3duX29y X3JlYm9vdChpbnQgZG9fcmVib290LCBpbnQgYXJnYywgY2hhciAqKmFyZ3YpCiAKICAgICBpZiAo IWFyZ3Zbb3B0aW5kXSAmJiAhYWxsKSB7CiAgICAgICAgIGZwcmludGYoc3RkZXJyLCAiWW91IG11 c3Qgc3BlY2lmeSAtYSBvciBhIGRvbWFpbiBpZC5cblxuIik7Ci0gICAgICAgIHJldHVybiBvcHQ7 CisgICAgICAgIHJldHVybiBFWElUX0ZBSUxVUkU7CiAgICAgfQogCiAgICAgaWYgKGFsbCkgewpA QCAtNDg3MCw3ICs0ODcwLDcgQEAgc3RhdGljIGludCBtYWluX3NodXRkb3duX29yX3JlYm9vdChp bnQgZG9fcmVib290LCBpbnQgYXJnYywgY2hhciAqKmFyZ3YpCiAgICAgICAgIGxpYnhsX2V2Z2Vu X2RvbWFpbl9kZWF0aCAqKmRlYXRod3MgPSBOVUxMOwogICAgICAgICBpZiAoIShkb21pbmZvID0g bGlieGxfbGlzdF9kb21haW4oY3R4LCAmbmJfZG9tYWluKSkpIHsKICAgICAgICAgICAgIGZwcmlu dGYoc3RkZXJyLCAibGlieGxfbGlzdF9kb21haW4gZmFpbGVkLlxuIik7Ci0gICAgICAgICAgICBy ZXR1cm4gLTE7CisgICAgICAgICAgICByZXR1cm4gRVhJVF9GQUlMVVJFOwogICAgICAgICB9CiAK ICAgICAgICAgaWYgKHdhaXRfZm9yX2l0KQpAQCAtNDkwMSw3ICs0OTAxLDcgQEAgc3RhdGljIGlu dCBtYWluX3NodXRkb3duX29yX3JlYm9vdChpbnQgZG9fcmVib290LCBpbnQgYXJnYywgY2hhciAq KmFyZ3YpCiAgICAgfQogCiAKLSAgICByZXR1cm4gMDsKKyAgICByZXR1cm4gRVhJVF9TVUNDRVNT OwogfQogCiBpbnQgbWFpbl9zaHV0ZG93bihpbnQgYXJnYywgY2hhciAqKmFyZ3YpCi0tIAoyLjUu MAoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1k ZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbi5vcmcKaHR0cDovL2xpc3RzLnhl bi5vcmcveGVuLWRldmVsCg==