xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Dario Faggioli <dario.faggioli@citrix.com>
To: Chong Li <lichong659@gmail.com>, xen-devel@lists.xen.org
Cc: Chong Li <chong.li@wustl.edu>,
	wei.liu2@citrix.com, Sisu Xi <xisisu@gmail.com>,
	george.dunlap@eu.citrix.com, ian.jackson@eu.citrix.com,
	Meng Xu <mengxu@cis.upenn.edu>,
	dgolomb@seas.upenn.edu
Subject: Re: [PATCH v6 for Xen 4.7 3/4] libxl: enable per-VCPU parameter settings for RTDS scheduler
Date: Wed, 9 Mar 2016 18:09:27 +0100	[thread overview]
Message-ID: <1457543367.3102.438.camel@citrix.com> (raw)
In-Reply-To: <1457286958-5427-4-git-send-email-lichong659@gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 2474 bytes --]

On the whole series, you are Cc-ing ian.campbell@eu.citrix.com, which
is no longer a tools maintainer.

Please, double check by looking at MAINTAINERS and/or with
./scripts/get_maintainer.pl.

While fiddling with the Cc-list, can you please try to arrange things
in such a way that each person is Cc-ed only to the subset of the
series that he would reasonably care about.

For instance, Jan is likely not going to look at libxl and xl stuff, so
no need bothering him with that. Similarly, IanJ wouldn't probably look
at hypervisor stuff.

If you are in doubt, stick to MAINTAINERS, with the exception that, if
some random person commented on vX, he should be Cc-ed to vX+1, where
the comments are addressed, no matter what he/she maintains.

There are other exceptions, actually. For example, it's ok to Cc me to
the whole series. This is hard to "set in stone", so again, if in
doubt, follow the rule above... If people are interested in a patch
that they happen not to be Cc-ed to, they'll find it via the mailing
list.

On Sun, 2016-03-06 at 11:55 -0600, Chong Li wrote:
> 
> diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
> index bd3aac8..4532e86 100644
> --- a/tools/libxl/libxl.c
> +++ b/tools/libxl/libxl.c
> @@ -5770,6 +5770,207 @@ static int sched_credit2_domain_set(libxl__gc
> *gc, uint32_t domid,
>      return 0;
>  }
>  
> +static int sched_rtds_validate_params(libxl__gc *gc, int period,
> +                                    int budget, uint32_t
> *sdom_period,
> +                                    uint32_t *sdom_budget)
> +{
> +    int rc = 0;
>
Empty line here (between local variables and code).

Also, libxl coding style says:

  * If the function is to return a libxl error value, `rc' is
    used to contain the error code, but it is NOT initialised:
            int rc;

This, in addition to all what Wei pointed out, to mean that, although
things are certainly improving, some non negligible amount of coding
style issues needs fixing.

(I'll elaborate more, and more in general, in another email.)

Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  parent reply	other threads:[~2016-03-09 17:09 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-06 17:55 [PATCH v6 for Xen 4.7 0/4] Enable per-VCPU parameter settings for RTDS scheduler Chong Li
2016-03-06 17:55 ` [PATCH v6 for Xen 4.7 1/4] xen: enable " Chong Li
2016-03-07 12:59   ` Jan Beulich
2016-03-07 16:28     ` Chong Li
2016-03-07 16:40       ` Jan Beulich
2016-03-07 17:53         ` Dario Faggioli
2016-03-07 22:16           ` Chong Li
2016-03-08  9:10           ` Jan Beulich
2016-03-08 10:34             ` Dario Faggioli
2016-03-08 11:47               ` Jan Beulich
2016-03-08 19:09   ` Wei Liu
2016-03-09 16:10     ` Dario Faggioli
2016-03-09 16:38       ` Jan Beulich
2016-03-13 17:05         ` Chong Li
2016-03-14  8:37           ` Jan Beulich
2016-03-14  9:10             ` Dario Faggioli
2016-03-14  9:15               ` Jan Beulich
2016-03-14 10:05                 ` Dario Faggioli
2016-03-15 16:22                   ` Chong Li
2016-03-15 16:41                     ` Dario Faggioli
2016-03-15 17:22                       ` Chong Li
2016-03-16  3:14                         ` Meng Xu
2016-03-16  3:32                           ` Chong Li
2016-03-16  3:43                             ` Meng Xu
2016-03-16  8:23                               ` Dario Faggioli
2016-03-16 14:37                                 ` Meng Xu
2016-03-16 14:46                                   ` Chong Li
2016-03-16 14:53                                   ` Dario Faggioli
2016-03-16 14:46                                 ` Chong Li
2016-03-16 14:54                                   ` Dario Faggioli
2016-03-16 10:48                               ` Jan Beulich
2016-03-10 22:35     ` Chong Li
2016-03-10 22:50       ` Wei Liu
2016-03-14  9:07         ` Dario Faggioli
2016-03-06 17:55 ` [PATCH v6 for Xen 4.7 2/4] libxc: " Chong Li
2016-03-08 19:09   ` Wei Liu
2016-03-08 19:32     ` Chong Li
2016-03-08 19:36       ` Wei Liu
2016-03-06 17:55 ` [PATCH v6 for Xen 4.7 3/4] libxl: " Chong Li
2016-03-08 19:12   ` Wei Liu
2016-03-09  0:38     ` Chong Li
2016-03-09 14:01       ` Wei Liu
2016-03-09 17:28     ` Dario Faggioli
2016-03-09 21:57       ` Chong Li
2016-03-09 17:09   ` Dario Faggioli [this message]
2016-03-09 17:28     ` Dario Faggioli
2016-03-06 17:55 ` [PATCH v6 for Xen 4.7 4/4] xl: " Chong Li
2016-03-08 19:12   ` Wei Liu
2016-03-08 21:24     ` Chong Li
2016-03-09 14:01       ` Wei Liu
2016-03-09 14:09   ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1457543367.3102.438.camel@citrix.com \
    --to=dario.faggioli@citrix.com \
    --cc=chong.li@wustl.edu \
    --cc=dgolomb@seas.upenn.edu \
    --cc=george.dunlap@eu.citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=lichong659@gmail.com \
    --cc=mengxu@cis.upenn.edu \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    --cc=xisisu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).