[PATCH v4 0/2] Make the pcidevs_lock a recursive one

From: Quan Xu <quan.xu@intel.com>
To: xen-devel@lists.xen.org
Cc: Kevin Tian <kevin.tian@intel.com>, Feng Wu <feng.wu@intel.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Dario Faggioli <dario.faggioli@citrix.com>,
	Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
	Quan Xu <quan.xu@intel.com>, Keir Fraser <keir@xen.org>
Subject: [PATCH v4 0/2] Make the pcidevs_lock a recursive one
Date: Thu, 10 Mar 2016 22:10:05 +0800	[thread overview]
Message-ID: <1457619007-41460-1-git-send-email-quan.xu@intel.com> (raw)

This patch set makes the pcidevs_lock a recursive one, as pcidevs_lock is
going to be recursively taken for hiding ATS device, when VT-d Device-TLB flush
timed out. It is a prereq patch set for Patch:'VT-d Device-TLB flush issue'.

In detail:
 1. Fix a bug found in AMD IOMMU initialization

  pcidevs_lock doesn't require interrupts to be disabled while being acquired.
  However there remains an exception in AMD IOMMU code, where the lock is
  acquired with interrupt disabled. This inconsistency might lead to deadlock.

  The fix is straightforward to use spin_lock instead. Also interrupt has been
  enabled when this function is invoked, so we're sure consistency around
  pcidevs_lock can be guaranteed after this fix.

 2. Make the pcidevs_lock a recursive one.

  pcidevs_lock is going to be recursively taken for hiding ATS device,
  when VT-d Device-TLB flush timed out.

CC: Keir Fraser <keir@xen.org>
CC: Jan Beulich <jbeulich@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
CC: Feng Wu <feng.wu@intel.com>
CC: Kevin Tian <kevin.tian@intel.com>
CC: Dario Faggioli <dario.faggioli@citrix.com>

--Changes in v4:
 * Enhance changelogs.
 * Rebase against 0aa1330aac92.

Quan Xu (2):
  IOMMU/spinlock: Fix a bug found in AMD IOMMU initialization
  IOMMU/spinlock: Make the pcidevs_lock a recursive one.

 xen/arch/x86/domctl.c                       |  8 +--
 xen/arch/x86/hvm/vmsi.c                     |  4 +-
 xen/arch/x86/irq.c                          |  8 +--
 xen/arch/x86/msi.c                          | 16 ++---
 xen/arch/x86/pci.c                          |  4 +-
 xen/arch/x86/physdev.c                      | 16 ++---
 xen/common/sysctl.c                         |  4 +-
 xen/drivers/passthrough/amd/iommu_init.c    |  9 ++-
 xen/drivers/passthrough/amd/iommu_map.c     |  2 +-
 xen/drivers/passthrough/amd/pci_amd_iommu.c |  4 +-
 xen/drivers/passthrough/pci.c               | 97 ++++++++++++++++++-----------
 xen/drivers/passthrough/vtd/intremap.c      |  2 +-
 xen/drivers/passthrough/vtd/iommu.c         | 14 ++---
 xen/drivers/video/vga.c                     |  4 +-
 xen/include/xen/pci.h                       |  5 +-
 15 files changed, 110 insertions(+), 87 deletions(-)

-- 
1.9.1

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel