xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] block/xen-blkback: Deinline shrink_free_pagepool, save 204 bytes
       [not found] <1457897243-16043-1-git-send-email-dvlasenk@redhat.com>
@ 2016-03-13 19:27 ` Denys Vlasenko
  0 siblings, 0 replies; only message in thread
From: Denys Vlasenko @ 2016-03-13 19:27 UTC (permalink / raw)
  To: Konrad Rzeszutek Wilk, Roger Pau Monné
  Cc: xen-devel, Denys Vlasenko, linux-kernel

This function compiles to 201 bytes of machine code. 2 callsites.

This function has a spinlocked code section,
which is significantly more expensive than call/return overhead.

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: xen-devel@lists.xenproject.org
CC: linux-kernel@vger.kernel.org
 drivers/block/xen-blkback/blkback.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/block/xen-blkback/blkback.c b/drivers/block/xen-blkback/blkback.c
index 4809c15..5e3394c 100644
--- a/drivers/block/xen-blkback/blkback.c
+++ b/drivers/block/xen-blkback/blkback.c
@@ -155,7 +155,7 @@ static inline void put_free_pages(struct xen_blkif_ring *ring, struct page **pag
 	spin_unlock_irqrestore(&ring->free_pages_lock, flags);
-static inline void shrink_free_pagepool(struct xen_blkif_ring *ring, int num)
+static void shrink_free_pagepool(struct xen_blkif_ring *ring, int num)
 	/* Remove requested pages in batches of NUM_BATCH_FREE_PAGES */
 	struct page *page[NUM_BATCH_FREE_PAGES];

Xen-devel mailing list

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2016-03-13 19:27 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <1457897243-16043-1-git-send-email-dvlasenk@redhat.com>
2016-03-13 19:27 ` [PATCH] block/xen-blkback: Deinline shrink_free_pagepool, save 204 bytes Denys Vlasenko

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).