xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Toshi Kani <toshi.kani@hpe.com>
To: Borislav Petkov <bp@alien8.de>
Cc: "jgross@suse.com" <jgross@suse.com>,
	"boris.ostrovsky@oracle.com" <boris.ostrovsky@oracle.com>,
	"x86@kernel.org" <x86@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"paul.gortmaker@windriver.com" <paul.gortmaker@windriver.com>,
	"Luis R. Rodriguez" <mcgrof@kernel.org>,
	"hpa@zytor.com" <hpa@zytor.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"mingo@kernel.org" <mingo@kernel.org>
Subject: Re: [PATCH 1/2] x86/mm/pat: Change pat_disable() to emulate PAT table
Date: Tue, 15 Mar 2016 09:43:15 -0600	[thread overview]
Message-ID: <1458056595.6393.332.camel__3973.90656075931$1458053545$gmane$org@hpe.com> (raw)
In-Reply-To: <20160315110148.GC4559@pd.tnic>

On Tue, 2016-03-15 at 11:01 +0000, Borislav Petkov wrote:
> On Mon, Mar 14, 2016 at 09:11:16PM -0600, Toshi Kani wrote:
> > -	pat = PAT(0, WB) | PAT(1, WT) | PAT(2, UC_MINUS) | PAT(3, UC)
> > |
> > -	      PAT(4, WB) | PAT(5, WT) | PAT(6, UC_MINUS) | PAT(7, UC);
> > +	if (cpu_has_pat) {
> 
> Please use on init paths boot_cpu_has(X86_FEATURE_PAT) and on fast paths
> static_cpu_has(X86_FEATURE_PAT). No more of that cpu_has_XXX ugliness.

'cpu_has_pat' is defined as 'boot_cpu_has(X86_FEATURE_PAT)'.  Do you mean
it should explicitly use 'boot_cpu_has(X86_FEATURE_PAT)'?

Thanks,
-Toshi

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  parent reply	other threads:[~2016-03-15 14:50 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1457671546-13486-1-git-send-email-toshi.kani@hpe.com>
     [not found] ` <1457671546-13486-3-git-send-email-toshi.kani@hpe.com>
     [not found]   ` <20160311092400.GB4347@pd.tnic>
     [not found]     ` <1457722632.6393.130.camel@hpe.com>
     [not found]       ` <20160311221747.GC25147@wotan.suse.de>
     [not found]         ` <1457740571.6393.236.camel@hpe.com>
     [not found]           ` <CAB=NE6UE7pKz8bmpRrFmAW=ySY0JnGoRY=MYn2zfOH4g_H81hw@mail.gmail.com>
     [not found]             ` <1457745396.6393.257.camel@hpe.com>
2016-03-15  0:15               ` [PATCH 2/2] x86/mtrr: Refactor PAT initialization code Luis R. Rodriguez
2016-03-15 23:48                 ` Toshi Kani
2016-03-15 23:29                   ` Luis R. Rodriguez
2016-03-17 21:56                     ` Toshi Kani
2016-03-18  0:06                       ` Luis R. Rodriguez
2016-03-18 21:35                         ` Toshi Kani
2016-03-29 17:14                           ` Luis R. Rodriguez
2016-03-29 21:46                             ` Toshi Kani
2016-03-29 22:12                               ` Luis R. Rodriguez
2016-03-30  0:16                                 ` Toshi Kani
2016-03-29 23:43                                   ` Luis R. Rodriguez
2016-03-30  1:07                                     ` Toshi Kani
2016-03-30  0:34                                       ` Luis R. Rodriguez
2016-04-09  2:04                       ` Luis R. Rodriguez
2016-04-11 14:30                         ` Toshi Kani
     [not found] ` <1457671546-13486-2-git-send-email-toshi.kani@hpe.com>
     [not found]   ` <20160311091229.GA4347@pd.tnic>
     [not found]     ` <1457713660.6393.55.camel@hpe.com>
     [not found]       ` <20160311155439.GF4312@pd.tnic>
     [not found]         ` <1457724504.6393.151.camel@hpe.com>
     [not found]           ` <20160312115544.GA23410@pd.tnic>
2016-03-15  0:29             ` [PATCH 1/2] x86/mm/pat: Change pat_disable() to emulate PAT table Luis R. Rodriguez
     [not found]             ` <20160315002921.GG25147@wotan.suse.de>
2016-03-15  3:11               ` Toshi Kani
     [not found]               ` <1458011476.6393.327.camel@hpe.com>
2016-03-15 11:01                 ` Borislav Petkov
     [not found]                 ` <20160315110148.GC4559@pd.tnic>
2016-03-15 15:43                   ` Toshi Kani [this message]
     [not found]                   ` <1458056595.6393.332.camel@hpe.com>
2016-03-15 15:47                     ` Borislav Petkov
     [not found]                     ` <20160315154731.GD4559@pd.tnic>
     [not found]                       ` <1458061883.6393.359.camel@hpe.com>
2016-03-15 16:33                         ` Borislav Petkov
2016-03-15 17:11                       ` Toshi Kani
2016-03-15 21:31                 ` Luis R. Rodriguez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='1458056595.6393.332.camel__3973.90656075931$1458053545$gmane$org@hpe.com' \
    --to=toshi.kani@hpe.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=jgross@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=mingo@kernel.org \
    --cc=paul.gortmaker@windriver.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).