From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH v9]xen: sched: convert RTDS from time to
 event driven model
Date: Wed, 16 Mar 2016 11:23:31 +0100
Message-ID: <1458123811.3102.828.camel@citrix.com>
References: <1458000275-4237-1-git-send-email-tiche@seas.upenn.edu>
 <CAENZ-+kxbhucXbGBrOozQ2h-AGa_w-WVc6hHxCXuhPKaSK22_Q@mail.gmail.com>
 <56E8D3D4.1070203@seas.upenn.edu>
 <CAENZ-+=RaxmY=EnC5LhBA7bbT-M3LdYXAkYWQucdwAVsH5t8-A@mail.gmail.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8057188397477785496=="
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
 by lists.xenproject.org with esmtp (Exim 4.84_2)
 (envelope-from <prvs=876045ab4=dario.faggioli@citrix.com>)
 id 1ag8c6-0001Zp-Dc
 for xen-devel@lists.xenproject.org; Wed, 16 Mar 2016 10:23:38 +0000
In-Reply-To: <CAENZ-+=RaxmY=EnC5LhBA7bbT-M3LdYXAkYWQucdwAVsH5t8-A@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xen.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xen.org>
To: Meng Xu <xumengpanda@gmail.com>, "Chen, Tianyang" <tiche@seas.upenn.edu>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, George Dunlap <george.dunlap@citrix.com>, Dagaen Golomb <dgolomb@seas.upenn.edu>
List-Id: xen-devel@lists.xenproject.org

--===============8057188397477785496==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-a2B2QSPQ1HlwYngTatpd"

--=-a2B2QSPQ1HlwYngTatpd
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, 2016-03-15 at 23:40 -0400, Meng Xu wrote:
> > > > @@ -115,6 +118,18 @@
> > > > =C2=A0 #define RTDS_delayed_runq_add (1<<__RTDS_delayed_runq_add)
> > > >=20
> > > > =C2=A0 /*
> > > > + * The replenishment timer handler needs to check this bit
> > > > + * to know where a replenished vcpu was, when deciding which
> > > > + * vcpu should tickle.
> > > > + * A replenished vcpu should tickle if it was moved from the
> > > > + * depleted queue to the run queue.
> > > > + * + Set in burn_budget() if a vcpu has zero budget left.
> > > > + * + Cleared and checked in the repenishment handler.
> > >=20
> > > It seems you have an extra + here...
> > > Need to be removed.
> > >=20
> > > My bad, I didn't spot it out in last patch... :-(
> > >=20
> > You mean before "Cleared"? For __RTDS_scheduled there are '+'
> > before
> > 'Cleared', 'Checked', 'Set'.
> Yes, those two +, are unnecessary. Isn't it?
>=20
I *think* the idea here was to sort of put down a bullet-ed list, but
maybe we should ask the author. According to `git blame', is a certain
Meng Xu, guy (commit=C2=A08726c055), anyone has his email address? :-D :-D

However, I don't particularly like either the style or the final result
(in terms of wording), so, let's avoid doing more of that in new code
(see my other email).

Regards,
Dario
--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-a2B2QSPQ1HlwYngTatpd
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEABECAAYFAlbpNCMACgkQk4XaBE3IOsRu1QCfT1HxLZAAHr8OhJTQNSX+ddQQ
lLAAn2jyEqyBy/uTJu8ynRZ//5huIgZg
=mCYt
-----END PGP SIGNATURE-----

--=-a2B2QSPQ1HlwYngTatpd--


--===============8057188397477785496==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs
IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y
Zy94ZW4tZGV2ZWwK

--===============8057188397477785496==--