From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH 2/3] xen: sched RTDS: use uint64_t for tracing time values Date: Wed, 16 Mar 2016 17:38:44 +0100 Message-ID: <1458146324.3102.940.camel@citrix.com> References: <20160312112621.14480.21747.stgit@Solace.station> <20160312113405.14480.20446.stgit@Solace.station> <56E68D4D02000078000DBF23@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0194841383420186564==" Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1agEbu-00021X-13 for xen-devel@lists.xenproject.org; Wed, 16 Mar 2016 16:47:50 +0000 In-Reply-To: <56E68D4D02000078000DBF23@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Jan Beulich , George Dunlap Cc: xen-devel@lists.xenproject.org, Ian Jackson , Meng Xu , Wei Liu List-Id: xen-devel@lists.xenproject.org --===============0194841383420186564== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-/13jZq+7Y/riofFLPHG8" --=-/13jZq+7Y/riofFLPHG8 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2016-03-14 at 03:07 -0600, Jan Beulich wrote: > > > > On 12.03.16 at 12:34, wrote: > > --- a/xen/common/sched_rt.c > > +++ b/xen/common/sched_rt.c > > @@ -361,17 +361,14 @@ rt_update_deadline(s_time_t now, struct > > rt_vcpu *svc) > > =C2=A0 > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0/* TRACE */ > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0{ > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0struct { > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0struct __packed { > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0unsigned vcpu:16, dom:16; > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0unsigned cur_deadline_lo, cur_deadline_hi; > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0unsigned cur_budget_lo, cur_budget_hi; > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0uint64_t cur_deadline, cur_budget; > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0} d; > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0d.dom =3D svc->vc= pu->domain->domain_id; > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0d.vcpu =3D svc->v= cpu->vcpu_id; > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0d.cur_deadline_lo =3D = (unsigned) svc->cur_deadline; > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0d.cur_deadline_hi =3D = (unsigned) (svc->cur_deadline >> 32); > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0d.cur_budget_lo =3D (u= nsigned) svc->cur_budget; > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0d.cur_budget_hi =3D (u= nsigned) (svc->cur_budget >> 32); > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0d.cur_deadline =3D (ui= nt64_t) svc->cur_deadline; > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0d.cur_budget =3D (uint= 64_t) svc->cur_budget; > I don't see the need for these cast (and similar ones further down), > but you're the maintainer, so you know ... >=20 BTW, I saw you've committed this. Thanks for that, and sorry for not replying. I wanted to, but I've had a couple of day full of Internet connectivity issues. I do think it's best to keep the casts, although strictly unnecessary. About this series, I'm re-sending patch 1, by replying directly to that same email of this thread. So, for other maintainers (which I'm =C2=A0Cc-ing to this message), or should I say, for George :-), this is what should be considered for review: =C2=A0-=C2=A0[PATCH 1/3 v2] xenalyze: handle DOM0 operations events =C2=A0-=C2=A0[PATCH 3/3] xenalyze: handle RTDS scheduler events Thanks and Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-/13jZq+7Y/riofFLPHG8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlbpjBQACgkQk4XaBE3IOsQp3ACfWkpIyrhB6gtkLvabu5WY8St7 x7QAn2hy8JWw32mGNxnuPCYiucUv2ZVK =VJ2G -----END PGP SIGNATURE----- --=-/13jZq+7Y/riofFLPHG8-- --===============0194841383420186564== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y Zy94ZW4tZGV2ZWwK --===============0194841383420186564==--