From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH v11]xen: sched: convert RTDS from time to
 event driven model
Date: Fri, 18 Mar 2016 10:23:21 +0100
Message-ID: <1458293001.15374.87.camel@citrix.com>
References: <1458230814-4317-1-git-send-email-tiche@seas.upenn.edu>
 <CAENZ-+=YKbyznj0JH-HyKhHQut3wTN=ZSfLkxFgzeNUbnPm4Tg@mail.gmail.com>
 <56EBC02002000078000DE324@prv-mh.provo.novell.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7700411774856195563=="
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta6.messagelabs.com ([85.158.143.247])
 by lists.xenproject.org with esmtp (Exim 4.84_2)
 (envelope-from <prvs=878be89dd=dario.faggioli@citrix.com>)
 id 1aiVLv-00067e-5J
 for xen-devel@lists.xenproject.org; Tue, 22 Mar 2016 23:04:43 +0000
In-Reply-To: <56EBC02002000078000DE324@prv-mh.provo.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xen.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xen.org>
To: Jan Beulich <JBeulich@suse.com>, Meng Xu <mengxu@cis.upenn.edu>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Tianyang Chen <tiche@seas.upenn.edu>, George Dunlap <george.dunlap@citrix.com>, Dagaen Golomb <dgolomb@seas.upenn.edu>
List-Id: xen-devel@lists.xenproject.org

--===============7700411774856195563==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-TglrivNNuW4plkKMXDVu"

--=-TglrivNNuW4plkKMXDVu
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, 2016-03-18 at 01:45 -0600, Jan Beulich wrote:
> >=C2=A0
> > > > On 18.03.16 at 05:09, <mengxu@cis.upenn.edu> wrote:
> > Great job! However, we still have 1 mile in the 100-mile journey.
> > :-D
> >=20
> > I applied the patch on staging and tried some test cases. One of
> > them
> > is as follows:
> >=20
> > I tried to create a cpupool and then migrate a VM to the new
> > cpupool;
>
BTW, Meng:

(XEN)=C2=A0=C2=A0=C2=A0=C2=A0[<ffff82d08012e182>] schedule_cpu_switch+0x250=
/0x28a
(XEN)=C2=A0=C2=A0=C2=A0=C2=A0[<ffff82d080101b49>] cpupool.c#cpupool_assign_=
cpu_locked+0x31/0x11f

I think you mean "and then move a CPU from a cpupool to another". Or
perhaps what you said is what your script does, and you weren't sure at
what stage it explodes.

Well, let me tell you: it's when you move a CPU between pools that have
schedulers that remaps the scheduler locks (such as Credit2-->RTDS and
vice versa).

> > However, the system triggers the bug as below. I guess this is some
> > kind of bug that are known to us,=C2=A0=C2=A0and Dario had some uncommi=
tted
> > patch to fix it, IIRC?
> In the context of this patch the most relevant question is: Is this
> an issue with the patch, or one that existed already before?=20
>
Exactly!

And the answer is:
=C2=A0- it's pre-existing
=C2=A0- it's an even bigger issue than that ASSERT triggering (i.e., there
=C2=A0 =C2=A0are potential races even when things works)
=C2=A0- I'm taking care of it.

> After
> all that's what we're in need to know whether the change can go
> in.=20
>
Yep.

> And skimming over the patch, it doesn't seem to alter code
> related to where you see things blow up.
>=20
Indeed it does not.

Thanks and Regards,
Dario
--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-TglrivNNuW4plkKMXDVu
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEABECAAYFAlbryQkACgkQk4XaBE3IOsRq8gCeLiN+6yZXl9jLer2xQe9D2fus
T/gAn0ietq5N2KhlGyxYUHY0Ui9iJFRm
=b+80
-----END PGP SIGNATURE-----

--=-TglrivNNuW4plkKMXDVu--


--===============7700411774856195563==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs
IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y
Zy94ZW4tZGV2ZWwK

--===============7700411774856195563==--