From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH 1/2] IOMMU/MMU: Adjust top level functions for VT-d Device-TLB flush error. Date: Fri, 18 Mar 2016 10:38:41 +0100 Message-ID: <1458293921.15374.94.camel@citrix.com> References: <1458197676-60696-1-git-send-email-quan.xu@intel.com> <1458197676-60696-2-git-send-email-quan.xu@intel.com> <945CA011AD5F084CBEA3E851C0AB28894B86730F@SHSMSX101.ccr.corp.intel.com> <56EBC83202000078000DE391@prv-mh.provo.novell.com> <945CA011AD5F084CBEA3E851C0AB28894B867412@SHSMSX101.ccr.corp.intel.com> <56EBD88E02000078000DE406@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5968602999369145885==" Return-path: In-Reply-To: <56EBD88E02000078000DE406@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Jan Beulich , Quan Xu Cc: Kevin Tian , Feng Wu , George Dunlap , Liu Jinsong , "xen-devel@lists.xen.org" , Jun Nakajima , Andrew Cooper , Keir Fraser List-Id: xen-devel@lists.xenproject.org --===============5968602999369145885== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-/nahpEmiXKEsc0sPU5bi" --=-/nahpEmiXKEsc0sPU5bi Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2016-03-18 at 03:29 -0600, Jan Beulich wrote: > >=C2=A0 > Not sure what exactly you're asking for: As said, we first need to > settle on an abstract model. Do we want IOMMU mapping failures > to be fatal to the domain (perhaps with the exception of the > hardware one)? I think we do, and for the hardware domain we'd > do things on a best effort basis (always erring on the side of > unmapping). Which would probably mean crashing the domain > could be centralized in iommu_{,un}map_page(). How much roll > back would then still be needed in callers of these functions for > the hardware domain's sake would need to be seen. >=20 > So before you start coing, give others (namely but not limited to > VT-d, AMD IOMMU, other x86, and x86/mm maintainers) a chance > to voice differing opinions. > I'm nothing of the above but, FWIW, the behavior Jan described (crashing the domain for all domains but the hardware domain) was indeed the intended plan for this series, as far as I understood from talking to people and looking at previous email conversations and submissions. And it looks to me like it is a sane plan. Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-/nahpEmiXKEsc0sPU5bi Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlbrzKEACgkQk4XaBE3IOsRL8wCffIXSfeNWTRkFnBKH1jxlXN4v VbMAn1qDNs38lyjw6+CYbZftlMUewEfm =wHYu -----END PGP SIGNATURE----- --=-/nahpEmiXKEsc0sPU5bi-- --===============5968602999369145885== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y Zy94ZW4tZGV2ZWwK --===============5968602999369145885==--