On Fri, 2016-03-18 at 01:39 -0600, Jan Beulich wrote: > >  > > > > On 17.03.16 at 21:42, wrote: > > On Thu, Mar 17, 2016 at 5:03 AM, Dario Faggioli > > wrote: > > >  > > > I'd say that, in this specific case, is not a big deal which one > > > of the > > > two approaches you take (mentioning or separate patch), but the > > > having > > > a separate one is indeed almost always preferable (e.g., the fix > > > can be > > > backported). > > If I choose mentioning, do I move the comment to the changelog? Or > > do I keep > > it here and say it again in the changelog? > Just consider what would happen if everyone mentioned in > comments the bugs they fixed. I think the answer to you question > is obvious then... > Exactly! :-) And, please (Chong), let me restate this: "having a separate one is indeed almost always preferable (e.g., the fix can be backported)" Regards, Dario -- <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)