From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH v8 1/3] VT-d: Reduce spin timeout to 1ms,
 which can be boot-time changed
Date: Thu, 24 Mar 2016 12:04:29 +0100
Message-ID: <1458817469.5082.14.camel@citrix.com>
References: <1458799079-79825-1-git-send-email-quan.xu@intel.com>
 <1458799079-79825-3-git-send-email-quan.xu@intel.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6728257167534509696=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1458799079-79825-3-git-send-email-quan.xu@intel.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xen.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xen.org>
To: Quan Xu <quan.xu@intel.com>, xen-devel@lists.xen.org
Cc: kevin.tian@intel.com, feng.wu@intel.com, jbeulich@suse.com
List-Id: xen-devel@lists.xenproject.org

--===============6728257167534509696==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-1vfArgiZcdvwbzrRcWaR"

--=-1vfArgiZcdvwbzrRcWaR
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, 2016-03-24 at 13:57 +0800, Quan Xu wrote:
>=C2=A0
> --- a/docs/misc/xen-command-line.markdown
> +++ b/docs/misc/xen-command-line.markdown
> @@ -1532,6 +1532,13 @@ Note that if **watchdog** option is also
> specified vpmu will be turned off.
> =C2=A0As the virtualisation is not 100% safe, don't use the vpmu flag on
> =C2=A0production systems (see http://xenbits.xen.org/xsa/advisory-163.htm=
l
> )!
> =C2=A0
> +### vtd\_qi\_timeout (VT-d)
> +> `=3D <integer>`
> +
> +> Default: `1`
> +
> +Specify the timeout of the VT-d Queued Invalidation in milliseconds.
> +
Perhaps we should put down a quick paragraph to explain what this
parameter is about, and what happens if the timeout expires?

Giving hints on under what conditions one should change this value
would be even more welcome (e.g. "if you see error XXX, try increasing
the timeout to nnn").

> --- a/xen/drivers/passthrough/vtd/qinval.c
> +++ b/xen/drivers/passthrough/vtd/qinval.c
>=C2=A0
> @@ -130,10 +135,10 @@ static void queue_invalidate_iotlb(struct iommu
>=20
> *iommu,
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0spin_unlock_irqrestore(&iommu->register_loc=
k, flags);
> =C2=A0}
> =C2=A0
> -static int queue_invalidate_wait(struct iommu *iommu,
> +static int __must_check queue_invalidate_wait(struct iommu *iommu,
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0u8 iflag, u8 sw, u8 fn)
> =C2=A0{
>
I'm not sure it is ok to add the __must_check annotation here in this
patch, considering that the subject says "VT-d: Reduce spin timeout to
1ms, which can be boot-time changed", and there is no changelog.

Personally, I think it could be ok, but at least add a few words of
changelog, mentioning that this is also being done.

Regards,
Dario
--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-1vfArgiZcdvwbzrRcWaR
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEABECAAYFAlbzyb0ACgkQk4XaBE3IOsSSHgCgqDk/4J2Q2FjSlYUGKgnxPg9M
/SsAn1LnereMpb7mCaGe0CIwd7vt7nFQ
=Yjkg
-----END PGP SIGNATURE-----

--=-1vfArgiZcdvwbzrRcWaR--


--===============6728257167534509696==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs
IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y
Zy94ZW4tZGV2ZWwK

--===============6728257167534509696==--