From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH v8 3/3] VT-d: Fix vt-d Device-TLB flush
 timeout issue
Date: Thu, 24 Mar 2016 16:38:05 +0100
Message-ID: <1458833885.5082.51.camel@citrix.com>
References: <1458799079-79825-1-git-send-email-quan.xu@intel.com>
 <1458799079-79825-4-git-send-email-quan.xu@intel.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1227259852466533386=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1458799079-79825-4-git-send-email-quan.xu@intel.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xen.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xen.org>
To: Quan Xu <quan.xu@intel.com>, xen-devel@lists.xen.org
Cc: kevin.tian@intel.com, feng.wu@intel.com, jbeulich@suse.com
List-Id: xen-devel@lists.xenproject.org

--===============1227259852466533386==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-V4ftbJbrfdSyzembEYCN"

--=-V4ftbJbrfdSyzembEYCN
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, 2016-03-24 at 13:57 +0800, Quan Xu wrote:
> If Device-TLB flush timed out, we would hide the target ATS
> device and crash the domain owning this ATS device. If impacted
> domain is hardware domain, just throw out a warning.
>=20
> The hidden device should be disallowed to be further assigned
> to any domain.
>=20
What is "should be disallowed" supposed to mean here? Isn't the
situation that, by hiding the device, which this patch is doing, we
actually disallow any further assignment?

If yes, this should rather be (something like):

"By hiding the device, we make sure it can't be assigned to any domain
any longer."

Other than this, the patch looks good to me, but I'll re-review it when
the new version comes out (with the other patches from the preliminary
series folded in), before saying Reviewed-by.

Regards,
Dario
--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-V4ftbJbrfdSyzembEYCN
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEABECAAYFAlb0Cd0ACgkQk4XaBE3IOsSkbwCffg0fGxvLIlLLHN/36DU/tAgI
rpwAn3AqjwtlpV85rLemX7mvN/2jgC50
=TUnJ
-----END PGP SIGNATURE-----

--=-V4ftbJbrfdSyzembEYCN--


--===============1227259852466533386==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs
IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y
Zy94ZW4tZGV2ZWwK

--===============1227259852466533386==--