From: Dario Faggioli <dario.faggioli@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>, Chong Li <lichong659@gmail.com>
Cc: Chong Li <chong.li@wustl.edu>, Sisu Xi <xisisu@gmail.com>,
george.dunlap@eu.citrix.com, xen-devel@lists.xen.org,
Meng Xu <mengxu@cis.upenn.edu>,
dgolomb@seas.upenn.edu
Subject: Re: [PATCH v8 for Xen 4.7 4/4] xl: enable per-VCPU parameter for RTDS
Date: Thu, 31 Mar 2016 19:22:31 +0200 [thread overview]
Message-ID: <1459444951.5082.208.camel@citrix.com> (raw)
In-Reply-To: <20160331170048.GP18437@citrix.com>
[-- Attachment #1.1: Type: text/plain, Size: 1495 bytes --]
On Thu, 2016-03-31 at 18:00 +0100, Wei Liu wrote:
> On Fri, Mar 18, 2016 at 04:26:25PM -0500, Chong Li wrote:
> >
> > Change main_sched_rtds and related output functions to support
> > per-VCPU settings.
> >
> > Signed-off-by: Chong Li <chong.li@wustl.edu>
> > Signed-off-by: Meng Xu <mengxu@cis.upenn.edu>
> > Signed-off-by: Sisu Xi <xisisu@gmail.com>
> >
> > ---
> > Changes on PATCH v7:
> > 1) Add example to xl.pod.1
> >
> So you've added what I asked. I'm satisfied with this patch.
>
> Subject to ack or review by Dario:
>
> Acked-by: Wei Liu <wei.liu2@citrix.com>
>
Here I am. I had a look (and sorry if it took a bit), and I indeed
found what I believe are a few issues.
The re-wording of the examples in the manual page are improvements IMO
(although I'm not a native speaker myself), but, much more important,
I've seen things in the code that I think need changing.
Nothing too complicated to do, I think, but still something.
So, Wei, perhaps you can give a quick look at my comments and say
whether you think my observations make any sense? If they do, and if
Chong respins the series, I guarantee I'll be much quicker in re-
reviewing it. :-)
Thanks and Regards,
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-03-31 17:22 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-18 21:26 [PATCH v8 for Xen 4.7 0/4] Enable per-VCPU parameter for RTDS Chong Li
2016-03-18 21:26 ` [PATCH v8 for Xen 4.7 1/4] xen: enable " Chong Li
2016-03-21 13:35 ` Jan Beulich
2016-03-21 15:18 ` Chong Li
2016-03-21 15:39 ` George Dunlap
2016-03-21 15:49 ` Jan Beulich
2016-03-21 16:03 ` Chong Li
2016-03-21 16:25 ` Jan Beulich
2016-03-25 18:07 ` Chong Li
2016-03-29 10:58 ` Dario Faggioli
2016-03-29 16:59 ` Dario Faggioli
2016-03-29 17:13 ` Konrad Rzeszutek Wilk
2016-03-29 17:36 ` Dario Faggioli
2016-03-18 21:26 ` [PATCH v8 for Xen 4.7 2/4] libxc: " Chong Li
2016-03-29 17:08 ` Dario Faggioli
2016-03-31 16:59 ` Wei Liu
2016-03-18 21:26 ` [PATCH v8 for Xen 4.7 3/4] libxl: " Chong Li
2016-03-30 17:04 ` Dario Faggioli
2016-03-31 16:59 ` Wei Liu
2016-03-18 21:26 ` [PATCH v8 for Xen 4.7 4/4] xl: " Chong Li
2016-03-31 17:00 ` Wei Liu
2016-03-31 17:22 ` Dario Faggioli [this message]
2016-03-31 17:17 ` Dario Faggioli
2016-03-31 20:16 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459444951.5082.208.camel@citrix.com \
--to=dario.faggioli@citrix.com \
--cc=chong.li@wustl.edu \
--cc=dgolomb@seas.upenn.edu \
--cc=george.dunlap@eu.citrix.com \
--cc=lichong659@gmail.com \
--cc=mengxu@cis.upenn.edu \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
--cc=xisisu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).