From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH v8 for Xen 4.7 4/4] xl: enable per-VCPU
 parameter for RTDS
Date: Thu, 31 Mar 2016 19:22:31 +0200
Message-ID: <1459444951.5082.208.camel@citrix.com>
References: <1458336385-2606-1-git-send-email-lichong659@gmail.com>
 <1458336385-2606-5-git-send-email-lichong659@gmail.com>
 <20160331170048.GP18437@citrix.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4530041031171134343=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20160331170048.GP18437@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xen.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xen.org>
To: Wei Liu <wei.liu2@citrix.com>, Chong Li <lichong659@gmail.com>
Cc: Chong Li <chong.li@wustl.edu>, Sisu Xi <xisisu@gmail.com>, george.dunlap@eu.citrix.com, xen-devel@lists.xen.org, Meng Xu <mengxu@cis.upenn.edu>, dgolomb@seas.upenn.edu
List-Id: xen-devel@lists.xenproject.org

--===============4530041031171134343==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-GX2HCwxJjgbgPJgBHd8h"

--=-GX2HCwxJjgbgPJgBHd8h
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, 2016-03-31 at 18:00 +0100, Wei Liu wrote:
> On Fri, Mar 18, 2016 at 04:26:25PM -0500, Chong Li wrote:
> >=20
> > Change main_sched_rtds and related output functions to support
> > per-VCPU settings.
> >=20
> > Signed-off-by: Chong Li <chong.li@wustl.edu>
> > Signed-off-by: Meng Xu <mengxu@cis.upenn.edu>
> > Signed-off-by: Sisu Xi <xisisu@gmail.com>
> >=20
> > ---
> > Changes on PATCH v7:
> > 1) Add example to xl.pod.1
> >=20
> So you've added what I asked. I'm satisfied with this patch.
>=20
> Subject to ack or review by Dario:
>=20
> =C2=A0 Acked-by: Wei Liu <wei.liu2@citrix.com>
>=20
Here I am. I had a look (and sorry if it took a bit), and I indeed
found what I believe are a few issues.

The re-wording of the examples in the manual page are improvements IMO
(although I'm not a native speaker myself), but, much more important,
I've seen things in the code that I think need changing.

Nothing too complicated to do, I think, but still something.

So, Wei, perhaps you can give a quick look at my comments and say
whether you think my observations make any sense? If they do, and if
Chong respins the series, I guarantee I'll be much quicker in re-
reviewing it. :-)

Thanks and Regards,
Dario
--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-GX2HCwxJjgbgPJgBHd8h
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEABECAAYFAlb9XNcACgkQk4XaBE3IOsQv4ACfRElqZ+mXPIV9rgeJIDltpoG7
XLIAnRUtOqtFRDp0ufu8gI6hctRc7aVx
=aqAX
-----END PGP SIGNATURE-----

--=-GX2HCwxJjgbgPJgBHd8h--


--===============4530041031171134343==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs
IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y
Zy94ZW4tZGV2ZWwK

--===============4530041031171134343==--