[PATCH] Fixed --enable-systemd on latest Debian stretch. Added xencommons as a systemd.service.

[PATCH] Fixed --enable-systemd on latest Debian stretch. Added xencommons as a systemd.service.

[Sjoer van der Ploeg]

Signed-off by: Sjoer van der Ploeg <sfjuocekr@gmail.com>
---
 m4/systemd.m4                                     | 15 +++++++++------
 tools/configure.ac                                |  1 +
 tools/hotplug/Linux/systemd/xencommons.service.in | 13 +++++++++++++
 3 files changed, 23 insertions(+), 6 deletions(-)
 create mode 100644 tools/hotplug/Linux/systemd/xencommons.service.in

diff --git a/m4/systemd.m4 b/m4/systemd.m4
index e4b1aa5..8b86c20 100644
--- a/m4/systemd.m4
+++ b/m4/systemd.m4
@@ -41,7 +41,9 @@ AC_DEFUN([AX_ALLOW_SYSTEMD_OPTS], [
 ])
 
 AC_DEFUN([AX_CHECK_SYSTEMD_LIBS], [
-	PKG_CHECK_MODULES([SYSTEMD], [libsystemd-daemon])
+	PKG_CHECK_MODULES([SYSTEMD], [libsystemd-daemon],, [
+		PKG_CHECK_MODULES([SYSTEMD], [libsystemd])
+	])
 	dnl pkg-config older than 0.24 does not set these for
 	dnl PKG_CHECK_MODULES() worth also noting is that as of version 208
 	dnl of systemd pkg-config --cflags currently yields no extra flags yet.
@@ -83,19 +85,20 @@ AC_DEFUN([AX_CHECK_SYSTEMD], [
 	AS_IF([test "x$enable_systemd" != "xno"], [
 	     AS_IF([test "x$systemd" = "xy" ], [
 		AC_DEFINE([HAVE_SYSTEMD], [1], [Systemd available and enabled])
-			systemd=y
+			systemd="y"
 			AX_CHECK_SYSTEMD_LIBS()
 	    ],[
 		AS_IF([test "x$enable_systemd" = "xyes"],
 			[AC_MSG_ERROR([Unable to find systemd development library])],
-			[systemd=n])
+			[systemd="n"])
 	    ])
-	],[systemd=n])
+	],[systemd="n"])
 ])
 
 AC_DEFUN([AX_CHECK_SYSTEMD_ENABLE_AVAILABLE], [
-	PKG_CHECK_MODULES([SYSTEMD], [libsystemd-daemon], [systemd="y"],
-                          [systemd="n"])
+	PKG_CHECK_MODULES([SYSTEMD], [libsystemd-daemon], [systemd="y"], [
+		PKG_CHECK_MODULES([SYSTEMD], [libsystemd], [systemd="y"], [systemd="n"])
+	])
 ])
 
 dnl Enables systemd by default and requires a --disable-systemd option flag
diff --git a/tools/configure.ac b/tools/configure.ac
index 5b5dda4..be124f6 100644
--- a/tools/configure.ac
+++ b/tools/configure.ac
@@ -432,6 +432,7 @@ AS_IF([test "x$systemd" = "xy"], [
     hotplug/Linux/systemd/xen-init-dom0.service
     hotplug/Linux/systemd/xen-qemu-dom0-disk-backend.service
     hotplug/Linux/systemd/xen-watchdog.service
+    hotplug/Linux/systemd/xencommons.service
     hotplug/Linux/systemd/xenconsoled.service
     hotplug/Linux/systemd/xendomains.service
     hotplug/Linux/systemd/xenstored.service
diff --git a/tools/hotplug/Linux/systemd/xencommons.service.in b/tools/hotplug/Linux/systemd/xencommons.service.in
new file mode 100644
index 0000000..c1fbf8b
--- /dev/null
+++ b/tools/hotplug/Linux/systemd/xencommons.service.in
@@ -0,0 +1,13 @@
+[Unit]
+Description=Xencommons - handles loading requiered modules
+ConditionPathExists=/proc/xen
+
+[Service]
+Type=oneshot
+RemainAfterExit=true
+ExecStartPre=/bin/grep -q control_d /proc/xen/capabilities
+ExecStart=@CONFIG_DIR@/init.d/xencommons start
+ExecStop=@CONFIG_DIR@/init.d/xencommons stop
+
+[Install]
+WantedBy=multi-user.target
-- 
2.8.0.rc3


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [PATCH] Fixed --enable-systemd on latest Debian stretch. Added xencommons as a systemd.service.

[Wei Liu]

Hello

On Thu, Mar 31, 2016 at 10:35:25PM +0200, Sjoer van der Ploeg wrote:
> Signed-off by: Sjoer van der Ploeg <sfjuocekr@gmail.com>
> ---
>  m4/systemd.m4                                     | 15 +++++++++------
>  tools/configure.ac                                |  1 +
>  tools/hotplug/Linux/systemd/xencommons.service.in | 13 +++++++++++++
>  3 files changed, 23 insertions(+), 6 deletions(-)
>  create mode 100644 tools/hotplug/Linux/systemd/xencommons.service.in
> 
> diff --git a/m4/systemd.m4 b/m4/systemd.m4
> index e4b1aa5..8b86c20 100644
> --- a/m4/systemd.m4
> +++ b/m4/systemd.m4
> @@ -41,7 +41,9 @@ AC_DEFUN([AX_ALLOW_SYSTEMD_OPTS], [
>  ])
>  
>  AC_DEFUN([AX_CHECK_SYSTEMD_LIBS], [
> -	PKG_CHECK_MODULES([SYSTEMD], [libsystemd-daemon])
> +	PKG_CHECK_MODULES([SYSTEMD], [libsystemd-daemon],, [
> +		PKG_CHECK_MODULES([SYSTEMD], [libsystemd])
> +	])
>  	dnl pkg-config older than 0.24 does not set these for
>  	dnl PKG_CHECK_MODULES() worth also noting is that as of version 208
>  	dnl of systemd pkg-config --cflags currently yields no extra flags yet.
> @@ -83,19 +85,20 @@ AC_DEFUN([AX_CHECK_SYSTEMD], [
>  	AS_IF([test "x$enable_systemd" != "xno"], [
>  	     AS_IF([test "x$systemd" = "xy" ], [
>  		AC_DEFINE([HAVE_SYSTEMD], [1], [Systemd available and enabled])
> -			systemd=y
> +			systemd="y"

I don't think quotation is needed.

>  			AX_CHECK_SYSTEMD_LIBS()
>  	    ],[
>  		AS_IF([test "x$enable_systemd" = "xyes"],
>  			[AC_MSG_ERROR([Unable to find systemd development library])],
> -			[systemd=n])
> +			[systemd="n"])
>  	    ])
> -	],[systemd=n])
> +	],[systemd="n"])
>  ])
>  
>  AC_DEFUN([AX_CHECK_SYSTEMD_ENABLE_AVAILABLE], [
> -	PKG_CHECK_MODULES([SYSTEMD], [libsystemd-daemon], [systemd="y"],
> -                          [systemd="n"])
> +	PKG_CHECK_MODULES([SYSTEMD], [libsystemd-daemon], [systemd="y"], [
> +		PKG_CHECK_MODULES([SYSTEMD], [libsystemd], [systemd="y"], [systemd="n"])

And this is because stretch now has libsystemd instead of
libsystemd-daemon?

I'm just trying to understand the issue here. Your commit message is too
terse.

> +	])
>  ])
>  
>  dnl Enables systemd by default and requires a --disable-systemd option flag
> diff --git a/tools/configure.ac b/tools/configure.ac
> index 5b5dda4..be124f6 100644
> --- a/tools/configure.ac
> +++ b/tools/configure.ac
> @@ -432,6 +432,7 @@ AS_IF([test "x$systemd" = "xy"], [
>      hotplug/Linux/systemd/xen-init-dom0.service
>      hotplug/Linux/systemd/xen-qemu-dom0-disk-backend.service
>      hotplug/Linux/systemd/xen-watchdog.service
> +    hotplug/Linux/systemd/xencommons.service
>      hotplug/Linux/systemd/xenconsoled.service
>      hotplug/Linux/systemd/xendomains.service
>      hotplug/Linux/systemd/xenstored.service
> diff --git a/tools/hotplug/Linux/systemd/xencommons.service.in b/tools/hotplug/Linux/systemd/xencommons.service.in
> new file mode 100644
> index 0000000..c1fbf8b
> --- /dev/null
> +++ b/tools/hotplug/Linux/systemd/xencommons.service.in
> @@ -0,0 +1,13 @@
> +[Unit]
> +Description=Xencommons - handles loading requiered modules
> +ConditionPathExists=/proc/xen
> +
> +[Service]
> +Type=oneshot
> +RemainAfterExit=true
> +ExecStartPre=/bin/grep -q control_d /proc/xen/capabilities
> +ExecStart=@CONFIG_DIR@/init.d/xencommons start
> +ExecStop=@CONFIG_DIR@/init.d/xencommons stop
> +

Probably not this. We already have discrete service files for systemd.
How is that broken for you?

Wei.

> +[Install]
> +WantedBy=multi-user.target
> -- 
> 2.8.0.rc3
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [PATCH] Fixed --enable-systemd on latest Debian stretch. Added xencommons as a systemd.service.

[Wei Liu]

Add back xen-devel

On Fri, Apr 01, 2016 at 05:35:17PM +0200, Sjoer van der Ploeg wrote:
> Hello,
> 
> Indeed, quotation is not needed inside the AC_DEFINE block. I had already
> fixed that in my own branch as I also had forgotten to run autogen.sh, plus
> forgotten to add a few other (efi related) checks in the Makefile that I
> added on my testbed.
> 
> I added the xencommons systemd service so xendomains would not bail out on
> a clean install, check it for yourself make install on a fresh base (I
> picked Stretch), xendomains fails to start and it traces back to xencommons
> not starting on systemd only systems.
> 

The sysv init script for xendomains depends on xenstored and
xenconsoled, and the systemd service file contains the same
dependencies.

It would be useful to track down which service is not started and
explicitly provide the dependency.

> The added libsystemd check is because in newer libsystemd there is no
> separate libsystemd-daemon anymore.
> 

OK, this needs to be fixed.

Wei.

> I test on Debian Stretch, but use Gentoo personally.
> 
> Yours,
> 
> Sjoer van der Ploeg
> On Apr 1, 2016 5:16 PM, "Wei Liu" <wei.liu2@citrix.com> wrote:
> 
> > Hello
> >
> > On Thu, Mar 31, 2016 at 10:35:25PM +0200, Sjoer van der Ploeg wrote:
> > > Signed-off by: Sjoer van der Ploeg <sfjuocekr@gmail.com>
> > > ---
> > >  m4/systemd.m4                                     | 15 +++++++++------
> > >  tools/configure.ac                                |  1 +
> > >  tools/hotplug/Linux/systemd/xencommons.service.in | 13 +++++++++++++
> > >  3 files changed, 23 insertions(+), 6 deletions(-)
> > >  create mode 100644 tools/hotplug/Linux/systemd/xencommons.service.in
> > >
> > > diff --git a/m4/systemd.m4 b/m4/systemd.m4
> > > index e4b1aa5..8b86c20 100644
> > > --- a/m4/systemd.m4
> > > +++ b/m4/systemd.m4
> > > @@ -41,7 +41,9 @@ AC_DEFUN([AX_ALLOW_SYSTEMD_OPTS], [
> > >  ])
> > >
> > >  AC_DEFUN([AX_CHECK_SYSTEMD_LIBS], [
> > > -     PKG_CHECK_MODULES([SYSTEMD], [libsystemd-daemon])
> > > +     PKG_CHECK_MODULES([SYSTEMD], [libsystemd-daemon],, [
> > > +             PKG_CHECK_MODULES([SYSTEMD], [libsystemd])
> > > +     ])
> > >       dnl pkg-config older than 0.24 does not set these for
> > >       dnl PKG_CHECK_MODULES() worth also noting is that as of version 208
> > >       dnl of systemd pkg-config --cflags currently yields no extra flags
> > yet.
> > > @@ -83,19 +85,20 @@ AC_DEFUN([AX_CHECK_SYSTEMD], [
> > >       AS_IF([test "x$enable_systemd" != "xno"], [
> > >            AS_IF([test "x$systemd" = "xy" ], [
> > >               AC_DEFINE([HAVE_SYSTEMD], [1], [Systemd available and
> > enabled])
> > > -                     systemd=y
> > > +                     systemd="y"
> >
> > I don't think quotation is needed.
> >
> > >                       AX_CHECK_SYSTEMD_LIBS()
> > >           ],[
> > >               AS_IF([test "x$enable_systemd" = "xyes"],
> > >                       [AC_MSG_ERROR([Unable to find systemd development
> > library])],
> > > -                     [systemd=n])
> > > +                     [systemd="n"])
> > >           ])
> > > -     ],[systemd=n])
> > > +     ],[systemd="n"])
> > >  ])
> > >
> > >  AC_DEFUN([AX_CHECK_SYSTEMD_ENABLE_AVAILABLE], [
> > > -     PKG_CHECK_MODULES([SYSTEMD], [libsystemd-daemon], [systemd="y"],
> > > -                          [systemd="n"])
> > > +     PKG_CHECK_MODULES([SYSTEMD], [libsystemd-daemon], [systemd="y"], [
> > > +             PKG_CHECK_MODULES([SYSTEMD], [libsystemd], [systemd="y"],
> > [systemd="n"])
> >
> > And this is because stretch now has libsystemd instead of
> > libsystemd-daemon?
> >
> > I'm just trying to understand the issue here. Your commit message is too
> > terse.
> >
> > > +     ])
> > >  ])
> > >
> > >  dnl Enables systemd by default and requires a --disable-systemd option
> > flag
> > > diff --git a/tools/configure.ac b/tools/configure.ac
> > > index 5b5dda4..be124f6 100644
> > > --- a/tools/configure.ac
> > > +++ b/tools/configure.ac
> > > @@ -432,6 +432,7 @@ AS_IF([test "x$systemd" = "xy"], [
> > >      hotplug/Linux/systemd/xen-init-dom0.service
> > >      hotplug/Linux/systemd/xen-qemu-dom0-disk-backend.service
> > >      hotplug/Linux/systemd/xen-watchdog.service
> > > +    hotplug/Linux/systemd/xencommons.service
> > >      hotplug/Linux/systemd/xenconsoled.service
> > >      hotplug/Linux/systemd/xendomains.service
> > >      hotplug/Linux/systemd/xenstored.service
> > > diff --git a/tools/hotplug/Linux/systemd/xencommons.service.in
> > b/tools/hotplug/Linux/systemd/xencommons.service.in
> > > new file mode 100644
> > > index 0000000..c1fbf8b
> > > --- /dev/null
> > > +++ b/tools/hotplug/Linux/systemd/xencommons.service.in
> > > @@ -0,0 +1,13 @@
> > > +[Unit]
> > > +Description=Xencommons - handles loading requiered modules
> > > +ConditionPathExists=/proc/xen
> > > +
> > > +[Service]
> > > +Type=oneshot
> > > +RemainAfterExit=true
> > > +ExecStartPre=/bin/grep -q control_d /proc/xen/capabilities
> > > +ExecStart=@CONFIG_DIR@/init.d/xencommons start
> > > +ExecStop=@CONFIG_DIR@/init.d/xencommons stop
> > > +
> >
> > Probably not this. We already have discrete service files for systemd.
> > How is that broken for you?
> >
> > Wei.
> >
> > > +[Install]
> > > +WantedBy=multi-user.target
> > > --
> > > 2.8.0.rc3
> > >
> > >
> > > _______________________________________________
> > > Xen-devel mailing list
> > > Xen-devel@lists.xen.org
> > > http://lists.xen.org/xen-devel
> >

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [PATCH] Fixed --enable-systemd on latest Debian stretch. Added xencommons as a systemd.service.

[Wei Liu]

Add back xen-devel

Please use the "reply-all" button in gmail in the future.

On Fri, Apr 01, 2016 at 06:48:47PM +0200, Sjoer van der Ploeg wrote:
> > The sysv init script for xendomains depends on xenstored and
> > xenconsoled, and the systemd service file contains the same
> > dependencies.
> >
> > It would be useful to track down which service is not started and
> > explicitly provide the dependency.
> 
> Manually enabling xencommons through update-rc.d also works, to put it like
> this the xendomains fails to start because was xencommons was not
> enabled/started. The error xendomains gave back only complained about
> xenstored and xenconsoled.
> 
> What actually happened is that the required modules were never loaded on
> dom0 (causing numerous other unrelated problems), adding the systemd
> service fixed that instead of having to manually enable xencommons with
> update-rd.d (which is not the systemd workflow anyway). Scratching your
> head as to why xendomains complains about two services that have in fact
> been enabled and loaded when a sysv init.d script is the actual cause, was
> not my first thought.
> 
> On that note xendomains should state xencommons dependency, which it
> currently does not.
> 

Ah, so it is the kernel modules that are not loaded. I can see why that
would be a problem. My experience with systemd is a bit rusty at the
moment. I will find some time to have a look at this next week.

Wei.

> 
> Yours,
> 
> Sjoer van der Ploeg
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [PATCH] Fixed --enable-systemd on latest Debian stretch. Added xencommons as a systemd.service.

[Sjoer van der Ploeg]

[-- Attachment #1.1: Type: text/plain, Size: 1841 bytes --]

Ah sorry, forgot the reply all!

My personal Gentoo based system is systemd only, testing on Debian lead me
to sysv.

There is also a typo in the description for the service, my bad.


Yours,

Sjoer van der Ploeg

On Fri, Apr 1, 2016 at 7:01 PM, Wei Liu <wei.liu2@citrix.com> wrote:

> Add back xen-devel
>
> Please use the "reply-all" button in gmail in the future.
>
> On Fri, Apr 01, 2016 at 06:48:47PM +0200, Sjoer van der Ploeg wrote:
> > > The sysv init script for xendomains depends on xenstored and
> > > xenconsoled, and the systemd service file contains the same
> > > dependencies.
> > >
> > > It would be useful to track down which service is not started and
> > > explicitly provide the dependency.
> >
> > Manually enabling xencommons through update-rc.d also works, to put it
> like
> > this the xendomains fails to start because was xencommons was not
> > enabled/started. The error xendomains gave back only complained about
> > xenstored and xenconsoled.
> >
> > What actually happened is that the required modules were never loaded on
> > dom0 (causing numerous other unrelated problems), adding the systemd
> > service fixed that instead of having to manually enable xencommons with
> > update-rd.d (which is not the systemd workflow anyway). Scratching your
> > head as to why xendomains complains about two services that have in fact
> > been enabled and loaded when a sysv init.d script is the actual cause,
> was
> > not my first thought.
> >
> > On that note xendomains should state xencommons dependency, which it
> > currently does not.
> >
>
> Ah, so it is the kernel modules that are not loaded. I can see why that
> would be a problem. My experience with systemd is a bit rusty at the
> moment. I will find some time to have a look at this next week.
>
> Wei.
>
> >
> > Yours,
> >
> > Sjoer van der Ploeg
> >
>

[-- Attachment #1.2: Type: text/html, Size: 2480 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [PATCH] Fixed --enable-systemd on latest Debian stretch. Added xencommons as a systemd.service.

[Olaf Hering]

On Fri, Apr 01, Wei Liu wrote:

> Ah, so it is the kernel modules that are not loaded. I can see why that
> would be a problem. My experience with systemd is a bit rusty at the
> moment. I will find some time to have a look at this next week.

They get loaded via the system-modules-load.service, perhaps that one is
disabled.

Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [PATCH] Fixed --enable-systemd on latest Debian stretch. Added xencommons as a systemd.service.

[Sjoer van der Ploeg]

[-- Attachment #1.1: Type: text/plain, Size: 882 bytes --]

Just finished a fresh testbed, xendomains still refused to get enabled when
using --prefix=/usr and modules did load.

Took a look at /usr/local (which was non-existent before make install),
ocaml dumped its files there in /usr/local/lib and after moving that
directory into /usr/lib I could systemctl enable xendomains without an
error!

I'll double check it over the weekend to confirm the issue, find the exact
cause and submit a fix.

Yours,

Sjoer van der Ploeg
On Apr 1, 2016 9:43 PM, "Olaf Hering" <olaf@aepfle.de> wrote:

> On Fri, Apr 01, Wei Liu wrote:
>
> > Ah, so it is the kernel modules that are not loaded. I can see why that
> > would be a problem. My experience with systemd is a bit rusty at the
> > moment. I will find some time to have a look at this next week.
>
> They get loaded via the system-modules-load.service, perhaps that one is
> disabled.
>
> Olaf
>

[-- Attachment #1.2: Type: text/html, Size: 1237 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [PATCH] Fixed --enable-systemd on latest Debian stretch. Added xencommons as a systemd.service.

[Wei Liu]

On Sat, Apr 02, 2016 at 02:45:41AM +0200, Sjoer van der Ploeg wrote:
> Just finished a fresh testbed, xendomains still refused to get enabled when
> using --prefix=/usr and modules did load.
> 
> Took a look at /usr/local (which was non-existent before make install),
> ocaml dumped its files there in /usr/local/lib and after moving that
> directory into /usr/lib I could systemctl enable xendomains without an
> error!
> 
> I'll double check it over the weekend to confirm the issue, find the exact
> cause and submit a fix.
> 

Did you perhaps use ocaml xenstored implementation? Then there might be
a problem with its install target.

The ocaml tools are under tools/ocaml directory if you want to check.

Wei.

> Yours,
> 
> Sjoer van der Ploeg
> On Apr 1, 2016 9:43 PM, "Olaf Hering" <olaf@aepfle.de> wrote:
> 
> > On Fri, Apr 01, Wei Liu wrote:
> >
> > > Ah, so it is the kernel modules that are not loaded. I can see why that
> > > would be a problem. My experience with systemd is a bit rusty at the
> > > moment. I will find some time to have a look at this next week.
> >
> > They get loaded via the system-modules-load.service, perhaps that one is
> > disabled.
> >
> > Olaf
> >

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [PATCH] Fixed --enable-systemd on latest Debian stretch. Added xencommons as a systemd.service.

[Wei Liu]

On Sat, Apr 02, 2016 at 11:59:47AM +0100, Wei Liu wrote:
> On Sat, Apr 02, 2016 at 02:45:41AM +0200, Sjoer van der Ploeg wrote:
> > Just finished a fresh testbed, xendomains still refused to get enabled when
> > using --prefix=/usr and modules did load.
> > 
> > Took a look at /usr/local (which was non-existent before make install),
> > ocaml dumped its files there in /usr/local/lib and after moving that
> > directory into /usr/lib I could systemctl enable xendomains without an
> > error!
> > 
> > I'll double check it over the weekend to confirm the issue, find the exact
> > cause and submit a fix.
> > 
> 
> Did you perhaps use ocaml xenstored implementation? Then there might be
> a problem with its install target.
> 
> The ocaml tools are under tools/ocaml directory if you want to check.
> 

Actually my quick run in xen.git

  ./configure --prefix=/usr && make dist
 
doesn't show a local directory under dist/install/usr .

So if you're using Debian package you might also need to check debian
control files.

Wei.

> Wei.
> 
> > Yours,
> > 
> > Sjoer van der Ploeg
> > On Apr 1, 2016 9:43 PM, "Olaf Hering" <olaf@aepfle.de> wrote:
> > 
> > > On Fri, Apr 01, Wei Liu wrote:
> > >
> > > > Ah, so it is the kernel modules that are not loaded. I can see why that
> > > > would be a problem. My experience with systemd is a bit rusty at the
> > > > moment. I will find some time to have a look at this next week.
> > >
> > > They get loaded via the system-modules-load.service, perhaps that one is
> > > disabled.
> > >
> > > Olaf
> > >

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [PATCH] Fixed --enable-systemd on latest Debian stretch. Added xencommons as a systemd.service.

[Sjoer van der Ploeg]

[-- Attachment #1.1: Type: text/plain, Size: 2149 bytes --]

Well if you install ocaml-nox oxenstored is made default, so I tested both
situations this morning with and without ocaml. That location is not
causing the problem, as it happened without ocaml too. The install path for
ocaml is worth checking, as it should not default to /usr/local, after
grepping the files I found one occurrence of /usr/local
in configure:ac_default_prefix=/usr/local (requires further investigation.

Starting the xendomains systemd service manually works on a fresh install.
Enabling the xendomains systemd service does not.

After I had enabled xencommons through update-rc.d once, the systemd
service for xendomains would enable.

I am not at home over the weekend, but have remote access to the machines
at home so might test further when I get the chance.


Yours,

Sjoer van der Ploeg

On Sat, Apr 2, 2016 at 12:59 PM, Wei Liu <wei.liu2@citrix.com> wrote:

> On Sat, Apr 02, 2016 at 02:45:41AM +0200, Sjoer van der Ploeg wrote:
> > Just finished a fresh testbed, xendomains still refused to get enabled
> when
> > using --prefix=/usr and modules did load.
> >
> > Took a look at /usr/local (which was non-existent before make install),
> > ocaml dumped its files there in /usr/local/lib and after moving that
> > directory into /usr/lib I could systemctl enable xendomains without an
> > error!
> >
> > I'll double check it over the weekend to confirm the issue, find the
> exact
> > cause and submit a fix.
> >
>
> Did you perhaps use ocaml xenstored implementation? Then there might be
> a problem with its install target.
>
> The ocaml tools are under tools/ocaml directory if you want to check.
>
> Wei.
>
> > Yours,
> >
> > Sjoer van der Ploeg
> > On Apr 1, 2016 9:43 PM, "Olaf Hering" <olaf@aepfle.de> wrote:
> >
> > > On Fri, Apr 01, Wei Liu wrote:
> > >
> > > > Ah, so it is the kernel modules that are not loaded. I can see why
> that
> > > > would be a problem. My experience with systemd is a bit rusty at the
> > > > moment. I will find some time to have a look at this next week.
> > >
> > > They get loaded via the system-modules-load.service, perhaps that one
> is
> > > disabled.
> > >
> > > Olaf
> > >
>

[-- Attachment #1.2: Type: text/html, Size: 2833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [PATCH] Fixed --enable-systemd on latest Debian stretch. Added xencommons as a systemd.service.

[Wei Liu]

On Sat, Apr 02, 2016 at 01:24:07PM +0200, Sjoer van der Ploeg wrote:
> Well if you install ocaml-nox oxenstored is made default, so I tested both
> situations this morning with and without ocaml. That location is not
> causing the problem, as it happened without ocaml too. The install path for
> ocaml is worth checking, as it should not default to /usr/local, after
> grepping the files I found one occurrence of /usr/local
> in configure:ac_default_prefix=/usr/local (requires further investigation.

This is not a problem. That's the default value if you don't have
--prefix in ./configure invocation.

Could you post the exact commands you used to produce the problem?

Wei.

> 
> Starting the xendomains systemd service manually works on a fresh install.
> Enabling the xendomains systemd service does not.
> 
> After I had enabled xencommons through update-rc.d once, the systemd
> service for xendomains would enable.
> 
> I am not at home over the weekend, but have remote access to the machines
> at home so might test further when I get the chance.
> 
> 
> Yours,
> 
> Sjoer van der Ploeg
> 
> On Sat, Apr 2, 2016 at 12:59 PM, Wei Liu <wei.liu2@citrix.com> wrote:
> 
> > On Sat, Apr 02, 2016 at 02:45:41AM +0200, Sjoer van der Ploeg wrote:
> > > Just finished a fresh testbed, xendomains still refused to get enabled
> > when
> > > using --prefix=/usr and modules did load.
> > >
> > > Took a look at /usr/local (which was non-existent before make install),
> > > ocaml dumped its files there in /usr/local/lib and after moving that
> > > directory into /usr/lib I could systemctl enable xendomains without an
> > > error!
> > >
> > > I'll double check it over the weekend to confirm the issue, find the
> > exact
> > > cause and submit a fix.
> > >
> >
> > Did you perhaps use ocaml xenstored implementation? Then there might be
> > a problem with its install target.
> >
> > The ocaml tools are under tools/ocaml directory if you want to check.
> >
> > Wei.
> >
> > > Yours,
> > >
> > > Sjoer van der Ploeg
> > > On Apr 1, 2016 9:43 PM, "Olaf Hering" <olaf@aepfle.de> wrote:
> > >
> > > > On Fri, Apr 01, Wei Liu wrote:
> > > >
> > > > > Ah, so it is the kernel modules that are not loaded. I can see why
> > that
> > > > > would be a problem. My experience with systemd is a bit rusty at the
> > > > > moment. I will find some time to have a look at this next week.
> > > >
> > > > They get loaded via the system-modules-load.service, perhaps that one
> > is
> > > > disabled.
> > > >
> > > > Olaf
> > > >
> >

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [PATCH] Fixed --enable-systemd on latest Debian stretch. Added xencommons as a systemd.service.

[Wei Liu]

Add back xen-devel

On Mon, Apr 04, 2016 at 01:28:03PM +0200, Sjoer van der Ploeg wrote:
> Ocaml search path was set to /usr/local
> 
> I haven't had the time to check why xendomains fails, I've got a few
> deadlines for school to finish before Friday.
> 

No worries. Your deadlines are more important than this bug. :-)

If you can provide me the exact commands you used to fetch the
repository and build, I will have a look at this at some point.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel