From: Ian Jackson <ian.jackson@eu.citrix.com>
To: xen-devel@lists.xensource.com
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>,
Chunyan Liu <cyliu@suse.com>,
coverity@xenproject.org
Subject: [PATCH 2/2] libxl: Do not leak data on error path from libxl__read_sysfs_file_contents
Date: Mon, 4 Apr 2016 16:10:00 +0100 [thread overview]
Message-ID: <1459782600-16073-2-git-send-email-ian.jackson@eu.citrix.com> (raw)
In-Reply-To: <1459782600-16073-1-git-send-email-ian.jackson@eu.citrix.com>
Bug introduced in bc023ecd
"libxl_utils: add internal function to read sysfs file contents"
CID: 1358108
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
CC: coverity@xenproject.org
CC: Chunyan Liu <cyliu@suse.com>
---
tools/libxl/libxl_utils.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/libxl/libxl_utils.c b/tools/libxl/libxl_utils.c
index ceb8825..bd58a52 100644
--- a/tools/libxl/libxl_utils.c
+++ b/tools/libxl/libxl_utils.c
@@ -466,6 +466,7 @@ int libxl__read_sysfs_file_contents(libxl__gc *gc, const char *filename,
e = errno;
assert(e != ENOENT);
if (f) fclose(f);
+ free(data);
return e;
}
--
1.7.10.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-04-04 15:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-04 15:09 [PATCH 1/2] libxl: Set rc on failure of usbdev_busaddr_to_busid Ian Jackson
2016-04-04 15:10 ` Ian Jackson [this message]
2016-04-07 8:16 ` [PATCH 2/2] libxl: Do not leak data on error path from libxl__read_sysfs_file_contents Chun Yan Liu
2016-04-07 17:03 ` Ian Jackson
2016-04-07 8:17 ` [PATCH 1/2] libxl: Set rc on failure of usbdev_busaddr_to_busid Chun Yan Liu
2016-04-07 17:04 ` Ian Jackson
2016-04-08 3:48 ` Chun Yan Liu
2016-04-08 13:34 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459782600-16073-2-git-send-email-ian.jackson@eu.citrix.com \
--to=ian.jackson@eu.citrix.com \
--cc=coverity@xenproject.org \
--cc=cyliu@suse.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).