Re: [PATCH] xen: enable per-VCPU parameter for RTDS

From: Dario Faggioli <dario.faggioli@citrix.com>
To: George Dunlap <george.dunlap@citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Chong Li <lichong659@gmail.com>,
	xen-devel@lists.xen.org
Cc: Chong Li <chong.li@wustl.edu>, Sisu Xi <xisisu@gmail.com>,
	george.dunlap@eu.citrix.com, Meng Xu <mengxu@cis.upenn.edu>,
	jbeulich@suse.com, dgolomb@seas.upenn.edu
Subject: Re: [PATCH] xen: enable per-VCPU parameter for RTDS
Date: Tue, 5 Apr 2016 11:39:02 +0200	[thread overview]
Message-ID: <1459849142.3166.24.camel@citrix.com> (raw)
In-Reply-To: <570382D7.8010507@citrix.com>

[-- Attachment #1.1: Type: text/plain, Size: 1962 bytes --]

On Tue, 2016-04-05 at 10:18 +0100, George Dunlap wrote:
> On 05/04/16 00:14, Andrew Cooper wrote:
> > On 04/04/2016 23:45, Chong Li wrote:
> > > ---
> > >  xen/common/sched_credit.c  | 1 +
> > >  xen/common/sched_credit2.c | 1 +
> > >  2 files changed, 2 insertions(+)
> > > 
> > > diff --git a/xen/common/sched_credit.c
> > > b/xen/common/sched_credit.c
> > > index e5d15d8..fa6b7f0 100644
> > > --- a/xen/common/sched_credit.c
> > > +++ b/xen/common/sched_credit.c
> > > @@ -1101,6 +1101,7 @@ csched_dom_cntl(
> > >              sdom->cap = op->u.credit.cap;
> > >          break;
> > >      default:
> > > +        spin_unlock_irqrestore(&prv->lock, flags);
> > >          return -EINVAL;
> > >      }
> > >  
> > While Dario didn't care too much how you fixed the issue, I do.
> > 
> > Please use an "int rc = 0" and remove remove the return statement
> > (instead, assigning rc = -EINVAL; and a break;).  It makes far more
> > readable and understandable code, which is better in the long run.
>
> Well Dario's a scheduler maintainer and you're not.
> 
Eheh :-)

> But in any case, I also prefer the rc / break (or goto out) pattern
> enough to ask for a re-send.  (But I now see that a v3 has already
> been
> sent.)
> 
Yeah, I said I was ok in the event that we wanted to check in the fix
ASAP, editing the changelog during commit. If a resend were to be done,
I'd have hoped the structure to be changed as said above... I probably
should have said it more explicitly.

Impressive that we're all on the same page (at least, from a technical
point of view! :-P)

Thanks and Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel