On Tue, 2016-04-05 at 10:25 +0100, George Dunlap wrote:
> On 05/04/16 08:57, Jan Beulich wrote:
> > 
> > > Signed-off-by: Chong Li <chong.li@wustl.edu>
> > > 
> > > Acked-by: Dario Faggioli <dario.faggioli@citrix.com>
> > This appears to be the 3rd variant of the patch, all with the same
> > bogus subject, and no versioning information at all. Please
> > remember that mails can arrive out of order, so there's no way
> > to reliably tell which one got sent first. So for this to go in I'm
> > expecting you to re-send with a proper subject and an indication
> > that this is not the initial version of the patch.
> And since this version of the patch is functionally different than
> the
> one Dario acked, you should drop his Acked-by as well.
> 
Indeed you should have.

But, with the subject fixed (something like "xen: sched: fix deadlock
when changing scheduling parameters") and properly versioned, you can
add it again:

Acked-by: Dario Faggioli <dario.faggioli@citrix.com>

> Thanks for being responsive in fixing this bug; and sorry for all the
> criticism, but OSS development is very detail-oriented, and it takes
> a
> while to internalize all the rules for how things should be done.
> 
It does! :-)

Thanks and Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)