From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paulina Szubarczyk Subject: Re: [PATCH v2 09/10] libxl: Fix libxl_set_memory_target return value Date: Wed, 06 Apr 2016 15:21:21 +0200 Message-ID: <1459948881.21096.9.camel@localhost> References: <1459943163-18697-1-git-send-email-paulinaszubarczyk@gmail.com> <1459943163-18697-10-git-send-email-paulinaszubarczyk@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1annPA-0004Xl-E0 for xen-devel@lists.xenproject.org; Wed, 06 Apr 2016 13:21:56 +0000 Received: by mail-lb0-f194.google.com with SMTP id q4so3801371lbq.3 for ; Wed, 06 Apr 2016 06:21:55 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: George Dunlap Cc: Wei Liu , Ian Campbell , Dario Faggioli , Ian Jackson , xen-devel , Roger Pau =?ISO-8859-1?Q?Monn=E9?= List-Id: xen-devel@lists.xenproject.org T24gV2VkLCAyMDE2LTA0LTA2IGF0IDEzOjU0ICswMTAwLCBHZW9yZ2UgRHVubGFwIHdyb3RlOgo+ IE9uIFdlZCwgQXByIDYsIDIwMTYgYXQgMTI6NDYgUE0sIFBhdWxpbmEgU3p1YmFyY3p5awo+IDxw YXVsaW5hc3p1YmFyY3p5a0BnbWFpbC5jb20+IHdyb3RlOgo+ID4gRnJvbTogR2VvcmdlIER1bmxh cCA8R2VvcmdlLkR1bmxhcEBldS5jaXRyaXguY29tPgo+ID4KPiA+IGxpYnhsX3NldF9tZW1vcnlf dGFyZ2V0IHNlZW1zIHRvIGhhdmUgdGhlIGZvbGxvd2luZyByZXR1cm4gdmFsdWVzOgo+ID4KPiA+ ICogMSBvbiBmYWlsdXJlLCBpZiB0aGUgZmFpbHVyZSBoYXBwZW5zIGJlY2F1c2Ugb2YgYSB4ZW5z dG9yZSBlcnJvciAqb3IqCj4gPiAqIGludmFsaWQgdGFyZ2V0Cj4gPgo+ID4gKiAtMSBpZiB0aGUg c2V0bWF4bWVtIGh5cGVyY2FsbAo+ID4KPiA+ICogLWVycm5vIGlmIHRoZSBzZXRfcG9kX3Rhcmdl dCBoeXBlcmNhbGwgdGFyZ2V0IGZhaWxzCj4gPgo+ID4gKiAwIG9uIHN1Y2Nlc3MKPiA+Cj4gPiBN YWtlIGl0IGNvbnNpc3RlbnRseSByZXR1cm4gRVJST1JfRkFJTCBvbiBmYWlsdXJlLCB1bmxlc3Mg dGhlCj4gPiBwYXJhbWV0ZXJzIHdlcmUgaW52YWxpZCwgaW4gd2hpY2ggY2FzZSByZXR1cm4gRVJS T1JfSU5WQUwuCj4gPgo+ID4gSW4gYWNjb3JkYW5jZSB3aXRoIENPRElOR19TWVRMRToKPiA+Cj4g PiAxLiBMZWF2ZSByYyB1bmluaXRpYWxpemVkLCBhbmQgc2V0IHdoZW4gYW4gZXJyb3IgaXMgZGV0 ZWN0ZWQKPiA+Cj4gPiAyLiBVc2UgJ3InIGZvciByZXR1cm4gdmFsdWVzIHRvIGZ1bmN0aW9ucyB3 aG9zZSByZXR1cm4gdmFsdWVzIGFyZSBhCj4gPiBkaWZmZXJlbnQgZXJyb3Igc3BhY2UgKGxpa2Ug eGNfZG9tYWluX3NldG1heG1lbSBhbmQKPiA+IHhjX2RvbWFpbl9zZXRfcG9kX3RhcmdldCkKPiA+ Cj4gPiAtLS0KPiA+IENoYW5nZWQgc2luY2UgdjE6Cj4gPgo+ID4gMy4gVXNlICdscmMnIGZvciBy ZXR1cm4gdmFsdWVzIHRvIGxvY2FsIGZ1bmN0aW9ucyBsaWJ4bF9fKgo+ID4gd2hlcmUgYSBmYWls dXJlIG1lYW5zIHJldHJ5LCByYXRoZXIgdGhhbiBmYWlsIHRoZSB3aG9sZSBmdW5jdGlvbgo+ID4g KGxpYnhsX19maWxsX2RvbTBfbWVtb3J5X2luZm8pLCB0byByZWR1Y2UgdGhlIHJpc2sgb2YgdGhh dC4KPiA+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBHZW9yZ2UgRHVubGFwIDxHZW9yZ2UuRHVubGFwQGV1 LmNpdHJpeC5jb20+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBQYXVsaW5hIFN6dWJhcmN6eWsgPHBhdWxp bmFzenViYXJjenlrQGdtYWlsLmNvbT4KPiAKPiBGWUkgZXZlcnl0aGluZyBhZnRlciB0aGUgIi0t LSIgd2lsbCBiZSBkaXNjYXJkZWQgb24gY29tbWl0OyBzbyB5b3UKPiBuZWVkIGFsbCB0aGUgdGFn cyAoc2lnbmVkLW9mZi1ieSwgYWNrZWQtYnksICZjKSB0byBiZSBiZWZvcmUgdGhhdC4KPiAKPiAg LUdlb3JnZQo+IApJIGRpZCBub3Qga25vdyB0aGF0LiBUaGFuayB5b3UuIEkgd2FzIHN1Z2dlc3Rl ZCBieSB0aGUgd2lraSBwYWdlLAp3aGVyZSB0aGUgZXhhbXBsZSByZXNlbmQgY29tbWVudHMgc3Rh cnRzIGFmdGVyIHRoZSAiLS0tIiBidXQgCnRoZSB0YWdzIHlvdSBtZW50aW9uZWQgYXJlIGVhcmxp ZXIuIAoKQnV0IHRoYXQgY29uZnVzZWQgbWUgYSBiaXQsIHNvIGFmdGVyIHRoYXQgIi0tLSIgdGhl cmUgc2hvdWxkIGJlIGNvbW1lbnRzCmZvciByZXZpZXdlcnMgcmF0aGVyIHRoZW4gaW5mb3JtYXRp b24gYWJvdXQgY2hhbmdlcy4KClNob3VsZCBJIHJlLXNlbmQgaXQgbm93IG9yIG1heSBJIGRvIGl0 IHdpdGggdGhlIGNoYW5nZXMgYWZ0ZXIgcmV2aWV3PwoKUGF1bGluYQo+ID4gLS0tCj4gPiAgdG9v bHMvbGlieGwvbGlieGwuYyB8IDI4ICsrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0KPiA+ICAx IGZpbGUgY2hhbmdlZCwgMTggaW5zZXJ0aW9ucygrKSwgMTAgZGVsZXRpb25zKC0pCj4gPgo+ID4g ZGlmZiAtLWdpdCBhL3Rvb2xzL2xpYnhsL2xpYnhsLmMgYi90b29scy9saWJ4bC9saWJ4bC5jCj4g PiBpbmRleCA3NWYwMGJlLi4wNTczNjZlIDEwMDY0NAo+ID4gLS0tIGEvdG9vbHMvbGlieGwvbGli eGwuYwo+ID4gKysrIGIvdG9vbHMvbGlieGwvbGlieGwuYwo+ID4gQEAgLTQ4MjQsNyArNDgyNCw3 IEBAIGludCBsaWJ4bF9zZXRfbWVtb3J5X3RhcmdldChsaWJ4bF9jdHggKmN0eCwgdWludDMyX3Qg ZG9taWQsCj4gPiAgICAgICAgICBpbnQzMl90IHRhcmdldF9tZW1rYiwgaW50IHJlbGF0aXZlLCBp bnQgZW5mb3JjZSkKPiA+ICB7Cj4gPiAgICAgIEdDX0lOSVQoY3R4KTsKPiA+IC0gICAgaW50IHJj ID0gMSwgYWJvcnRfdHJhbnNhY3Rpb24gPSAwOwo+ID4gKyAgICBpbnQgcmMsIHIsIGxyYywgYWJv cnRfdHJhbnNhY3Rpb24gPSAwOwo+ID4gICAgICB1aW50NjRfdCBtZW1vcnlrYjsKPiA+ICAgICAg dWludDMyX3QgdmlkZW9yYW0gPSAwOwo+ID4gICAgICB1aW50MzJfdCBjdXJyZW50X3RhcmdldF9t ZW1rYiA9IDAsIG5ld190YXJnZXRfbWVta2IgPSAwOwo+ID4gQEAgLTQ4NTIsMTUgKzQ4NTIsMTUg QEAgcmV0cnlfdHJhbnNhY3Rpb246Cj4gPiAgICAgIGlmICghdGFyZ2V0ICYmICFkb21pZCkgewo+ ID4gICAgICAgICAgaWYgKCF4c190cmFuc2FjdGlvbl9lbmQoY3R4LT54c2gsIHQsIDEpKQo+ID4g ICAgICAgICAgICAgIGdvdG8gb3V0X25vX3RyYW5zYWN0aW9uOwo+ID4gLSAgICAgICAgcmMgPSBs aWJ4bF9fZmlsbF9kb20wX21lbW9yeV9pbmZvKGdjLCAmY3VycmVudF90YXJnZXRfbWVta2IsCj4g PiArICAgICAgICBscmMgPSBsaWJ4bF9fZmlsbF9kb20wX21lbW9yeV9pbmZvKGdjLCAmY3VycmVu dF90YXJnZXRfbWVta2IsCj4gPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgJmN1cnJlbnRfbWF4X21lbWtiKTsKPiA+IC0gICAgICAgIGlmIChyYyA8IDApCj4gPiAt ICAgICAgICAgICAgZ290byBvdXRfbm9fdHJhbnNhY3Rpb247Cj4gPiArICAgICAgICBpZiAobHJj IDwgMCkgeyByYyA9IEVSUk9SX0ZBSUw7IGdvdG8gb3V0X25vX3RyYW5zYWN0aW9uOyB9Cj4gPiAg ICAgICAgICBnb3RvIHJldHJ5X3RyYW5zYWN0aW9uOwo+ID4gICAgICB9IGVsc2UgaWYgKCF0YXJn ZXQpIHsKPiA+ICAgICAgICAgIExPR0UoRVJST1IsICJjYW5ub3QgZ2V0IHRhcmdldCBtZW1vcnkg aW5mbyBmcm9tICVzL21lbW9yeS90YXJnZXQiLAo+ID4gICAgICAgICAgICAgICBkb21wYXRoKTsK PiA+ICAgICAgICAgIGFib3J0X3RyYW5zYWN0aW9uID0gMTsKPiA+ICsgICAgICAgIHJjID0gRVJS T1JfRkFJTDsKPiA+ICAgICAgICAgIGdvdG8gb3V0Owo+ID4gICAgICB9IGVsc2Ugewo+ID4gICAg ICAgICAgY3VycmVudF90YXJnZXRfbWVta2IgPSBzdHJ0b3VsKHRhcmdldCwgJmVuZHB0ciwgMTAp Owo+ID4gQEAgLTQ4NjgsNiArNDg2OCw3IEBAIHJldHJ5X3RyYW5zYWN0aW9uOgo+ID4gICAgICAg ICAgICAgIExPR0UoRVJST1IsICJpbnZhbGlkIG1lbW9yeSB0YXJnZXQgJXMgZnJvbSAlcy9tZW1v cnkvdGFyZ2V0XG4iLAo+ID4gICAgICAgICAgICAgICAgICAgdGFyZ2V0LCBkb21wYXRoKTsKPiA+ ICAgICAgICAgICAgICBhYm9ydF90cmFuc2FjdGlvbiA9IDE7Cj4gPiArICAgICAgICAgICAgcmMg PSBFUlJPUl9GQUlMOwo+ID4gICAgICAgICAgICAgIGdvdG8gb3V0Owo+ID4gICAgICAgICAgfQo+ ID4gICAgICB9Cj4gPiBAQCAtNDg3Niw2ICs0ODc3LDcgQEAgcmV0cnlfdHJhbnNhY3Rpb246Cj4g PiAgICAgICAgICBMT0dFKEVSUk9SLCAiY2Fubm90IGdldCBtZW1vcnkgaW5mbyBmcm9tICVzL21l bW9yeS9zdGF0aWMtbWF4IiwKPiA+ICAgICAgICAgICAgICAgZG9tcGF0aCk7Cj4gPiAgICAgICAg ICBhYm9ydF90cmFuc2FjdGlvbiA9IDE7Cj4gPiArICAgICAgICByYyA9IEVSUk9SX0ZBSUw7Cj4g PiAgICAgICAgICBnb3RvIG91dDsKPiA+ICAgICAgfQo+ID4gICAgICBtZW1vcnlrYiA9IHN0cnRv dWwobWVtbWF4LCAmZW5kcHRyLCAxMCk7Cj4gPiBAQCAtNDg4Myw2ICs0ODg1LDcgQEAgcmV0cnlf dHJhbnNhY3Rpb246Cj4gPiAgICAgICAgICBMT0dFKEVSUk9SLCAiaW52YWxpZCBtYXggbWVtb3J5 ICVzIGZyb20gJXMvbWVtb3J5L3N0YXRpYy1tYXhcbiIsCj4gPiAgICAgICAgICAgICAgIG1lbW1h eCwgZG9tcGF0aCk7Cj4gPiAgICAgICAgICBhYm9ydF90cmFuc2FjdGlvbiA9IDE7Cj4gPiArICAg ICAgICByYyA9IEVSUk9SX0ZBSUw7Cj4gPiAgICAgICAgICBnb3RvIG91dDsKPiA+ICAgICAgfQo+ ID4KPiA+IEBAIC00OTAyLDYgKzQ5MDUsNyBAQCByZXRyeV90cmFuc2FjdGlvbjoKPiA+ICAgICAg ICAgICAgICAibWVtb3J5X2R5bmFtaWNfbWF4IG11c3QgYmUgbGVzcyB0aGFuIG9yIGVxdWFsIHRv Igo+ID4gICAgICAgICAgICAgICIgbWVtb3J5X3N0YXRpY19tYXhcbiIpOwo+ID4gICAgICAgICAg YWJvcnRfdHJhbnNhY3Rpb24gPSAxOwo+ID4gKyAgICAgICAgcmMgPSBFUlJPUl9JTlZBTDsKPiA+ ICAgICAgICAgIGdvdG8gb3V0Owo+ID4gICAgICB9Cj4gPgo+ID4gQEAgLTQ5MDksMzMgKzQ5MTMs MzYgQEAgcmV0cnlfdHJhbnNhY3Rpb246Cj4gPiAgICAgICAgICBMT0coRVJST1IsICJuZXcgdGFy Z2V0ICVkIGZvciBkb20wIGlzIGJlbG93IHRoZSBtaW5pbXVtIHRocmVzaG9sZCIsCj4gPiAgICAg ICAgICAgICAgbmV3X3RhcmdldF9tZW1rYik7Cj4gPiAgICAgICAgICBhYm9ydF90cmFuc2FjdGlv biA9IDE7Cj4gPiArICAgICAgICByYyA9IEVSUk9SX0lOVkFMOwo+ID4gICAgICAgICAgZ290byBv dXQ7Cj4gPiAgICAgIH0KPiA+Cj4gPiAgICAgIGlmIChlbmZvcmNlKSB7Cj4gPiAgICAgICAgICBt ZW1vcnlrYiA9IG5ld190YXJnZXRfbWVta2IgKyB2aWRlb3JhbTsKPiA+IC0gICAgICAgIHJjID0g eGNfZG9tYWluX3NldG1heG1lbShjdHgtPnhjaCwgZG9taWQsIG1lbW9yeWtiICsKPiA+ICsgICAg ICAgIHIgPSB4Y19kb21haW5fc2V0bWF4bWVtKGN0eC0+eGNoLCBkb21pZCwgbWVtb3J5a2IgKwo+ ID4gICAgICAgICAgICAgICAgICBMSUJYTF9NQVhNRU1fQ09OU1RBTlQpOwo+ID4gLSAgICAgICAg aWYgKHJjICE9IDApIHsKPiA+ICsgICAgICAgIGlmIChyICE9IDApIHsKPiA+ICAgICAgICAgICAg ICBMT0dFKEVSUk9SLAo+ID4gICAgICAgICAgICAgICAgICAgInhjX2RvbWFpbl9zZXRtYXhtZW0g ZG9taWQ9JXUgbWVta2I9JSJQUkl1NjQiIGZhaWxlZCAiInJjPSVkXG4iLAo+ID4gICAgICAgICAg ICAgICAgICAgZG9taWQsCj4gPiAgICAgICAgICAgICAgICAgICBtZW1vcnlrYiArIExJQlhMX01B WE1FTV9DT05TVEFOVCwKPiA+IC0gICAgICAgICAgICAgICAgIHJjKTsKPiA+ICsgICAgICAgICAg ICAgICAgIHIpOwo+ID4gICAgICAgICAgICAgIGFib3J0X3RyYW5zYWN0aW9uID0gMTsKPiA+ICsg ICAgICAgICAgICByYyA9IEVSUk9SX0ZBSUw7Cj4gPiAgICAgICAgICAgICAgZ290byBvdXQ7Cj4g PiAgICAgICAgICB9Cj4gPiAgICAgIH0KPiA+Cj4gPiAtICAgIHJjID0geGNfZG9tYWluX3NldF9w b2RfdGFyZ2V0KGN0eC0+eGNoLCBkb21pZCwKPiA+ICsgICAgciA9IHhjX2RvbWFpbl9zZXRfcG9k X3RhcmdldChjdHgtPnhjaCwgZG9taWQsCj4gPiAgICAgICAgICAgICAgKG5ld190YXJnZXRfbWVt a2IgKyBMSUJYTF9NQVhNRU1fQ09OU1RBTlQpIC8gNCwgTlVMTCwgTlVMTCwgTlVMTCk7Cj4gPiAt ICAgIGlmIChyYyAhPSAwKSB7Cj4gPiArICAgIGlmIChyICE9IDApIHsKPiA+ICAgICAgICAgIExP R0UoRVJST1IsCj4gPiAgICAgICAgICAgICAgICJ4Y19kb21haW5fc2V0X3BvZF90YXJnZXQgZG9t aWQ9JWQsIG1lbWtiPSVkICIiZmFpbGVkIHJjPSVkXG4iLAo+ID4gICAgICAgICAgICAgICBkb21p ZCwKPiA+ICAgICAgICAgICAgICAgbmV3X3RhcmdldF9tZW1rYiAvIDQsCj4gPiAtICAgICAgICAg ICAgIHJjKTsKPiA+ICsgICAgICAgICAgICAgcik7Cj4gPiAgICAgICAgICBhYm9ydF90cmFuc2Fj dGlvbiA9IDE7Cj4gPiArICAgICAgICByYyA9IEVSUk9SX0ZBSUw7Cj4gPiAgICAgICAgICBnb3Rv IG91dDsKPiA+ICAgICAgfQo+ID4KPiA+IEBAIC00OTQ5LDYgKzQ5NTYsNyBAQCByZXRyeV90cmFu c2FjdGlvbjoKPiA+ICAgICAgICAgICAgICAgICAgICAgICAiJSJQUkl1MzIsIG5ld190YXJnZXRf bWVta2IgLyAxMDI0KTsKPiA+ICAgICAgbGlieGxfZG9taW5mb19kaXNwb3NlKCZwdHIpOwo+ID4K PiA+ICsgICAgcmMgPSAwOwo+ID4gIG91dDoKPiA+ICAgICAgaWYgKCF4c190cmFuc2FjdGlvbl9l bmQoY3R4LT54c2gsIHQsIGFib3J0X3RyYW5zYWN0aW9uKQo+ID4gICAgICAgICAgJiYgIWFib3J0 X3RyYW5zYWN0aW9uKQo+ID4gLS0KPiA+IDEuOS4xCj4gPgo+ID4KPiA+IF9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gPiBYZW4tZGV2ZWwgbWFpbGluZyBs aXN0Cj4gPiBYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwo+ID4gaHR0cDovL2xpc3RzLnhlbi5vcmcv eGVuLWRldmVsCgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbi5vcmcKaHR0cDov L2xpc3RzLnhlbi5vcmcveGVuLWRldmVsCg==