xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: "Jesus M. Gonzalez-Barahona" <jgb@bitergia.com>
To: Priya <vppriya9@gmail.com>
Cc: Lars Kurth <lars.kurth@xenproject.org>,
	Xen-devel <xen-devel@lists.xen.org>,
	Daniel Izquierdo <dizquierdo@bitergia.com>
Subject: Re: Regarding Outreachy project on Improving CR Dashboard
Date: Wed, 06 Apr 2016 23:59:50 +0200	[thread overview]
Message-ID: <1459979990.7498.156.camel@bitergia.com> (raw)
In-Reply-To: <CAGwjOLPopMwSFLTpfUnOuW6bQZ3zbuzSE3MxixPTVkCyCxHiTQ@mail.gmail.com>

On Wed, 2016-04-06 at 17:30 +0530, Priya wrote:
> Hello,
> Thanks for your suggestions.
> I have made the appropriate changes as you had mentioned.
> It took a little time to change from python3 to python3.4 as perceval
> supports python3.4. I have updated the changes in my github. You can
> see my git repo [1]
> [1]:https://github.com/priya299/Dashboard

Thanks a lot, Priya. Good work. Some preliminary comments, below.

* When runing the script on the xen-devel-2016-03 mbox, I seen an
exception raised:

(perceval)jgb@expisito:~/src/outreachy/Dashboard/dashboard$ python3
createjson.py --mbox xen-devel-2016-03 --output new.json
Traceback (most recent call last):
  File "createjson.py", line 61, in <module>
  File "createjson.py", line 43, in create_json
    if key == k['Message-ID'].strip('<>'):
KeyError: 'Message-ID'

Maybe some message is not having a Message-ID field? I suggest that you
capture this exception, print out the offending message, and go on with
the next one. You can use the Python logging package for printing out
this kind of information (you can see how to use it in the Perceval
package itself). But see below.

* Minor typo in the README:

Instead of 

eg: python3.4 createjson --mbox xen-devel-2016-03 --output new.json

it should be

eg: python3.4 createjson.py --mbox xen-devel-2016-03 --output new.json

* The files have no licensing info. If you agree, it could be GPLv3, as
is Perceval itself. For that, it would be enough that you mimic the
header in Perceval files in your Python files (of course, indicating
your authorship information).

* Which version of Perceval are you using? Some weeks ago, the format
of the dictionary produced by Perceval for each message changed. Now
the  actual fields of the message are in a data subdictionary. Please,
check that: the above exception with respect to the Message-ID key
could be because of this... Please, try to make it work with master
HEAD for Perceval (I don't expect any new major change in the next
days/weeks, and I'll try to warn you in case some happens).

* Could you please write at least one unit test for your code? You can
see examples of the testing schema we use in the tests directory in
Perceval, but we use vanilla unittest (the Python package for tests).
At this stage I don't need that you produce a whole set of tests, only
one or two to show that you know how to write unit tests, please.



> Priya V
> Amrita University
> LinkedIn | GitHub | Bitbucket
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
Bitergia: http://bitergia.com
/me at Twitter: https://twitter.com/jgbarah

Xen-devel mailing list

  reply	other threads:[~2016-04-06 21:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-05 16:35 Regarding Outreachy project on Improving CR Dashboard Priya
2016-04-05 23:23 ` Jesus M. Gonzalez-Barahona
2016-04-06 12:00   ` Priya
2016-04-06 21:59     ` Jesus M. Gonzalez-Barahona [this message]
2016-04-07 12:27       ` Priya
2016-04-07 17:57         ` Jesus M. Gonzalez-Barahona
2016-04-08 14:03           ` Priya
2016-04-11  7:53             ` Jesus M. Gonzalez-Barahona
2016-04-13 16:33               ` Priya
2016-04-14 17:11               ` Priya
2016-04-14 22:41                 ` Jesus M. Gonzalez-Barahona
  -- strict thread matches above, loose matches on Subject: below --
2016-03-19  9:54 Priya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1459979990.7498.156.camel@bitergia.com \
    --to=jgb@bitergia.com \
    --cc=dizquierdo@bitergia.com \
    --cc=lars.kurth@xenproject.org \
    --cc=vppriya9@gmail.com \
    --cc=xen-devel@lists.xen.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).