From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH v2 08/11] xen: sched: allow for choosing
 credit2 runqueues configuration at boot
Date: Fri, 8 Apr 2016 00:45:16 +0200
Message-ID: <1460069116.21741.5.camel@citrix.com>
References: <20160406170023.25877.15622.stgit@Solace.fritz.box>
 <20160406172349.25877.14008.stgit@Solace.fritz.box>
 <5705EA61.4010403@suse.com> <57067717.5010202@citrix.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8940493519963316921=="
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
 by lists.xenproject.org with esmtp (Exim 4.84_2)
 (envelope-from <prvs=898260427=dario.faggioli@citrix.com>)
 id 1aoIg8-0003lH-8D
 for xen-devel@lists.xenproject.org; Thu, 07 Apr 2016 22:45:32 +0000
In-Reply-To: <57067717.5010202@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xen.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xen.org>
To: George Dunlap <george.dunlap@citrix.com>, Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org
Cc: George Dunlap <george.dunlap@eu.citrix.com>, Uma Sharma <uma.sharma523@gmail.com>
List-Id: xen-devel@lists.xenproject.org

--===============8940493519963316921==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-z1R+KF7vEVnyTWd6YWrd"

--=-z1R+KF7vEVnyTWd6YWrd
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, 2016-04-07 at 16:04 +0100, George Dunlap wrote:
> On 07/04/16 06:04, Juergen Gross wrote:
> > On 06/04/16 19:23, Dario Faggioli wrote:
> > > @@ -2170,6 +2234,8 @@ csched2_init(struct scheduler *ops)
> > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0printk(" load_window_shift: %d\n", opt_=
load_window_shift);
> > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0printk(" underload_balance_tolerance: %=
d\n",
> > > opt_underload_balance_tolerance);
> > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0printk(" overload_balance_tolerance: %d=
\n",
> > > opt_overload_balance_tolerance);
> > > +=C2=A0=C2=A0=C2=A0=C2=A0printk(" runqueues arrangement: per-%s\n",
> > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0op=
t_runqueue =3D=3D OPT_RUNQUEUE_CORE ? "core" :
> > > "socket");
> > I asked this before: shouldn't the optiones "node" and "all" be
> > respected here, too?
> Dario, would it make sense to put the string names ("core", "socket",
> &c) in an array, then have both parse_credit2_runqueue() iterate over
> the array to find the appropriate numeric value, and have this use
> the
> array to convert from the numeric value to a string?
>=20
Ok, I'll do that.

Even if I do, though, I can't get rid of the OPT_RUNQUEUE_CORE, etc.,
symbols, as I need to figure out what the numeric value found during
parsing actually means in=C2=A0cpu_to_runqueue().

I know you're not mentioning this, but I felt like I better make this
clear, in case one would expect for those to go away too.

In any case, you'll see this in the patch.

Thanks and Regards,
Dario
--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-z1R+KF7vEVnyTWd6YWrd
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEABECAAYFAlcG4v0ACgkQk4XaBE3IOsQXtQCgi2WyHyIDR7Q2d+Ki54gniAE9
DdMAmgM5njS8FIyFbgOYMrkWuBc5hrcG
=N3Ic
-----END PGP SIGNATURE-----

--=-z1R+KF7vEVnyTWd6YWrd--


--===============8940493519963316921==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs
IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y
Zy94ZW4tZGV2ZWwK

--===============8940493519963316921==--