From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH] xen: sched: fix spinlock issue in schedule_cpu_switch(). Date: Mon, 11 Apr 2016 18:59:23 +0200 Message-ID: <1460393963.13871.99.camel@citrix.com> References: <20160411162701.19274.72053.stgit@Solace.fritz.box> <570BD2EB.4020108@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7180545894785713704==" Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1apfGK-0000LL-FN for xen-devel@lists.xenproject.org; Mon, 11 Apr 2016 17:04:32 +0000 In-Reply-To: <570BD2EB.4020108@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: George Dunlap , xen-devel@lists.xenproject.org Cc: Andrew Cooper , Aaron Cornelius List-Id: xen-devel@lists.xenproject.org --===============7180545894785713704== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-Kl9iRFa7Iq2HabVP4q14" --=-Kl9iRFa7Iq2HabVP4q14 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2016-04-11 at 17:38 +0100, George Dunlap wrote: > On 11/04/16 17:27, Dario Faggioli wrote: > >=20 > > Commit 94734ab7c3f5 ("xen: sched: close potential races > > when switching scheduler to CPUs") buggily replaced a call > > to pcpu_schedule_lock_irq() with just pcpu_schedule_lock(), > > causing the relevant irq_safe vs. non-irq_safe ASSERT() > > in check_lock() to trigger. > >=20 > > Fix that. > >=20 > > Signed-off-by: Dario Faggioli > Acked-by: George Dunlap >=20 Thanks George. Sorry again for the issue, and sorry if it did take longer. I said "Monday morning", but this morning my test box was otherwise busy, and this time, I really wanted to make sure I tested this on a debug build! :-P Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-Kl9iRFa7Iq2HabVP4q14 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlcL1+sACgkQk4XaBE3IOsRZAACfb1FB0/3k4oLnK1ji4O8/iZes xQkAmwQMcJZBPUw1pEpQex1/VpzbI/fY =IkmP -----END PGP SIGNATURE----- --=-Kl9iRFa7Iq2HabVP4q14-- --===============7180545894785713704== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y Zy94ZW4tZGV2ZWwK --===============7180545894785713704==--